Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.
This helps some tools that do things based on the output's extension. For example, we got reports from users on Windows that have a tool that scan a build output dir (but skip .obj files). The tool would keep the "foo.obj-12345" file open, and then when clang tried to rename the temp file to the final output filename, that would fail. By making the tempfile end in ".obj", tools like this will now skip the temp files as well. https://reviews.llvm.org/D36238 llvm-svn: 309984
This commit is contained in:
parent
33eee1911a
commit
09f4992c36
|
@ -759,9 +759,13 @@ std::unique_ptr<llvm::raw_pwrite_stream> CompilerInstance::createOutputFile(
|
|||
|
||||
if (UseTemporary) {
|
||||
// Create a temporary file.
|
||||
SmallString<128> TempPath;
|
||||
TempPath = OutFile;
|
||||
// Insert -%%%%%%%% before the extension (if any), so that tools doing
|
||||
// things based on the file extension do the right thing.
|
||||
StringRef OutputExtension = llvm::sys::path::extension(OutFile);
|
||||
SmallString<128> TempPath =
|
||||
StringRef(OutFile).drop_back(OutputExtension.size());
|
||||
TempPath += "-%%%%%%%%";
|
||||
TempPath += OutputExtension;
|
||||
int fd;
|
||||
std::error_code EC =
|
||||
llvm::sys::fs::createUniqueFile(TempPath, fd, TempPath);
|
||||
|
|
Loading…
Reference in New Issue