diff --git a/llvm/test/Object/Inputs/corrupt-invalid-strtab.elf.x86-64 b/llvm/test/Object/Inputs/corrupt-invalid-strtab.elf.x86-64 new file mode 100755 index 000000000000..bdaa3cf92082 Binary files /dev/null and b/llvm/test/Object/Inputs/corrupt-invalid-strtab.elf.x86-64 differ diff --git a/llvm/test/Object/corrupt.test b/llvm/test/Object/corrupt.test index 0a655704610c..2181c7e8907a 100644 --- a/llvm/test/Object/corrupt.test +++ b/llvm/test/Object/corrupt.test @@ -24,3 +24,10 @@ RUN: not llvm-readobj %p/Inputs/corrupt-version.elf-x86_64 -dt \ RUN: 2>&1 | FileCheck --check-prefix=VER %s VER: Error reading file: Invalid data was encountered while parsing the file. + + +// The file is missing the dynamic string table but has references to it. +RUN: not llvm-readobj -dynamic-table %p/Inputs/corrupt-invalid-strtab.elf.x86-64 \ +RUN: 2>&1 | FileCheck --check-prefix=STRTAB %s + +STRTAB: Invalid dynamic string table reference diff --git a/llvm/tools/llvm-readobj/ELFDumper.cpp b/llvm/tools/llvm-readobj/ELFDumper.cpp index 3deeb8dfe5b4..045f4dfc636f 100644 --- a/llvm/tools/llvm-readobj/ELFDumper.cpp +++ b/llvm/tools/llvm-readobj/ELFDumper.cpp @@ -953,6 +953,14 @@ void printFlags(T Value, ArrayRef> Flags, raw_ostream &OS) { } } +template +static const char *getDynamicString(const ELFFile &O, uint64_t Value) { + const char *Ret = O.getDynamicString(Value); + if (!Ret) + reportError("Invalid dynamic string table reference"); + return Ret; +} + template static void printValue(const ELFFile *O, uint64_t Type, uint64_t Value, bool Is64, raw_ostream &OS) { @@ -1011,14 +1019,14 @@ static void printValue(const ELFFile *O, uint64_t Type, uint64_t Value, OS << Value << " (bytes)"; break; case DT_NEEDED: - OS << "SharedLibrary (" << O->getDynamicString(Value) << ")"; + OS << "SharedLibrary (" << getDynamicString(*O, Value) << ")"; break; case DT_SONAME: - OS << "LibrarySoname (" << O->getDynamicString(Value) << ")"; + OS << "LibrarySoname (" << getDynamicString(*O, Value) << ")"; break; case DT_RPATH: case DT_RUNPATH: - OS << O->getDynamicString(Value); + OS << getDynamicString(*O, Value); break; case DT_MIPS_FLAGS: printFlags(Value, makeArrayRef(ElfDynamicDTMipsFlags), OS); @@ -1088,7 +1096,7 @@ void ELFDumper::printNeededLibraries() { for (const auto &Entry : Obj->dynamic_table()) if (Entry.d_tag == ELF::DT_NEEDED) - Libs.push_back(Obj->getDynamicString(Entry.d_un.d_val)); + Libs.push_back(getDynamicString(*Obj, Entry.d_un.d_val)); std::stable_sort(Libs.begin(), Libs.end()); diff --git a/llvm/tools/llvm-readobj/llvm-readobj.cpp b/llvm/tools/llvm-readobj/llvm-readobj.cpp index b525ce100042..3f03618bb224 100644 --- a/llvm/tools/llvm-readobj/llvm-readobj.cpp +++ b/llvm/tools/llvm-readobj/llvm-readobj.cpp @@ -188,14 +188,14 @@ namespace opts { } // namespace opts -static void reportError(Twine Msg) { +namespace llvm { + +void reportError(Twine Msg) { outs() << Msg << "\n"; outs().flush(); exit(1); } -namespace llvm { - void error(std::error_code EC) { if (!EC) return; diff --git a/llvm/tools/llvm-readobj/llvm-readobj.h b/llvm/tools/llvm-readobj/llvm-readobj.h index 8872fc21a394..58c50f58d750 100644 --- a/llvm/tools/llvm-readobj/llvm-readobj.h +++ b/llvm/tools/llvm-readobj/llvm-readobj.h @@ -19,6 +19,7 @@ namespace llvm { } // Various helper functions. + void reportError(Twine Msg); void error(std::error_code ec); bool relocAddressLess(object::RelocationRef A, object::RelocationRef B);