Commit Graph

63 Commits

Author SHA1 Message Date
Jan Kassens 6d394e3d26
[actions] commit from special branches iff they exist (#26673)
This creates 2 special branches. If these special branches exist, we'll
commit build artifacts from these branches, main otherwise.
2023-04-19 12:11:40 -04:00
Samuel Susla 0018cf2246
Add REVISION file to react-fbsource-import (#26448)
For DiffTrain to fbsource, we need REVISION file in compiled-rn folder
2023-03-21 16:18:20 +00:00
Samuel Susla c57b90f50d
[DiffTrain] Add artifacts for React Native to compiled (#26204) 2023-03-20 11:23:55 +00:00
lauren 6854a3cf6d
[difftrain] Fix broken workflow (#26421)
Seems like CircleCI now enforces passing a token when fetching
artifacts. I provisioned a new read-only CircleCI token just for
difftrain.

test plan: see https://github.com/facebook/react/actions/runs/4450679268
2023-03-17 12:16:55 -07:00
Ricky 21f6dba6a7
Sync from oss-experimental, not oss-stable (#26401)
## Overview

To test useEffectEvent, we need the experimental build of the lint
plugin.
2023-03-15 21:01:07 -04:00
Jan Kassens 3cad3a54ed
Use content hash for facebook-www builds (#26331)
Currently, any commit to React causes an internal sync since the Git
commit hash is part of the build. This creates a lot more sync commits
and noise than necessary, see:
https://github.com/facebook/react/commits/builds/facebook-www

This PR changes the version string to be a hash of the target build
files instead. This way we get a new version with any change that
actually impacts the generated files and still have a matching version
across the files.
2023-03-06 17:13:17 -05:00
lauren bfb9cbd8ca
[difftrain] Make github sha clickable for easier debugging (#26225) 2023-02-23 07:59:22 -08:00
Samuel Susla 2cc54b57ed
Change commit message for DiffTrain commigs (#26203)
Previously, the commit message looked something like this in Github: 
<img width="921" alt="Screenshot 2023-02-20 at 13 52 35"
src="https://user-images.githubusercontent.com/1733610/220126265-d77931e0-18ac-46a0-bf23-d868f8af17a9.png">

With this change, it will look like:

DiffTrain build for commit db5e6250d4.
2023-02-20 15:17:44 +00:00
lauren 21b49103d6
[difftrain] Remove dependency on node-fetch (#26182)
`fetch` is now provided by github-scripts implicitly in
https://github.com/actions/github-script/releases/tag/v6.4.0, so this
was causing a duplicate declaration error.
2023-02-16 12:47:12 -08:00
BIKI DAS 2f40170192
Don't recommend deprecated debugger script (#26171)
yarn debug-test is now deprecated in React package.json. It has been
replaced by yarn test --debug.



https://user-images.githubusercontent.com/72331432/219268188-8ff5dd42-da2b-434c-83be-72a9d258ee98.mp4
2023-02-16 11:11:12 +01:00
lauren 1c7055ddbb
[DiffTrain] Add github url for the commit to the commit message (#25845)
Currently we just append the ref for the commit, let's make it clickable
for easier debugging in syncs.
2022-12-08 11:22:35 -08:00
lauren c961f2f476
[DiffTrain] Add REVISION and REVISION_TRANSFORM to output (#25830)
We use these for the sync script, so to preserve option value let's
continue adding these files so the script can still be used for
arbitrary commits.
2022-12-06 09:55:37 -08:00
lauren 7c39922891
[DiffTrain] Strip @license from files (#25821)
We need to remove this for some internal tests. This was previously in
our upgrade script so adding it back here for parity.

Test plan: files were updated correctly
[[1]](1704bbb826 (diff-80b968e05ce2ceeff6e17c938dc722aff2c1c660f8ef402e6664bc5b2cafa5fbL2))
[[2]](1704bbb826 (diff-6ecd07a61c8e0e28793dace3f9f62751e4808de9c2965aa1ddeb0157f3c9b4ecL2))

Co-authored-by: Jan Kassens <jkassens@meta.com>
2022-12-06 09:01:24 -08:00
lauren cd23e40c73
[DiffTrain] Use original commit message (#25809)
Instead of the current commit message (which just shows "Build for
<sha>", re-use the commit message from the origin commit instead.
2022-12-05 10:56:57 -08:00
lauren 030dae2f4c
[DiffTrain] Fix null artifactsUrl and add more logging (#25768)
Log more info on the status of the process_artifacts_combined job to
help with debugging, and exit with exitcode 1 if anything goes wrong

Test plan: Ran the workflow
[successfully](https://github.com/facebook/react/actions/runs/3595185062)
2022-12-01 11:08:29 -08:00
lauren 799ee65343
[DiffTrain] Tweak folder structure (#25724)
Should hopefully be final tweaks! Sorry about all the noise.

Test plan: temporarily ran the workflow on this branch, verified output
in the builds/facebook-www branch is correct:
bfc0eb6cd4
2022-11-21 14:35:52 -08:00
lauren 62e2b1374b
[DiffTrain] Fix incorrect build path (#25723) 2022-11-21 13:00:50 -08:00
lauren e58b6c158b
Reorganize build folders for DiffTrain (#25722)
Reorganize some files to make the DiffTrain config easier to setup. Also
add unstable_server-external-runtime to sync.
2022-11-21 12:42:49 -08:00
lauren 13681aaf9c
Add github action to commit build artifacts for Facebook (#25721)
This PR adds a new GitHub action to commit build artifacts for Facebook
into a new protected branch. This will later be used to setup an
automatic sync to www.

The hacky spinloop is meant to be a temporary implementation until we
can support running a script internally on top of the synced diff
(coming soon). A GitHub token is otherwise required if we want to setup
a pub/sub between cirleci and github but it's not straightforward to
provision one for our org. So this workaround should do for now since we
won't keep it around for too long.

Example of it running and creating a commit on the `builds/facebook-www`
branch:
https://github.com/facebook/react/actions/runs/3516958576/jobs/5894251359
2022-11-21 11:03:23 -08:00
dan b76103d66f
Remove React 18 issue template (#24220)
React 18 is just React now.
2022-03-30 19:37:31 +01:00
Dan Abramov 771da6e27b
Update PULL_REQUEST_TEMPLATE.md 2021-09-07 07:54:34 +01:00
Dan Abramov 6f64eb5aa0
Update PULL_REQUEST_TEMPLATE.md 2021-09-06 20:36:46 +01:00
Dan Abramov cdb08ebe0a
Update PULL_REQUEST_TEMPLATE.md 2021-09-06 20:36:24 +01:00
Brian Vaughn d483463bc8
Updated scripts and config to replace "master" with "main" branch (#21768) 2021-06-29 14:26:24 -04:00
Brian Vaughn 3ba2b67f21
Update react_18.md 2021-06-11 14:27:09 -04:00
Brian Vaughn 905f6f48d4
Update react_18.md 2021-06-11 14:25:47 -04:00
Brian Vaughn ca4e650ec1
Update react_18.md 2021-06-11 14:24:09 -04:00
Brian Vaughn 42a89d5c61
Update react_18.md 2021-06-11 14:22:57 -04:00
Brian Vaughn 1e3ceadcc0
Added React 18 issue template 2021-06-11 14:19:37 -04:00
Brian Vaughn 5151466bab Updated DevTools bug Workflow
Workflow now auto-assigns issues needing more information to the person who reported them
2021-05-27 09:49:44 -04:00
Brian Vaughn bb1c821556
Fixed localhost URL check
Noticed that it missed 21568 because of a leading "/"
2021-05-26 10:43:51 -04:00
Brian Vaughn a731a51696
Add GitHub action to check for bug repro (#21542) 2021-05-21 15:48:12 -04:00
Brian Vaughn e0bffeeb01
Update devtools_bug_report.yml 2021-05-20 14:52:08 -04:00
Brian Vaughn 549aaacbb0
Update devtools_bug_report.yml 2021-05-20 14:51:35 -04:00
Brian Vaughn 3890fb52fe
Update devtools_bug_report.yml 2021-05-08 10:46:02 -04:00
Brian Vaughn 57768ef90b
Update devtools_bug_report.yml
Tweaked label to include emoji characters.
2021-05-07 09:10:50 -04:00
Brian Vaughn 6005a6ab2b
Update devtools_bug_report.yml 2021-05-07 08:48:34 -04:00
Brian Vaughn 85b543c6b4
Added new GitHub issue form for React DevTools bug reports (#21450)
Added a new bug report template built with GitHub issue forms:
https://gh-community.github.io/issue-template-feedback/structured/

And updated DevTools bug report link to send information formatted for this new template.
2021-05-07 08:46:58 -04:00
Ricky 880587366d
Deprecate old test script commands (#19893)
* Deprecate old test script commands

* Update PR template test script

* Add test-stable and test-www-classic

* Update circle test names

* Rename test-www-classic to test-classic

* Missed some job renames

* Missed some more job renames
2020-10-14 08:54:34 -04:00
Ricky 30b47103d4
Fix spelling errors and typos (#19138) 2020-06-15 19:59:44 -04:00
Toru Kobayashi dbf2bba632
remove an unused ISSUE_TEMPLATE.md (#18953) 2020-05-19 08:44:01 -07:00
Dan Abramov c74f0b0646
Update stale.yml 2020-04-09 13:36:11 +01:00
Dan Abramov bce982b799
Change stalebot messages (#18524) 2020-04-07 17:30:45 +01:00
Dan Abramov 99d779f629
Don't close "Needs Investigation" issues (#18458) 2020-04-01 22:08:09 +01:00
Ryota Murakami 48c4867d74
Update issue templates to directly link to relevant sources (#18039)
GitHub supports linking to off-site sources for certain types of issue.
2020-02-18 10:30:00 -08:00
Nicolas Gallagher 64aae7b06f
Fix issue template for questions (#17817) 2020-01-10 10:57:34 -08:00
Nicolas Gallagher 05e487a12f
Add GitHub issue templates (#17815) 2020-01-09 16:16:37 -08:00
Nicolas Gallagher 2e4948a34d
Add configuration for the "Stale" GitHub App (#17806)
Configuration for the bot that marks and closes stale issues and pull requests.
https://probot.github.io/apps/stale/
2020-01-09 11:13:41 -08:00
Dan Abramov 2517be99ac
Reword issue template 2018-01-03 15:58:07 +00:00
Dan Abramov 2d7aafd9d1
Oops 2017-12-07 12:04:51 +00:00