Remove redundant test steps (#26161)
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary This TODO mentions an issue with JSDOM that [seems to have been resolved](https://github.com/jsdom/jsdom/pull/2996). <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> ## How did you test this change? - Ensured that the `document.activeElement` is no longer `node` after `node.blur` is called. - Verified that the tests still pass. - Looked for [a merged PR that fixes the issue](https://github.com/jsdom/jsdom/pull/2996). <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. -->
This commit is contained in:
parent
86c8c8db79
commit
fccf3a9fba
|
@ -1880,13 +1880,7 @@ describe('ReactDOMInput', () => {
|
|||
node.focus();
|
||||
setUntrackedValue.call(node, '2');
|
||||
dispatchEventOnNode(node, 'input');
|
||||
// TODO: it is unclear why blur must be triggered twice,
|
||||
// manual testing in the fixtures shows that the active element
|
||||
// is no longer the input, however blur() + a blur event seem to
|
||||
// be the only way to remove focus in JSDOM
|
||||
node.blur();
|
||||
dispatchEventOnNode(node, 'blur');
|
||||
dispatchEventOnNode(node, 'focusout');
|
||||
|
||||
if (disableInputAttributeSyncing) {
|
||||
expect(node.value).toBe('2');
|
||||
|
@ -1906,13 +1900,7 @@ describe('ReactDOMInput', () => {
|
|||
node.focus();
|
||||
setUntrackedValue.call(node, 4);
|
||||
dispatchEventOnNode(node, 'input');
|
||||
// TODO: it is unclear why blur must be triggered twice,
|
||||
// manual testing in the fixtures shows that the active element
|
||||
// is no longer the input, however blur() + a blur event seem to
|
||||
// be the only way to remove focus in JSDOM
|
||||
node.blur();
|
||||
dispatchEventOnNode(node, 'blur');
|
||||
dispatchEventOnNode(node, 'focusout');
|
||||
|
||||
expect(node.getAttribute('value')).toBe('1');
|
||||
});
|
||||
|
@ -1926,13 +1914,7 @@ describe('ReactDOMInput', () => {
|
|||
node.focus();
|
||||
setUntrackedValue.call(node, 4);
|
||||
dispatchEventOnNode(node, 'input');
|
||||
// TODO: it is unclear why blur must be triggered twice,
|
||||
// manual testing in the fixtures shows that the active element
|
||||
// is no longer the input, however blur() + a blur event seem to
|
||||
// be the only way to remove focus in JSDOM
|
||||
node.blur();
|
||||
dispatchEventOnNode(node, 'blur');
|
||||
dispatchEventOnNode(node, 'focusout');
|
||||
|
||||
expect(node.getAttribute('value')).toBe('1');
|
||||
});
|
||||
|
|
Loading…
Reference in New Issue