maxjhandsome
/
react
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Fresh] Add options to configure RefreshSig and RefreshReg identifiers (#17340)

This commit is contained in:
Vasilii Cuhar 2019-11-12 16:16:23 +02:00 committed by Dan Abramov
parent ade764157f
commit f4cc45ce96
3 changed files with 43 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/react-refresh/src/ReactFreshBabelPlugin.js vendored
View File

@ -22,6 +22,8 @@ export default function(babel, opts = {}) {
}
const {types: t} = babel;
const refreshReg = t.identifier(opts.refreshReg || '$RefreshReg$');
const refreshSig = t.identifier(opts.refreshSig || '$RefreshSig$');
const registrationsByProgramPath = new Map();
function createRegistration(programPath, persistentID) {
@ -517,7 +519,7 @@ export default function(babel, opts = {}) {
const sigCallID = path.scope.generateUidIdentifier('_s');
path.scope.parent.push({
id: sigCallID,
init: t.callExpression(t.identifier('$RefreshSig$'), []),
init: t.callExpression(refreshSig, []),
});
// The signature call is split in two parts. One part is called inside the function.
@ -579,7 +581,7 @@ export default function(babel, opts = {}) {
const sigCallID = path.scope.generateUidIdentifier('_s');
path.scope.parent.push({
id: sigCallID,
init: t.callExpression(t.identifier('$RefreshSig$'), []),
init: t.callExpression(refreshSig, []),
});
// The signature call is split in two parts. One part is called inside the function.
@ -743,7 +745,7 @@ export default function(babel, opts = {}) {
path.pushContainer(
'body',
t.expressionStatement(
t.callExpression(t.identifier('$RefreshReg$'), [
t.callExpression(refreshReg, [
handle,
t.stringLiteral(persistentID),
]),

18
packages/react-refresh/src/__tests__/ReactFreshBabelPlugin-test.js vendored
View File

@ -25,6 +25,7 @@ function transform(input, options = {}) {
skipEnvCheck: true,
// To simplify debugging tests:
emitFullSignatures: true,
...options.freshOptions,
},
],
...(options.plugins || []),
@ -480,4 +481,21 @@ describe('ReactFreshBabelPlugin', () => {
`),
).toMatchSnapshot();
});
it('uses custom identifiers for $RefreshReg$ and $RefreshSig$', () => {
expect(
transform(
`export default function Bar () {
useContext(X)
return <Foo />
};`,
{
freshOptions: {
refreshReg: 'import.meta.refreshReg',
refreshSig: 'import.meta.refreshSig',
},
},
),
).toMatchSnapshot();
});
});

20
packages/react-refresh/src/__tests__/__snapshots__/ReactFreshBabelPlugin-test.js.snap
View File

@ -574,6 +574,26 @@ $RefreshReg$(_c, "Hello");
$RefreshReg$(_c2, "Bar");
`;
exports[`ReactFreshBabelPlugin uses custom identifiers for $RefreshReg$ and $RefreshSig$ 1`] = `
var _s = import.meta.refreshSig();
export default function Bar() {
_s();
useContext(X);
return <Foo />;
}
_s(Bar, "useContext{}");
_c = Bar;
;
var _c;
import.meta.refreshReg(_c, "Bar");
`;
exports[`ReactFreshBabelPlugin uses original function declaration if it get reassigned 1`] = `
function Hello() {
return <h1>Hi</h1>;