maxjhandsome
/
react
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remote `.internal` override from untrusted URL tests (#26372) 

Adding `.internal` to a test file prevents it from being tested in build
mode. The best practice is to instead gate the test based on whether the
feature is enabled.

Ideally we'd use the `@gate` pragma in these tests, but the `itRenders`
test helpers don't support that.
This commit is contained in:
Andrew Clark 2023-03-11 15:46:16 -05:00 committed by GitHub
parent 6334614860
commit f411e8990f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
packages/react-dom/src/__tests__/ReactDOMServerIntegrationUntrustedURL-test.internal.js → packages/react-dom/src/__tests__/ReactDOMServerIntegrationUntrustedURL-test.js vendored
View File

@ -149,6 +149,13 @@ function runTests(itRenders, itRejectsRendering, expectToReject) {
}
describe('ReactDOMServerIntegration - Untrusted URLs', () => {
// The `itRenders` helpers don't work with the gate pragma, so we have to do
// this instead.
if (gate(flags => flags.disableJavaScriptURLs)) {
it("empty test so Jest doesn't complain", () => {});
return;
}
function initModules() {
jest.resetModules();
React = require('react');
@ -181,6 +188,13 @@ describe('ReactDOMServerIntegration - Untrusted URLs', () => {
});
describe('ReactDOMServerIntegration - Untrusted URLs - disableJavaScriptURLs', () => {
// The `itRenders` helpers don't work with the gate pragma, so we have to do
// this instead.
if (gate(flags => !flags.disableJavaScriptURLs)) {
it("empty test so Jest doesn't complain", () => {});
return;
}
function initModules() {
jest.resetModules();
const ReactFeatureFlags = require('shared/ReactFeatureFlags');

11
scripts/jest/setupTests.www.js
View File

@ -6,16 +6,7 @@ jest.mock('shared/ReactFeatureFlags', () => {
() => jest.requireActual('shared/forks/ReactFeatureFlags.www-dynamic'),
{virtual: true}
);
const wwwFlags = jest.requireActual('shared/forks/ReactFeatureFlags.www');
const defaultFlags = jest.requireActual('shared/ReactFeatureFlags');
// TODO: Many tests were written before we started running them against the
// www configuration. Update those tests so that they work against the www
// configuration, too. Then remove these overrides.
wwwFlags.disableJavaScriptURLs = defaultFlags.disableJavaScriptURLs;
return wwwFlags;
return jest.requireActual('shared/forks/ReactFeatureFlags.www');
});
jest.mock('scheduler/src/SchedulerFeatureFlags', () => {