maxjhandsome
/
react
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix www tests not running in prod (#18593) 

I made a mistake when setting these up a while ago. Setting the NODE_ENV
in the CircleCI config doesn't work because it's also set in the node
script command.

The number of test commands is getting out of control. Might need to fix
it at some point. Not today for me.
This commit is contained in:
Andrew Clark 2020-04-13 15:53:13 -07:00 committed by GitHub
parent bec7599067
commit f3f3d77c20
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
.circleci/config.yml
View File

@ -138,7 +138,7 @@ jobs:
RELEASE_CHANNEL: stable RELEASE_CHANNEL: stable
command: yarn test-www-variant --maxWorkers=2 command: yarn test-www-variant --maxWorkers=2
RELEASE_CHANNEL_stable_NODE_ENV_production_yarn_test_www: RELEASE_CHANNEL_stable_yarn_test_prod_www:
docker: *docker docker: *docker
environment: *environment environment: *environment
steps: steps:
@ -147,11 +147,10 @@ jobs:
- *run_yarn - *run_yarn
- run: - run:
environment: environment:
NODE_ENV: production
RELEASE_CHANNEL: stable RELEASE_CHANNEL: stable
command: yarn test-www --maxWorkers=2 command: yarn test-prod-www --maxWorkers=2
RELEASE_CHANNEL_stable_NODE_ENV_production_yarn_test_www_variant: RELEASE_CHANNEL_stable_yarn_test_prod_www_variant:
docker: *docker docker: *docker
environment: *environment environment: *environment
steps: steps:
@ -160,9 +159,8 @@ jobs:
- *run_yarn - *run_yarn
- run: - run:
environment: environment:
NODE_ENV: production
RELEASE_CHANNEL: stable RELEASE_CHANNEL: stable
command: yarn test-www-variant --maxWorkers=2 command: yarn test-prod-www-variant --maxWorkers=2
yarn_test_www: yarn_test_www:
docker: *docker docker: *docker
@ -188,7 +186,7 @@ jobs:
RELEASE_CHANNEL: experimental RELEASE_CHANNEL: experimental
command: yarn test-www-variant --maxWorkers=2 command: yarn test-www-variant --maxWorkers=2
NODE_ENV_production_yarn_test_www: yarn_test_prod_www:
docker: *docker docker: *docker
environment: *environment environment: *environment
steps: steps:
@ -197,11 +195,10 @@ jobs:
- *run_yarn - *run_yarn
- run: - run:
environment: environment:
NODE_ENV: production
RELEASE_CHANNEL: experimental RELEASE_CHANNEL: experimental
command: yarn test-www --maxWorkers=2 command: yarn test-prod-www --maxWorkers=2
NODE_ENV_production_yarn_test_www_variant: yarn_test_prod_www_variant:
docker: *docker docker: *docker
environment: *environment environment: *environment
steps: steps:
@ -210,7 +207,6 @@ jobs:
- *run_yarn - *run_yarn
- run: - run:
environment: environment:
NODE_ENV: production
RELEASE_CHANNEL: experimental RELEASE_CHANNEL: experimental
command: yarn test-www-variant --maxWorkers=2 command: yarn test-www-variant --maxWorkers=2
@ -489,10 +485,10 @@ workflows:
- RELEASE_CHANNEL_stable_yarn_test_www_variant: - RELEASE_CHANNEL_stable_yarn_test_www_variant:
requires: requires:
- setup - setup
- RELEASE_CHANNEL_stable_NODE_ENV_production_yarn_test_www: - RELEASE_CHANNEL_stable_yarn_test_prod_www:
requires: requires:
- setup - setup
- RELEASE_CHANNEL_stable_NODE_ENV_production_yarn_test_www_variant: - RELEASE_CHANNEL_stable_yarn_test_prod_www_variant:
requires: requires:
- setup - setup
- RELEASE_CHANNEL_stable_yarn_build: - RELEASE_CHANNEL_stable_yarn_build:
@ -532,10 +528,10 @@ workflows:
- yarn_test_www_variant: - yarn_test_www_variant:
requires: requires:
- setup - setup
- NODE_ENV_production_yarn_test_www: - yarn_test_prod_www:
requires: requires:
- setup - setup
- NODE_ENV_production_yarn_test_www_variant: - yarn_test_prod_www_variant:
requires: requires:
- setup - setup
- yarn_build: - yarn_build:

2
package.json
View File

@ -110,6 +110,8 @@
"test": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source.js", "test": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source.js",
"test-www": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source-www.js", "test-www": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source-www.js",
"test-www-variant": "cross-env NODE_ENV=development VARIANT=true jest --config ./scripts/jest/config.source-www.js", "test-www-variant": "cross-env NODE_ENV=development VARIANT=true jest --config ./scripts/jest/config.source-www.js",
"test-prod-www": "cross-env NODE_ENV=production jest --config ./scripts/jest/config.source-www.js",
"test-prod-www-variant": "cross-env NODE_ENV=production VARIANT=true jest --config ./scripts/jest/config.source-www.js",
"test-persistent": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source-persistent.js", "test-persistent": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source-persistent.js",
"debug-test-persistent": "cross-env NODE_ENV=development node --inspect-brk node_modules/jest/bin/jest.js --config ./scripts/jest/config.source-persistent.js --runInBand", "debug-test-persistent": "cross-env NODE_ENV=development node --inspect-brk node_modules/jest/bin/jest.js --config ./scripts/jest/config.source-persistent.js --runInBand",
"test-prod": "cross-env NODE_ENV=production jest --config ./scripts/jest/config.source.js", "test-prod": "cross-env NODE_ENV=production jest --config ./scripts/jest/config.source.js",