From ee409ea3b577f9ff37d36ccbfc642058ad783bb0 Mon Sep 17 00:00:00 2001 From: Luna Ruan Date: Mon, 17 Aug 2020 17:32:50 -0700 Subject: [PATCH] change destroy to safelyCallDestroy (#19605) We use safelyCallDestroy for commitUnmount and passive effects unmounts but we call destroy directly in commitHookEffectListUnmount (AKA layout effects unmounts because we don't use this anywhere else). This PR changes the direct destroy call to safelyCallDestroy for consistency --- packages/react-reconciler/src/ReactFiberCommitWork.new.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js index db3fa4d57d..adc61e1aaf 100644 --- a/packages/react-reconciler/src/ReactFiberCommitWork.new.js +++ b/packages/react-reconciler/src/ReactFiberCommitWork.new.js @@ -335,7 +335,7 @@ function commitHookEffectListUnmount(tag: HookEffectTag, finishedWork: Fiber) { const destroy = effect.destroy; effect.destroy = undefined; if (destroy !== undefined) { - destroy(); + safelyCallDestroy(finishedWork, destroy); } } effect = effect.next;