maxjhandsome
/
react
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[React Native FB] dynamic feature flag for ref access warning (#25471)

This commit is contained in:
Jan Kassens 2022-10-14 10:11:42 -04:00 committed by GitHub
parent fd31724d5d
commit ea5bc6bac1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js
View File

@ -7,10 +7,8 @@
* @flow strict * @flow strict
*/ */
// NOTE: There are no flags, currently. Uncomment the stuff below if we add one. import typeof * as ExportsType from './ReactFeatureFlags.native-fb-dynamic';
import typeof * as DynamicFlagsType from 'ReactNativeInternalFeatureFlags';
// import typeof * as ExportsType from './ReactFeatureFlags.native-fb-dynamic';
// import typeof * as DynamicFlagsType from 'ReactNativeInternalFeatureFlags';
// In xplat, these flags are controlled by GKs. Because most GKs have some // In xplat, these flags are controlled by GKs. Because most GKs have some
// population running in either mode, we should run our tests that way, too, // population running in either mode, we should run our tests that way, too,
@ -22,5 +20,7 @@
// flag here but it won't be set to `true` in any of our test runs. Need to // flag here but it won't be set to `true` in any of our test runs. Need to
// update the test configuration. // update the test configuration.
// // Flow magic to verify the exports of this file match the original version. export const enableUseRefAccessWarning = __VARIANT__;
// ((((null: any): ExportsType): FeatureFlagsType): ExportsType);
// Flow magic to verify the exports of this file match the original version.
((((null: any): ExportsType): DynamicFlagsType): ExportsType);

5
packages/shared/forks/ReactFeatureFlags.native-fb.js
View File

@ -13,11 +13,11 @@ import typeof * as ExportsType from './ReactFeatureFlags.native-fb';
// NOTE: There are no flags, currently. Uncomment the stuff below if we add one. // NOTE: There are no flags, currently. Uncomment the stuff below if we add one.
// Re-export dynamic flags from the internal module. Intentionally using * // Re-export dynamic flags from the internal module. Intentionally using *
// because this import is compiled to a `require` call. // because this import is compiled to a `require` call.
// import * as dynamicFlags from 'ReactNativeInternalFeatureFlags'; import * as dynamicFlags from 'ReactNativeInternalFeatureFlags';
// We destructure each value before re-exporting to avoid a dynamic look-up on // We destructure each value before re-exporting to avoid a dynamic look-up on
// the exports object every time a flag is read. // the exports object every time a flag is read.
// export const {} = dynamicFlags; export const {enableUseRefAccessWarning} = dynamicFlags;
// The rest of the flags are static for better dead code elimination. // The rest of the flags are static for better dead code elimination.
export const enableDebugTracing = false; export const enableDebugTracing = false;
@ -67,7 +67,6 @@ export const deferRenderPhaseUpdateToNextBatch = false;
export const enableStrictEffects = __DEV__; export const enableStrictEffects = __DEV__;
export const createRootStrictEffectsByDefault = false; export const createRootStrictEffectsByDefault = false;
export const enableUseRefAccessWarning = false;
export const disableSchedulerTimeoutInWorkLoop = false; export const disableSchedulerTimeoutInWorkLoop = false;
export const enableLazyContextPropagation = false; export const enableLazyContextPropagation = false;

1
scripts/flow/xplat.js
View File

@ -8,4 +8,5 @@
*/ */
declare module 'ReactNativeInternalFeatureFlags' { declare module 'ReactNativeInternalFeatureFlags' {
declare export var enableUseRefAccessWarning: boolean;
} }