Remove coverage options from package.json

They don't provide any value and since one of them isn't a valid config usage,
it blurs the line. Instead just store these pieces in the tasks and write them
to the temp config.
This commit is contained in:
Paul O’Shannessy 2015-12-22 11:14:44 -08:00
parent f3dbc40261
commit e68e17503e
2 changed files with 13 additions and 13 deletions

View File

@ -19,13 +19,22 @@ var tempConfigPath = path.join(buildPath, 'jest-config.json');
var config = require(path.join(rootPath, 'package.json')).jest;
var collectCoverageOnlyFrom = {
'src/**/*.js': {
ignore: [
'src/**/__tests__/*.js',
'src/shared/vendor/third_party/*.js',
'src/test/*.js',
],
},
};
function getCollectCoverageOnlyFrom(callback) {
var coverageFrom = config.collectCoverageOnlyFrom;
var patterns = Object.keys((config.collectCoverage && coverageFrom) || {});
var patterns = Object.keys(collectCoverageOnlyFrom);
var result = {};
async.each(patterns, function(pattern) {
var options = assign({ nodir: true }, coverageFrom[pattern]);
var options = assign({ nodir: true }, collectCoverageOnlyFrom[pattern]);
glob(pattern, options, function(err, files) {
(files || []).reduce(function(object, key) {
object[key] = true;
@ -44,6 +53,7 @@ function getJestConfig(callback) {
getCollectCoverageOnlyFrom(function(err, data) {
callback(err, assign({}, config, {
rootDir: rootDir,
collectCoverage: true,
collectCoverageOnlyFrom: data,
}));
});

View File

@ -57,16 +57,6 @@
"test": "jest"
},
"jest": {
"collectCoverage": true,
"collectCoverageOnlyFrom": {
"src/**/*.js": {
"ignore": [
"src/**/__tests__/*.js",
"src/shared/vendor/third_party/*.js",
"src/test/*.js"
]
}
},
"modulePathIgnorePatterns": [
"/.module-cache/",
"/react/build/"