maxjhandsome
/
react
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Fix mistyped script arbitrary code execution vulnerability (#18660)" (#19018) 

This reverts commit e5cc1462b3.
This commit is contained in:
Dan Abramov 2020-05-27 17:37:27 +01:00 committed by GitHub
parent 55cb0b7eeb
commit b41beb1a35
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/react-dom/src/client/ReactDOMComponent.js vendored
View File

@ -430,13 +430,11 @@ export function createElement(
namespaceURI = getIntrinsicNamespace(type);
}
if (namespaceURI === HTML_NAMESPACE) {
const lowerCaseType = type.toLowerCase();
if (__DEV__) {
isCustomComponentTag = isCustomComponent(type, props);
// Should this check be gated by parent namespace? Not sure we want to
// allow <SVG> or <mATH>.
if (!isCustomComponentTag && type !== lowerCaseType) {
if (!isCustomComponentTag && type !== type.toLowerCase()) {
console.error(
'<%s /> is using incorrect casing. ' +
'Use PascalCase for React components, ' +
@ -446,7 +444,7 @@ export function createElement(
}
}
if (lowerCaseType === 'script') {
if (type === 'script') {
// Create the script via .innerHTML so its "parser-inserted" flag is
// set to true and it does not execute
const div = ownerDocument.createElement('div');

16
packages/react-dom/src/client/__tests__/trustedTypes-test.internal.js
View File

@ -242,20 +242,4 @@ describe('when Trusted Types are available in global object', () => {
// check that the warning is printed only once
ReactDOM.render(<script>alert("I am not executed")</script>, container);
});
it('should warn twice when rendering scRipt tag and prevent code execution on mistyped tag', () => {
expect(() => {
ReactDOM.render(<scRipt>alert("I am not executed")</scRipt>, container);
}).toErrorDev([
'Warning: <scRipt /> is using incorrect casing. ' +
'Use PascalCase for React components, ' +
'or lowercase for HTML elements.\n' +
' in scRipt (at **)',
'Warning: Encountered a script tag while rendering React component. ' +
'Scripts inside React components are never executed when rendering ' +
'on the client. Consider using template tag instead ' +
'(https://developer.mozilla.org/en-US/docs/Web/HTML/Element/template).\n' +
' in scRipt (at **)',
]);
});
});