maxjhandsome
/
react
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove tests in ReactDOMComponent-test depending on internal API (#11337) 

* Remove inputValueTracking from ReactDOMComponent-test dependency

* prettier

* use node._valueTracker and add some test cases to make sure that value being tracked

* using Object.getOwnPropertyDescriptor to get the tracked value

* move getValueTracker to each test case and use its corresponding prototype

* remove tests and move the value tracker definition before React is imported

* Delete these tests completely
This commit is contained in:
Audy Tanudjaja 2017-11-10 19:01:59 +07:00 committed by Dan Abramov
parent 54051f9738
commit ae7639c116
1 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
packages/react-dom/src/__tests__/ReactDOMComponent-test.js vendored
View File

@ -14,7 +14,6 @@ describe('ReactDOMComponent', () => {
var ReactTestUtils;
var ReactDOM;
var ReactDOMServer;
var inputValueTracking;
function normalizeCodeLocInfo(str) {
return str && str.replace(/\(at .+?:\d+\)/g, '(at **)');
@ -26,8 +25,6 @@ describe('ReactDOMComponent', () => {
ReactDOM = require('react-dom');
ReactDOMServer = require('react-dom/server');
ReactTestUtils = require('react-dom/test-utils');
// TODO: can we express this test with only public API?
inputValueTracking = require('../client/inputValueTracking');
});
describe('updateDOM', () => {
@ -1174,27 +1171,6 @@ describe('ReactDOMComponent', () => {
);
});
it('should track input values', () => {
var container = document.createElement('div');
var inst = ReactDOM.render(
<input type="text" defaultValue="foo" />,
container,
);
var tracker = inputValueTracking._getTrackerFromNode(inst);
expect(tracker.getValue()).toEqual('foo');
});
it('should track textarea values', () => {
var container = document.createElement('div');
var inst = ReactDOM.render(<textarea defaultValue="foo" />, container);
var tracker = inputValueTracking._getTrackerFromNode(inst);
expect(tracker.getValue()).toEqual('foo');
});
it('should throw for children on void elements', () => {
class X extends React.Component {
render() {