maxjhandsome
/
react
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[react devtools][easy] Rename LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY to LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY (#25154) 

* This more accurately describes what this constant does
This commit is contained in:
Robert Balicki 2022-08-30 13:32:52 -04:00 committed by GitHub
parent 9ff738f53f
commit aa80a309b1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/react-devtools-shared/src/constants.js vendored
View File

@ -51,7 +51,7 @@ export const SESSION_STORAGE_RELOAD_AND_PROFILE_KEY =
export const LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS = export const LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS =
'React::DevTools::breakOnConsoleErrors'; 'React::DevTools::breakOnConsoleErrors';
export const LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY = export const LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY =
'React::DevTools::appendComponentStack'; 'React::DevTools::appendComponentStack';
export const LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY = export const LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY =

4
packages/react-devtools-shared/src/devtools/views/Settings/SettingsContext.js vendored
View File

@ -20,7 +20,7 @@ import {
COMPACT_LINE_HEIGHT, COMPACT_LINE_HEIGHT,
LOCAL_STORAGE_PARSE_HOOK_NAMES_KEY, LOCAL_STORAGE_PARSE_HOOK_NAMES_KEY,
LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS, LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS,
LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY, LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY,
LOCAL_STORAGE_TRACE_UPDATES_ENABLED_KEY, LOCAL_STORAGE_TRACE_UPDATES_ENABLED_KEY,
LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY, LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY,
LOCAL_STORAGE_HIDE_CONSOLE_LOGS_IN_STRICT_MODE, LOCAL_STORAGE_HIDE_CONSOLE_LOGS_IN_STRICT_MODE,
@ -117,7 +117,7 @@ function SettingsContextController({
appendComponentStack, appendComponentStack,
setAppendComponentStack, setAppendComponentStack,
] = useLocalStorageWithLog<boolean>( ] = useLocalStorageWithLog<boolean>(
LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY, LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY,
true, true,
); );
const [ const [

6
packages/react-devtools-shared/src/utils.js vendored
View File

@ -40,7 +40,7 @@ import {
LOCAL_STORAGE_FILTER_PREFERENCES_KEY, LOCAL_STORAGE_FILTER_PREFERENCES_KEY,
LOCAL_STORAGE_OPEN_IN_EDITOR_URL, LOCAL_STORAGE_OPEN_IN_EDITOR_URL,
LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS, LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS,
LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY, LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY,
LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY, LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY,
LOCAL_STORAGE_HIDE_CONSOLE_LOGS_IN_STRICT_MODE, LOCAL_STORAGE_HIDE_CONSOLE_LOGS_IN_STRICT_MODE,
} from './constants'; } from './constants';
@ -343,7 +343,7 @@ export function saveComponentFilters(
export function getAppendComponentStack(): boolean { export function getAppendComponentStack(): boolean {
try { try {
const raw = localStorageGetItem(LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY); const raw = localStorageGetItem(LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY);
if (raw != null) { if (raw != null) {
return JSON.parse(raw); return JSON.parse(raw);
} }
@ -353,7 +353,7 @@ export function getAppendComponentStack(): boolean {
export function setAppendComponentStack(value: boolean): void { export function setAppendComponentStack(value: boolean): void {
localStorageSetItem( localStorageSetItem(
LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY, LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY,
JSON.stringify(value), JSON.stringify(value),
); );
} }