From aa80a309b19d59832ffeb82dfb6235da0c93dd42 Mon Sep 17 00:00:00 2001 From: Robert Balicki Date: Tue, 30 Aug 2022 13:32:52 -0400 Subject: [PATCH] [react devtools][easy] Rename LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY to LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY (#25154) * This more accurately describes what this constant does --- packages/react-devtools-shared/src/constants.js | 2 +- .../src/devtools/views/Settings/SettingsContext.js | 4 ++-- packages/react-devtools-shared/src/utils.js | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/react-devtools-shared/src/constants.js b/packages/react-devtools-shared/src/constants.js index d7fafc082c..2406f4876d 100644 --- a/packages/react-devtools-shared/src/constants.js +++ b/packages/react-devtools-shared/src/constants.js @@ -51,7 +51,7 @@ export const SESSION_STORAGE_RELOAD_AND_PROFILE_KEY = export const LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS = 'React::DevTools::breakOnConsoleErrors'; -export const LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY = +export const LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY = 'React::DevTools::appendComponentStack'; export const LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY = diff --git a/packages/react-devtools-shared/src/devtools/views/Settings/SettingsContext.js b/packages/react-devtools-shared/src/devtools/views/Settings/SettingsContext.js index 3ee4ad0c86..d9c522ca68 100644 --- a/packages/react-devtools-shared/src/devtools/views/Settings/SettingsContext.js +++ b/packages/react-devtools-shared/src/devtools/views/Settings/SettingsContext.js @@ -20,7 +20,7 @@ import { COMPACT_LINE_HEIGHT, LOCAL_STORAGE_PARSE_HOOK_NAMES_KEY, LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS, - LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY, + LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY, LOCAL_STORAGE_TRACE_UPDATES_ENABLED_KEY, LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY, LOCAL_STORAGE_HIDE_CONSOLE_LOGS_IN_STRICT_MODE, @@ -117,7 +117,7 @@ function SettingsContextController({ appendComponentStack, setAppendComponentStack, ] = useLocalStorageWithLog( - LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY, + LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY, true, ); const [ diff --git a/packages/react-devtools-shared/src/utils.js b/packages/react-devtools-shared/src/utils.js index 77a75dd2c6..49179f60d5 100644 --- a/packages/react-devtools-shared/src/utils.js +++ b/packages/react-devtools-shared/src/utils.js @@ -40,7 +40,7 @@ import { LOCAL_STORAGE_FILTER_PREFERENCES_KEY, LOCAL_STORAGE_OPEN_IN_EDITOR_URL, LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS, - LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY, + LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY, LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY, LOCAL_STORAGE_HIDE_CONSOLE_LOGS_IN_STRICT_MODE, } from './constants'; @@ -343,7 +343,7 @@ export function saveComponentFilters( export function getAppendComponentStack(): boolean { try { - const raw = localStorageGetItem(LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY); + const raw = localStorageGetItem(LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY); if (raw != null) { return JSON.parse(raw); } @@ -353,7 +353,7 @@ export function getAppendComponentStack(): boolean { export function setAppendComponentStack(value: boolean): void { localStorageSetItem( - LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY, + LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY, JSON.stringify(value), ); }