From 9b4e4e1759353fe51b1c03059cf02f02226a3563 Mon Sep 17 00:00:00 2001
From: Dustan Kasten <dustan.kasten@gmail.com>
Date: Tue, 10 Oct 2017 11:57:25 -0400
Subject: [PATCH] Fix obscure error message when passing an invalid style value
 for SSR (#11173)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Add failing iframe test

* Possible fix by returning null ownerName in SSR

* prettier

* eslolint

* gah c’mon really?

* emptyFunction.thatReturnsNull

* One less property access
---
 .../dom/shared/__tests__/ReactServerRendering-test.js    | 9 +++++++++
 src/renderers/shared/server/ReactPartialRenderer.js      | 4 +++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/renderers/dom/shared/__tests__/ReactServerRendering-test.js b/src/renderers/dom/shared/__tests__/ReactServerRendering-test.js
index 632f7306c1..30d93363b5 100644
--- a/src/renderers/dom/shared/__tests__/ReactServerRendering-test.js
+++ b/src/renderers/dom/shared/__tests__/ReactServerRendering-test.js
@@ -358,6 +358,15 @@ describe('ReactDOMServer', () => {
         'Objects are not valid as a React child (found: object with keys {x})',
       );
     });
+
+    it('should throw prop mapping error for an <iframe /> with invalid props', () => {
+      expect(() =>
+        ReactDOMServer.renderToString(<iframe style="border:none;" />),
+      ).toThrowError(
+        'The `style` prop expects a mapping from style properties to values, not ' +
+          "a string. For example, style={{marginRight: spacing + 'em'}} when using JSX.",
+      );
+    });
   });
 
   describe('renderToStaticMarkup', () => {
diff --git a/src/renderers/shared/server/ReactPartialRenderer.js b/src/renderers/shared/server/ReactPartialRenderer.js
index 9f7e41ffd1..26ffaef0e3 100644
--- a/src/renderers/shared/server/ReactPartialRenderer.js
+++ b/src/renderers/shared/server/ReactPartialRenderer.js
@@ -20,6 +20,7 @@ var ReactControlledValuePropTypes = require('ReactControlledValuePropTypes');
 
 var assertValidProps = require('assertValidProps');
 var dangerousStyleValue = require('dangerousStyleValue');
+var emptyFunction = require('fbjs/lib/emptyFunction');
 var emptyObject = require('fbjs/lib/emptyObject');
 var escapeTextContentForBrowser = require('escapeTextContentForBrowser');
 var hyphenateStyleName = require('fbjs/lib/hyphenateStyleName');
@@ -29,6 +30,7 @@ var omittedCloseTags = require('omittedCloseTags');
 var isCustomComponent = require('isCustomComponent');
 
 var toArray = React.Children.toArray;
+var emptyFunctionThatReturnsNull = emptyFunction.thatReturnsNull;
 
 if (__DEV__) {
   var warning = require('fbjs/lib/warning');
@@ -780,7 +782,7 @@ class ReactDOMServerRenderer {
       validatePropertiesInDevelopment(tag, props);
     }
 
-    assertValidProps(tag, props);
+    assertValidProps(tag, props, emptyFunctionThatReturnsNull);
 
     var out = createOpenTagMarkup(
       element.type,