From 95e22ff528c875b090de51a0fb0d83181c4d1111 Mon Sep 17 00:00:00 2001 From: Andrew Clark Date: Thu, 7 Jul 2022 16:57:42 -0400 Subject: [PATCH] Delete Partial Renderer SSR implementation (#24868) This removes the old server rendering implementation (the "Partial Renderer"). It was replaced in React 18 with a new streaming implementation (Fizz). We hadn't removed it from the codebase yet because Facebook hadn't finished rolling out Fizz in production; it's been behind a feature flag while we run performance tests and migrate our internal infrastructure. The diff to land Fizz will land imminently, and once it does, we can merge this commit. --- .../__tests__/ReactDOMHydrationDiff-test.js | 33 +- ...DOMServerPartialHydration-test.internal.js | 18 +- .../__tests__/ReactServerRendering-test.js | 9 +- .../ReactServerRenderingHydration-test.js | 2 - .../ReactDOMLegacyServerBrowser.classic.fb.js | 16 - .../ReactDOMLegacyServerNode.classic.fb.js | 19 - ...ctDOMServerLegacyPartialRendererBrowser.js | 32 - .../src/server/ReactDOMStringRenderer.js | 39 - .../src/server/ReactPartialRenderer.js | 1646 ----------------- .../src/server/ReactPartialRendererContext.js | 160 -- .../src/server/ReactPartialRendererHooks.js | 555 ------ 11 files changed, 11 insertions(+), 2518 deletions(-) delete mode 100644 packages/react-dom/src/server/ReactDOMLegacyServerBrowser.classic.fb.js delete mode 100644 packages/react-dom/src/server/ReactDOMLegacyServerNode.classic.fb.js delete mode 100644 packages/react-dom/src/server/ReactDOMServerLegacyPartialRendererBrowser.js delete mode 100644 packages/react-dom/src/server/ReactDOMStringRenderer.js delete mode 100644 packages/react-dom/src/server/ReactPartialRenderer.js delete mode 100644 packages/react-dom/src/server/ReactPartialRendererContext.js delete mode 100644 packages/react-dom/src/server/ReactPartialRendererHooks.js diff --git a/packages/react-dom/src/__tests__/ReactDOMHydrationDiff-test.js b/packages/react-dom/src/__tests__/ReactDOMHydrationDiff-test.js index e8e7dffee5..080bc04734 100644 --- a/packages/react-dom/src/__tests__/ReactDOMHydrationDiff-test.js +++ b/packages/react-dom/src/__tests__/ReactDOMHydrationDiff-test.js @@ -11,7 +11,6 @@ let React; let ReactDOMClient; let ReactDOMServer; let act; -let usingPartialRenderer; const util = require('util'); const realConsoleError = console.error; @@ -26,8 +25,6 @@ describe('ReactDOMServerHydration', () => { ReactDOMServer = require('react-dom/server'); act = require('react-dom/test-utils').act; - usingPartialRenderer = global.__WWW__ && !__EXPERIMENTAL__; - console.error = jest.fn(); container = document.createElement('div'); document.body.appendChild(container); @@ -731,15 +728,13 @@ describe('ReactDOMServerHydration', () => { ); } - // @TODO FB bundles use a different renderer that does not serialize errors to the client - const mismatchEl = usingPartialRenderer ? '

' : '