maxjhandsome
/
react
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove _resetEventPlugins, use jest.resetModuleRegistry (#9111) 

* Move EventPluginRegistry._resetEventPlugins to DEV

This is not called during runtime at all and is only using in internal unit tests. Despite that, its currently being included in production builds. This change makes it so its only defined in DEV, which might even be too much (we can maybe inject it in our unit tests to avoid defining it at all in EventPluginRegistry)

* Remove _resetEventsPlugin, use resetModuleRegistry
This commit is contained in:
Brandon Dail 2017-03-06 20:25:24 -06:00 committed by Dan Abramov
parent d79c6ab995
commit 6ca2140c73
2 changed files with 1 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
src/renderers/shared/shared/event/EventPluginRegistry.js
View File

@ -255,45 +255,6 @@ var EventPluginRegistry = {
recomputePluginOrdering(); recomputePluginOrdering();
} }
}, },
/**
* Exposed for unit testing.
* @private
*/
_resetEventPlugins: function(): void {
eventPluginOrder = null;
for (var pluginName in namesToPlugins) {
if (namesToPlugins.hasOwnProperty(pluginName)) {
delete namesToPlugins[pluginName];
}
}
EventPluginRegistry.plugins.length = 0;
var eventNameDispatchConfigs = EventPluginRegistry.eventNameDispatchConfigs;
for (var eventName in eventNameDispatchConfigs) {
if (eventNameDispatchConfigs.hasOwnProperty(eventName)) {
delete eventNameDispatchConfigs[eventName];
}
}
var registrationNameModules = EventPluginRegistry.registrationNameModules;
for (var registrationName in registrationNameModules) {
if (registrationNameModules.hasOwnProperty(registrationName)) {
delete registrationNameModules[registrationName];
}
}
if (__DEV__) {
var possibleRegistrationNames =
EventPluginRegistry.possibleRegistrationNames;
for (var lowerCasedName in possibleRegistrationNames) {
if (possibleRegistrationNames.hasOwnProperty(lowerCasedName)) {
delete possibleRegistrationNames[lowerCasedName];
}
}
}
},
}; };
module.exports = EventPluginRegistry; module.exports = EventPluginRegistry;

2
src/renderers/shared/shared/event/__tests__/EventPluginRegistry-test.js
View File

@ -17,8 +17,8 @@ describe('EventPluginRegistry', () => {
var createPlugin; var createPlugin;
beforeEach(() => { beforeEach(() => {
jest.resetModuleRegistry();
EventPluginRegistry = require('EventPluginRegistry'); EventPluginRegistry = require('EventPluginRegistry');
EventPluginRegistry._resetEventPlugins();
createPlugin = function(properties) { createPlugin = function(properties) {
return Object.assign({extractEvents: function() {}}, properties); return Object.assign({extractEvents: function() {}}, properties);