From ce46068def53cfc9aeb957604214a562abf08dd1 Mon Sep 17 00:00:00 2001 From: Toru Kobayashi Date: Wed, 3 Jun 2015 10:34:50 +0900 Subject: [PATCH] Remove the codes relating to jshint --- Gruntfile.js | 1 - grunt/config/jshint.js | 27 -------------- package.json | 1 - src/.jshintrc | 35 ------------------- .../link/__tests__/LinkedStateMixin-test.js | 1 - .../dom/client/utils/getEventModifierState.js | 1 - .../dom/client/wrappers/ReactDOMForm.js | 3 -- .../dom/client/wrappers/ReactDOMInput.js | 1 - .../dom/client/wrappers/ReactDOMSelect.js | 1 - .../dom/client/wrappers/ReactDOMTextarea.js | 1 - .../wrappers/__tests__/ReactDOMButton-test.js | 1 - .../wrappers/__tests__/ReactDOMInput-test.js | 1 - .../wrappers/__tests__/ReactDOMOption-test.js | 1 - .../wrappers/__tests__/ReactDOMSelect-test.js | 1 - vendor/browser-transforms.js | 1 - 15 files changed, 77 deletions(-) delete mode 100644 grunt/config/jshint.js delete mode 100644 src/.jshintrc diff --git a/Gruntfile.js b/Gruntfile.js index 11f21ee714..f6861ef6ef 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -31,7 +31,6 @@ module.exports = function(grunt) { './examples/shared/*.js', '.module-cache', ], - jshint: require('./grunt/config/jshint'), /*eslint-disable camelcase */ compare_size: require('./grunt/config/compare_size'), /*eslint-enable camelcase */ diff --git a/grunt/config/jshint.js b/grunt/config/jshint.js deleted file mode 100644 index 264670d4f4..0000000000 --- a/grunt/config/jshint.js +++ /dev/null @@ -1,27 +0,0 @@ -'use strict'; - -module.exports = { - src: { - options: { - jshintrc: './src/.jshintrc', - }, - files: { - // We don't care about src/vendor (we shouldn't be touching this), and - // tests often use JSX, which JSHint can't handle. - src: [ - './src/**/*.js', - '!./src/vendor/**', - '!./src/**/__tests__/**', - '!./src/test/**', - ], - }, - }, - project: { - options: { - jshintrc: './.jshintrc', - }, - files: { - src: ['./Gruntfile.js', './grunt/**/*.js', './bin/*.js', './vendor/*.js'], - }, - }, -}; diff --git a/package.json b/package.json index d96c5f6e9f..f23d8096cc 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,6 @@ "grunt-contrib-clean": "^0.6.0", "grunt-contrib-compress": "^0.13.0", "grunt-contrib-connect": "~0.6.0", - "grunt-contrib-jshint": "^0.10.0", "grunt-jest": "^0.1.2", "gzip-js": "~0.3.2", "jasmine-tapreporter": "~0.2.2", diff --git a/src/.jshintrc b/src/.jshintrc deleted file mode 100644 index 2455fe8bc6..0000000000 --- a/src/.jshintrc +++ /dev/null @@ -1,35 +0,0 @@ -{ - "browser": true, - "esnext": true, - - "bitwise": true, - "boss": true, - "curly": true, - "devel": true, - "eqnull": true, - "expr": true, - "funcscope": true, - "globalstrict": true, - "loopfunc": true, - "newcap": false, - "noempty": true, - "nonstandard": true, - "maxlen": 80, - "sub": false, - "undef": true, - "unused": "vars", - - "globals": { - "__DEV__": false, - "exports": false, - "module": false, - "require": false, - - "afterEach": false, - "beforeEach": false, - "describe": false, - "expect": false, - "it": false, - "spyOn": false - } -} diff --git a/src/addons/link/__tests__/LinkedStateMixin-test.js b/src/addons/link/__tests__/LinkedStateMixin-test.js index 99a956a141..db1b1e6f31 100644 --- a/src/addons/link/__tests__/LinkedStateMixin-test.js +++ b/src/addons/link/__tests__/LinkedStateMixin-test.js @@ -11,7 +11,6 @@ 'use strict'; -/*jshint evil:true */ describe('LinkedStateMixin', function() { var LinkedStateMixin; diff --git a/src/renderers/dom/client/utils/getEventModifierState.js b/src/renderers/dom/client/utils/getEventModifierState.js index 2d4cffd14b..fd36cd2a59 100644 --- a/src/renderers/dom/client/utils/getEventModifierState.js +++ b/src/renderers/dom/client/utils/getEventModifierState.js @@ -28,7 +28,6 @@ var modifierKeyToProp = { // modifier keys exposed by the event itself, does not support Lock-keys. // Currently, all major browsers except Chrome seems to support Lock-keys. function modifierStateGetter(keyArg) { - /*jshint validthis:true */ var syntheticEvent = this; var nativeEvent = syntheticEvent.nativeEvent; if (nativeEvent.getModifierState) { diff --git a/src/renderers/dom/client/wrappers/ReactDOMForm.js b/src/renderers/dom/client/wrappers/ReactDOMForm.js index debd8a512b..3a1237527e 100644 --- a/src/renderers/dom/client/wrappers/ReactDOMForm.js +++ b/src/renderers/dom/client/wrappers/ReactDOMForm.js @@ -32,9 +32,6 @@ var ReactDOMForm = ReactClass.createClass({ mixins: [ReactBrowserComponentMixin, LocalEventTrapMixin], render: function() { - // TODO: Instead of using `ReactDOM` directly, we should use JSX. However, - // `jshint` fails to parse JSX so in order for linting to work in the open - // source repo, we need to just use `ReactDOM.form`. return form(this.props); }, diff --git a/src/renderers/dom/client/wrappers/ReactDOMInput.js b/src/renderers/dom/client/wrappers/ReactDOMInput.js index 9a1bb797a7..b95e773926 100644 --- a/src/renderers/dom/client/wrappers/ReactDOMInput.js +++ b/src/renderers/dom/client/wrappers/ReactDOMInput.js @@ -23,7 +23,6 @@ var invariant = require('invariant'); var instancesByReactID = {}; function forceUpdateIfMounted() { - /*jshint validthis:true */ if (this._rootNodeID) { // DOM component is still mounted; update ReactDOMInput.updateWrapper(this); diff --git a/src/renderers/dom/client/wrappers/ReactDOMSelect.js b/src/renderers/dom/client/wrappers/ReactDOMSelect.js index 3b308c36d9..a6ddf74821 100644 --- a/src/renderers/dom/client/wrappers/ReactDOMSelect.js +++ b/src/renderers/dom/client/wrappers/ReactDOMSelect.js @@ -29,7 +29,6 @@ var valueContextKey = '__ReactDOMSelect_value$' + Math.random().toString(36).slice(2); function updateOptionsIfPendingUpdateAndMounted() { - /*jshint validthis:true */ if (this._pendingUpdate) { this._pendingUpdate = false; var value = LinkedValueUtils.getValue(this.props); diff --git a/src/renderers/dom/client/wrappers/ReactDOMTextarea.js b/src/renderers/dom/client/wrappers/ReactDOMTextarea.js index bb421ea14e..d00eff2695 100644 --- a/src/renderers/dom/client/wrappers/ReactDOMTextarea.js +++ b/src/renderers/dom/client/wrappers/ReactDOMTextarea.js @@ -29,7 +29,6 @@ var warning = require('warning'); var textarea = ReactElement.createFactory('textarea'); function forceUpdateIfMounted() { - /*jshint validthis:true */ if (this.isMounted()) { this.forceUpdate(); } diff --git a/src/renderers/dom/client/wrappers/__tests__/ReactDOMButton-test.js b/src/renderers/dom/client/wrappers/__tests__/ReactDOMButton-test.js index 7d1fc85a29..3e28a9b35f 100644 --- a/src/renderers/dom/client/wrappers/__tests__/ReactDOMButton-test.js +++ b/src/renderers/dom/client/wrappers/__tests__/ReactDOMButton-test.js @@ -11,7 +11,6 @@ 'use strict'; -/*jshint evil:true */ var mocks = require('mocks'); diff --git a/src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js b/src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js index d9408dc7de..469bc4eab2 100644 --- a/src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js +++ b/src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js @@ -11,7 +11,6 @@ 'use strict'; -/*jshint evil:true */ var emptyFunction = require('emptyFunction'); var mocks = require('mocks'); diff --git a/src/renderers/dom/client/wrappers/__tests__/ReactDOMOption-test.js b/src/renderers/dom/client/wrappers/__tests__/ReactDOMOption-test.js index 64e7a34df7..8d7146f983 100644 --- a/src/renderers/dom/client/wrappers/__tests__/ReactDOMOption-test.js +++ b/src/renderers/dom/client/wrappers/__tests__/ReactDOMOption-test.js @@ -11,7 +11,6 @@ 'use strict'; -/*jshint evil:true */ describe('ReactDOMOption', function() { var React; diff --git a/src/renderers/dom/client/wrappers/__tests__/ReactDOMSelect-test.js b/src/renderers/dom/client/wrappers/__tests__/ReactDOMSelect-test.js index f1268369d6..b46ad709d7 100644 --- a/src/renderers/dom/client/wrappers/__tests__/ReactDOMSelect-test.js +++ b/src/renderers/dom/client/wrappers/__tests__/ReactDOMSelect-test.js @@ -11,7 +11,6 @@ 'use strict'; -/*jshint evil:true */ var mocks = require('mocks'); diff --git a/vendor/browser-transforms.js b/vendor/browser-transforms.js index b6dc4aba7f..2ca0f81a84 100644 --- a/vendor/browser-transforms.js +++ b/vendor/browser-transforms.js @@ -6,7 +6,6 @@ * LICENSE file in the root directory of this source tree. An additional grant * of patent rights can be found in the PATENTS file in the same directory. */ -/* jshint browser: true */ /* jslint evil: true */ /*eslint-disable no-eval */ /*eslint-disable block-scoped-var */