maxjhandsome
/
react
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix radio buttons using stale props in Fiber (#9126) 

D4662269
This commit is contained in:
Ben Alpert 2017-03-06 14:58:29 -08:00 committed by GitHub
parent 0b06b0b35e
commit 678cb70da2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/renderers/dom/fiber/wrappers/ReactDOMFiberInput.js
View File

@ -292,16 +292,16 @@ function updateNamedCousins(rootNode, props) {
// and the same name are rendered into the same form (same as #1939). // and the same name are rendered into the same form (same as #1939).
// That's probably okay; we don't support it just as we don't support // That's probably okay; we don't support it just as we don't support
// mixing React radio buttons with non-React ones. // mixing React radio buttons with non-React ones.
var otherInstance = ReactDOMComponentTree.getInstanceFromNode(otherNode); var otherProps = ReactDOMComponentTree.getFiberCurrentPropsFromNode(otherNode);
invariant( invariant(
otherInstance, otherProps,
'ReactDOMInput: Mixing React and non-React radio inputs with the ' + 'ReactDOMInput: Mixing React and non-React radio inputs with the ' +
'same `name` is not supported.' 'same `name` is not supported.'
); );
// If this is a controlled radio button group, forcing the input that // If this is a controlled radio button group, forcing the input that
// was previously checked to update will cause it to be come re-checked // was previously checked to update will cause it to be come re-checked
// as appropriate. // as appropriate.
ReactDOMInput.updateWrapper(otherNode, otherInstance.memoizedProps); ReactDOMInput.updateWrapper(otherNode, otherProps);
} }
} }
} }