maxjhandsome
/
react
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Tweak syntax in rollup build script (#9852) 

* Tweak syntax in rollup build script

@bvaughn and I already discussed this.

**test plan:**
`yarn build`

* Remove JSDoc comments

**what is the change?:**
removing some comments

**why make this change?:**
The code is basically self explanatory and these comments could get out
of sync.

**test plan:**
Visual inspection, `yarn build` and `yarn test`

**issue:**
https://github.com/facebook/react/issues/9398
This commit is contained in:
Flarnie Marchan 2017-06-06 07:26:47 -07:00 committed by GitHub
parent 467dda6863
commit 30e6c6c9c9
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
scripts/rollup/build.js
View File

@ -194,13 +194,12 @@ function getFilename(name, hasteName, bundleType) {
}
}
function uglifyConfig({
mangle,
manglePropertiesOnProd,
preserveVersionHeader,
removeComments,
headerSanityCheck,
}) {
function uglifyConfig(configs) {
var mangle = configs.mangle;
var manglePropertiesOnProd = configs.manglePropertiesOnProd;
var preserveVersionHeader = configs.preserveVersionHeader;
var removeComments = configs.removeComments;
var headerSanityCheck = configs.headerSanityCheck;
return {
warnings: false,
compress: {