diff --git a/packages/react-dom-bindings/src/shared/DOMProperty.js b/packages/react-dom-bindings/src/shared/DOMProperty.js index 9e7b7bf677..44a6eee22b 100644 --- a/packages/react-dom-bindings/src/shared/DOMProperty.js +++ b/packages/react-dom-bindings/src/shared/DOMProperty.js @@ -636,7 +636,19 @@ properties[xlinkHref] = new PropertyInfoRecord( false, // removeEmptyString ); -['src', 'href', 'action', 'formAction'].forEach(attributeName => { +const formAction = 'formAction'; +// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions +properties[formAction] = new PropertyInfoRecord( + 'formAction', + STRING, + false, // mustUseProperty + 'formaction', // attributeName + null, // attributeNamespace + true, // sanitizeURL + false, // removeEmptyString +); + +['src', 'href', 'action'].forEach(attributeName => { // $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions properties[attributeName] = new PropertyInfoRecord( attributeName, diff --git a/packages/react-dom/src/__tests__/ReactDOMComponent-test.js b/packages/react-dom/src/__tests__/ReactDOMComponent-test.js index e0fe178d2f..c4d4204d30 100644 --- a/packages/react-dom/src/__tests__/ReactDOMComponent-test.js +++ b/packages/react-dom/src/__tests__/ReactDOMComponent-test.js @@ -533,29 +533,17 @@ describe('ReactDOMComponent', () => { expect(node.hasAttribute('action')).toBe(false); }); - it('should not add an empty formAction attribute', () => { + it('allows empty string of a formAction to override the default of a parent', () => { const container = document.createElement('div'); - expect(() => - ReactDOM.render(