maxjhandsome
/
react
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove flow check in electron app.js (#26184) 

When we were upgrading flow in
6ddcbd4f96
we added `$FlowFixMe` for some parameters in this file. However, this
file is not compiled at all, and the `:` syntax breaks the code.

This PR removes the flow check in this file
This commit is contained in:
Mengdi Chen 2023-02-17 11:54:43 -05:00 committed by GitHub
parent 4fcc9184ac
commit 1a49e2d833
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/react-devtools/app.js vendored
View File

@ -3,8 +3,6 @@
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
*/
const {app, BrowserWindow} = require('electron'); // Module to create native browser window.
@ -40,17 +38,12 @@ app.on('ready', function () {
}
// https://stackoverflow.com/questions/32402327/
// $FlowFixMe[incompatible-use] found when upgrading Flow
mainWindow.webContents.on(
'new-window',
function (event: $FlowFixMe, url: $FlowFixMe) {
event.preventDefault();
require('electron').shell.openExternal(url);
},
);
mainWindow.webContents.on('new-window', function (event, url) {
event.preventDefault();
require('electron').shell.openExternal(url);
});
// and load the index.html of the app.
// $FlowFixMe[incompatible-use] found when upgrading Flow
mainWindow.loadURL('file://' + __dirname + '/app.html'); // eslint-disable-line no-path-concat
// $FlowFixMe[incompatible-use] found when upgrading Flow
mainWindow.webContents.executeJavaScript(
@ -61,7 +54,6 @@ app.on('ready', function () {
);
// Emitted when the window is closed.
// $FlowFixMe[incompatible-use] found when upgrading Flow
mainWindow.on('closed', function () {
mainWindow = null;
});