huawei
/
openGauss-server
5
0
Fork 77
Code Issues Pull Requests 24 Projects Releases Wiki Activity

!455 Fix MOT checkpoint SerializeInProcessTxns return value 

Merge pull request !455 from Vinoth Veeraraghavan/master
This commit is contained in:
opengauss-bot 2020-12-02 15:54:18 +08:00 committed by Gitee
parent 8e5bb201bf 7ca7df6105
commit b0df454ca0
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/gausskernel/storage/mot/core/src/system/checkpoint/checkpoint_manager.cpp
View File

@ -841,7 +841,7 @@ bool CheckpointManager::CreateTpcRecoveryFile()
break;
}
if (tpcFileHeader.m_numEntries > 0 && SerializeInProcessTxns(fd) == false) {
if (tpcFileHeader.m_numEntries > 0 && SerializeInProcessTxns(fd) != RC_OK) {
MOT_LOG_ERROR("create2PCRecoveryFile: failed to serialize transactions [%d %s]", errno, gs_strerror(errno));
break;
}
@ -861,11 +861,11 @@ bool CheckpointManager::CreateTpcRecoveryFile()
return ret;
}
bool CheckpointManager::SerializeInProcessTxns(int fd)
RC CheckpointManager::SerializeInProcessTxns(int fd)
{
if (fd == -1) {
MOT_LOG_ERROR("SerializeInProcessTxns: bad fd");
return false;
return RC_ERROR;
}
auto serializeLambda = [this, fd](RedoLogTransactionSegments* segments, uint64_t) -> RC {

4
src/gausskernel/storage/mot/core/src/system/checkpoint/checkpoint_manager.h
View File

@ -387,9 +387,9 @@ private:
/**
* @brief Serializes inProcess transactions to disk
* @return Boolean value denoting success or failure.
* @return RC value denoting the status of the operation.
*/
bool SerializeInProcessTxns(int fd);
RC SerializeInProcessTxns(int fd);
void ResetFlags();