folkslinux
/
zfs
mirror of https://github.com/openzfs/zfs.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

vdev_disk_error() prints ASCII SOH to debug log 

Currently vdev_disk_error() prepends its messages sent to the internal
ZFS debug log with KERN_WARNING, which is currently defined as follows:

   #define KERN_SOH      "\001"
   #define KERN_WARNING  KERN_SOH "4"

Since "\001" (ASCII Start Of Header) is not printable this results in
weird characters displayed when inspecting the debug log. This commit
simply removes this superfluous prefix passed to zfs_dbgmsg().

Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes #7936
This commit is contained in:
LOLi 2018-09-21 18:42:42 +02:00 committed by Brian Behlendorf
parent 9d489ab3a8
commit dda5500853
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
module/zfs/vdev_disk.c
View File

@ -139,10 +139,9 @@ bdev_max_capacity(struct block_device *bdev, uint64_t wholedisk)
static void
vdev_disk_error(zio_t *zio)
{
zfs_dbgmsg(KERN_WARNING "zio error=%d type=%d offset=%llu size=%llu "
"flags=%x\n", zio->io_error, zio->io_type,
(u_longlong_t)zio->io_offset, (u_longlong_t)zio->io_size,
zio->io_flags);
zfs_dbgmsg("zio error=%d type=%d offset=%llu size=%llu flags=%x\n",
zio->io_error, zio->io_type, (u_longlong_t)zio->io_offset,
(u_longlong_t)zio->io_size, zio->io_flags);
}
/*