From 2b54cb14517b8b3877716dbe02fe75f12a47eb5e Mon Sep 17 00:00:00 2001
From: Chunwei Chen <david.chen@osnexus.com>
Date: Tue, 5 Apr 2016 17:32:23 -0700
Subject: [PATCH] Add zfs-tests for relatime

Add atime_003_pos to test relatime=on, we do check_atime_updated twice, the
first time should success and the second time should fail. We also modify
atime_001_pos to do check_atime_updated twice and both times should succeed.

Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #4482
---
 tests/runfiles/linux.run                      |  2 +-
 .../tests/functional/atime/Makefile.am        |  3 +-
 .../tests/functional/atime/atime_001_pos.ksh  |  2 +
 .../tests/functional/atime/atime_003_pos.ksh  | 70 +++++++++++++++++++
 4 files changed, 75 insertions(+), 2 deletions(-)
 create mode 100755 tests/zfs-tests/tests/functional/atime/atime_003_pos.ksh

diff --git a/tests/runfiles/linux.run b/tests/runfiles/linux.run
index 9857dba1ae..c275468c99 100644
--- a/tests/runfiles/linux.run
+++ b/tests/runfiles/linux.run
@@ -25,7 +25,7 @@ outputdir = /var/tmp/test_results
 tests = ['posix_002_pos']
 
 [tests/functional/atime]
-tests = ['atime_001_pos', 'atime_002_neg']
+tests = ['atime_001_pos', 'atime_002_neg', 'atime_003_pos']
 
 # DISABLED:
 # bootfs_006_pos - needs investigation
diff --git a/tests/zfs-tests/tests/functional/atime/Makefile.am b/tests/zfs-tests/tests/functional/atime/Makefile.am
index ff268e349f..e072925544 100644
--- a/tests/zfs-tests/tests/functional/atime/Makefile.am
+++ b/tests/zfs-tests/tests/functional/atime/Makefile.am
@@ -5,4 +5,5 @@ dist_pkgdata_SCRIPTS = \
 	cleanup.ksh \
 	setup.ksh \
 	atime_001_pos.ksh \
-	atime_002_neg.ksh
+	atime_002_neg.ksh \
+	atime_003_pos.ksh
diff --git a/tests/zfs-tests/tests/functional/atime/atime_001_pos.ksh b/tests/zfs-tests/tests/functional/atime/atime_001_pos.ksh
index 891e22102e..5db0eaf143 100755
--- a/tests/zfs-tests/tests/functional/atime/atime_001_pos.ksh
+++ b/tests/zfs-tests/tests/functional/atime/atime_001_pos.ksh
@@ -59,6 +59,8 @@ do
 		log_mustnot check_atime_updated $mtpt/$TESTFILE
 	else
 		log_must $ZFS set atime=on $dst
+		log_must $ZFS set relatime=off $dst
+		log_must check_atime_updated $mtpt/$TESTFILE
 		log_must check_atime_updated $mtpt/$TESTFILE
 	fi
 done
diff --git a/tests/zfs-tests/tests/functional/atime/atime_003_pos.ksh b/tests/zfs-tests/tests/functional/atime/atime_003_pos.ksh
new file mode 100755
index 0000000000..359f4a055c
--- /dev/null
+++ b/tests/zfs-tests/tests/functional/atime/atime_003_pos.ksh
@@ -0,0 +1,70 @@
+#!/bin/ksh -p
+#
+# CDDL HEADER START
+#
+# The contents of this file are subject to the terms of the
+# Common Development and Distribution License (the "License").
+# You may not use this file except in compliance with the License.
+#
+# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
+# or http://www.opensolaris.org/os/licensing.
+# See the License for the specific language governing permissions
+# and limitations under the License.
+#
+# When distributing Covered Code, include this CDDL HEADER in each
+# file and include the License file at usr/src/OPENSOLARIS.LICENSE.
+# If applicable, add the following below this CDDL HEADER, with the
+# fields enclosed by brackets "[]" replaced with your own identifying
+# information: Portions Copyright [yyyy] [name of copyright owner]
+#
+# CDDL HEADER END
+#
+
+#
+# Copyright 2007 Sun Microsystems, Inc.  All rights reserved.
+# Use is subject to license terms.
+#
+
+. $STF_SUITE/tests/functional/atime/atime_common.kshlib
+
+#
+# DESCRIPTION:
+# When relatime=on, verify the access time for files is updated when first
+# read but not on second.
+# It is available to fs and clone. To snapshot, it is unavailable.
+#
+# STRATEGY:
+# 1. Create pool and fs.
+# 2. Create '$TESTFILE' for fs.
+# 3. Create snapshot and clone.
+# 4. Setting atime=on and relatime=on on datasets.
+# 5. Expect the access time is updated for first read but not on second.
+#
+
+verify_runnable "both"
+
+log_assert "Setting relatime=on, the access time for files is updated when \
+	when read the first time, but not second time."
+log_onexit cleanup
+
+#
+# Create $TESTFILE, snapshot and clone.
+#
+setup_snap_clone
+
+for dst in $TESTPOOL/$TESTFS $TESTPOOL/$TESTCLONE $TESTPOOL/$TESTFS@$TESTSNAP
+do
+	typeset mtpt=$(get_prop mountpoint $dst)
+
+	if [[ $dst == $TESTPOOL/$TESTFS@$TESTSNAP ]]; then
+		mtpt=$(snapshot_mountpoint $dst)
+		log_mustnot check_atime_updated $mtpt/$TESTFILE
+	else
+		log_must $ZFS set atime=on $dst
+		log_must $ZFS set relatime=on $dst
+		log_must check_atime_updated $mtpt/$TESTFILE
+		log_mustnot check_atime_updated $mtpt/$TESTFILE
+	fi
+done
+
+log_pass "Verify the property relatime=on passed."