windows-terminal/.github
James Holderness 33589cd8db
Add support for the DECSWT (Set Window Title) escape sequence (#16804)
This PR adds support for the `OSC 21` sequence used on DEC terminals to
set the window title. It's just an alias of the `OSC 2` title sequence
used by XTerm.

This PR also corrects the handling of blank title sequences, which are
supposed to reset the title to its default value, but were previously
ignored.

## Detailed Description of the Pull Request / Additional comments

To handle the blank title parsing correctly, I had to make some changes
to the state machine. Previously it would not have dispatched an `OSC`
sequence unless it received a semicolon following the `OSC` number, but
when there's a blank string, that semicolon should not be required.

I also took this opportunity to simplify the `OSC` parsing in the state
machine, and eliminate the `_GetOscTitle` method which no longer served
any purpose.

## Validation Steps Performed

I've manually confirmed that the title sequences are now working as
expected, and added some state machine unit tests covering the blank
value handling for these sequences.

I also had to update one of the existing state machine tests to account
for the changes I made to allow the semicolon to be omitted.

Closes #16783
Closes #16784
2024-03-04 14:03:14 -06:00
..
ISSUE_TEMPLATE Update bug template to help find the version number accurately (#14375) 2022-11-14 22:00:11 +00:00
actions/spelling Add support for the DECSWT (Set Window Title) escape sequence (#16804) 2024-03-04 14:03:14 -06:00
linters Add support for autodetecting URLs and making hyperlinks (#7691) 2020-10-28 20:24:43 +00:00
policies Onboard to GitOps.ResourceManagement (#15557) 2023-07-06 17:03:01 -05:00
workflows Fix similarIssues.yml to not fail when no similar issues found (#16542) 2024-01-08 14:30:41 -06:00
PULL_REQUEST_TEMPLATE.md Make the PR template less unfriendly (#14697) 2023-01-19 11:39:04 +00:00