remove feature flag

src/cascadia/TerminalSettingsEditor/Compatibility.cpp

@@ -18,11 +18,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
         INITIALIZE_BINDABLE_ENUM_SETTING(TextMeasurement, TextMeasurement, winrt::Microsoft::Terminal::Control::TextMeasurement, L"Globals_TextMeasurement_", L"Text");
     }
 
-    bool CompatibilityViewModel::AllowVtChecksumReportAvailable() const noexcept
-    {
-        return Feature_VtChecksumReport::IsEnabled();
-    }
-
     bool CompatibilityViewModel::AllowKeypadModeAvailable() const noexcept
     {
         return Feature_KeypadModeEnabled::IsEnabled();

src/cascadia/TerminalSettingsEditor/Compatibility.h

@@ -15,7 +15,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
     public:
         CompatibilityViewModel(Model::GlobalAppSettings globalSettings);
 
-        bool AllowVtChecksumReportAvailable() const noexcept;
         bool AllowKeypadModeAvailable() const noexcept;
 
         // DON'T YOU DARE ADD A `WINRT_CALLBACK(PropertyChanged` TO A CLASS DERIVED FROM ViewModelHelper. Do this instead:

src/cascadia/TerminalSettingsEditor/Compatibility.idl

@@ -11,7 +11,6 @@ namespace Microsoft.Terminal.Settings.Editor
     {
         CompatibilityViewModel(Microsoft.Terminal.Settings.Model.GlobalAppSettings globalSettings);
 
-        Boolean AllowVtChecksumReportAvailable { get; };
         Boolean AllowKeypadModeAvailable { get; };
 
         PERMANENT_OBSERVABLE_PROJECTED_SETTING(Boolean, ForceVTInput);

src/cascadia/TerminalSettingsEditor/Compatibility.xaml

@@ -41,8 +41,7 @@
         <!--  Allow VT Checksum Report  -->
         <local:SettingContainer x:Uid="Globals_AllowVtChecksumReport">
             <ToggleSwitch IsOn="{x:Bind ViewModel.AllowVtChecksumReport, Mode=TwoWay}"
-                          Style="{StaticResource ToggleSwitchInExpanderStyle}"
-                          Visibility="{x:Bind ViewModel.AllowVtChecksumReportAvailable}" />
+                          Style="{StaticResource ToggleSwitchInExpanderStyle}" />
         </local:SettingContainer>
 
         <!--  Allow Keypad Mode  -->

src/features.xml

@@ -124,16 +124,6 @@
         </alwaysEnabledBrandingTokens>
     </feature>
 
-    <feature>
-        <name>Feature_VtChecksumReport</name>
-        <description>Enables the DECRQCRA checksum report, which can be used to read the screen contents</description>
-        <id>14974</id>
-        <stage>AlwaysDisabled</stage>
-        <alwaysEnabledBrandingTokens>
-            <brandingToken>Dev</brandingToken>
-        </alwaysEnabledBrandingTokens>
-    </feature>
-
     <feature>
         <name>Feature_ScratchpadPane</name>
         <description>Allow the user to create scratchpad panes. Mostly just exists to validate non-terminal panes.</description>

src/terminal/adapter/adaptDispatch.cpp

@@ -1323,7 +1323,7 @@ void AdaptDispatch::RequestChecksumRectangularArea(const VTInt id, const VTInt p
 {
     uint16_t checksum = 0;
     // If this feature is not enabled, we'll just report a zero checksum.
-    if (Feature_VtChecksumReport::IsEnabled() && _vtChecksumReportEnabled)
+    if (_vtChecksumReportEnabled)
     {
         // If the page number is 0, then we're meant to return a checksum of all
         // of the pages, but we have no need for that, so we'll just return 0.