Go to file
Todd Zullinger f44dc3ebfd rpmdiff: adjust for rpm-4.19.0 API changes
The `fiFromHeader()` method has been removed from rpm-4.19.0, in rpm
commit 742be88cd (Drop the klunky and ugly rpm.fi python binding
finally, 2022-04-08)

It has (apparently) been deprecated since rpm commit f0c3985a7 (Make
fiFromHeader() static inside header-py, deprecate, 2009-09-23).

Use `rpm.files()` instead, which was added in rpm commit 3b086277b (New
rpmfile[s] python bindings, 2013-12-18).  This was released in
rpm-4.12.0.
2023-06-07 03:50:12 -04:00
.github/workflows openSUSE: Start using python-magic package in CI. 2023-03-29 12:50:29 +02:00
.packit Drop dependency on pytest-flake8 as it's unmaintained. 2023-04-19 16:37:07 +02:00
.vscode Remove unused VS code settings. 2021-10-20 08:43:51 +02:00
configs Add new check: patchable-function-entry-in-archive. 2023-03-23 17:35:44 +01:00
rpmlint rpmdiff: adjust for rpm-4.19.0 API changes 2023-06-07 03:50:12 -04:00
test Allow *args for get_tested_path. 2023-04-24 10:53:31 +02:00
tools Remove Python 2 support in generate-isocodes.py 2023-01-11 10:51:24 +01:00
.dockerignore Adjust the docker script to run the setuptools 2018-07-12 14:46:13 +02:00
.editorconfig Set indent size for yaml to 2 in .editorconfig 2021-08-19 14:59:40 +02:00
.gitignore Introduce Packit CI to enable easy local testing of PRs 2021-05-15 15:42:48 -04:00
.packit.yaml Revert "Disable Mageia CI builds due to system problem" 2023-02-17 19:52:59 +01:00
COPYING Update GPL-2.0 with the current text from GNU, whitespace fixes. 2018-08-21 16:11:55 +02:00
MANIFEST.in Add conftest.py in order to fix pytest loading issues. 2021-08-15 18:36:03 +02:00
Makefile Add back Makefile generating the isocodes 2018-07-12 14:46:13 +02:00
README.md Add logo to README.md. 2023-04-24 11:04:38 +02:00
diff.py Add diff.py wrapper script. 2021-11-26 11:36:03 +01:00
lint.py Move the rpmlint CLI logic into its own module file 2020-02-17 10:00:00 -05:00
pyproject.toml No need of using wheel: PEP 517 2023-03-11 04:54:13 +05:30
pytest.ini Remove trailing whitespace. 2023-04-24 10:34:08 +02:00
rpmlint.svg Add rpmlint.svg with the new rpmlint logo 2023-04-20 13:35:46 +02:00
setup.cfg Introducing new file 'pytest.ini' a conf file for pytest (#1047) 2023-04-24 09:51:58 +02:00
setup.py Drop dependency on pytest-flake8 as it's unmaintained. 2023-04-19 16:37:07 +02:00

README.md

rpmlint

Build and Test Build and Test 2 build result repology

rpmlint is a tool for checking common errors in RPM packages. rpmlint can be used to test individual packages before uploading or to check an entire distribution.

rpmlint can check binary RPMs, source RPMs, and plain specfiles, but all checks do not apply to all argument types. For best check coverage, run rpmlint on source RPMs instead of plain specfiles.

The idea for rpmlint is from the lintian tool of the Debian project. All the checks reside in rpmlint/checks folder. Feel free to provide new checks and suggestions at:

https://github.com/rpm-software-management/rpmlint

Install

For installation on your machine you will need the following packages:

Mandatory:

  • Python 3.8 or newer
  • python3-setuptools, python3-tomli (for python3 < 3.11), python3-tomli-w, python3-pyxdg, python3-pybeam
  • rpm and its python bindings
  • binutils, cpio, gzip, bzip, xz and zstd

Optional, for running the test suite:

  • devscripts
  • dash
  • a 32-bit glibc if on a 64-bit architecture
  • desktop-file-utils
  • libmagic and its python bindings
  • enchant and its python bindings, along with en_US and cs_CZ dictionaries
  • appstream-util, part of appstream-glib

rpmlint is part of most distributions and as an user you can simply

dnf install rpmlint

Testing

You will need to have all the required modules as listed on the Install section above. You will also need pytest,pytest-cov and pytest-xdist.

If all the dependencies are present you can just execute tests using:

python3 -m pytest

Or even pick one of the tests using pytest:

python3 -m pytest test/test_config.py

Bugfixing and contributing

Any help is, of course, welcome but honestly most probable cause for your visit here is that rpmlint is marking something as invalid while it shouldn't or it is marking something as correct while it should not either :)

Now there is an easy way how to fix that. Our testsuite simply needs an extension to take the above problem into the account.

Primarily we just need the offending rpm file (best the smallest you can find or we would soon take few GB to take a checkout) and some basic expectation of what should happen.

Example workflow

  1. I have rpmfile that should report unreadable zip file
  2. I store this file in git under test/binary/texlive-codepage-doc-2018.151.svn21126-38.1.noarch.rpm
  3. Now I need to figure out what check should test this, in this case test_zip.py
  4. For the testing I will have to devise a small function that validates my expectations:
@pytest.mark.parametrize('package', ['binary/texlive-codepage-doc'])
def test_zip2(tmpdir, package, zipcheck):
    output, test = zipcheck
    test.check(get_tested_package(package, tmpdir))
    out = output.print_results(output.results)
    assert 'W: unable-to-read-zip' in out

As you can see it is not so hard and with each added test we get better coverage on what is really expected from rpmlint and avoid naughty regressions in the long run.

Preferable approach for binary packages is to create artificial testcase (to keep binaries small and trivial). We are currently using OBS to produce binaries: https://build.opensuse.org/project/show/devel:openSUSE:Factory:rpmlint:tests

For a sample package see: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint:tests/non-position-independent-exec

Configuration

If you want to change configuration options or the list of checks you can use the following locations:

/etc/xdg/rpmlint/*toml

$XDG_CONFIG_HOME/rpmlint/*toml

The configuration itself is a toml file where for some basic inspiration you can check up rpmlint/configdefaults.toml which specifies format/defaults.

One can also include additional configuration files (or directories) by using the --config option. Note that all TOML configuration values are merged and not overridden. So e.g. values in a list are concatenated. If you need an override, use *.override.*toml configuration file, where all defined values are selected as default.

Additional option to control rpmlint behaviour is the addition of rpmlintrc file which uses old syntax for compatibility with old rpmlint releases, yet it can be normal toml file if you wish:

setBadness('check', 0)
addFilter('test-i-ignore')

The location of rpmlintrc can be set using --rpmlintrc option. Or it can load any *.rpmlintrc or *-rpmlintrc that are located in the same folder as check RPM file (or a specfile). Note the auto-loading happens only when one RPM file (or a specfile) is used. The best practice is to store the name in $PACKAGE_NAME.rpmlintrc.

setBadness overrides a default badness for a given check and addFilter ignores all errors that match the given regular expression (one cannot filter out errors that are listed in BlockedFilters in a configuration file).