84 lines
2.6 KiB
Python
84 lines
2.6 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
#
|
|
# check xdg file format violation
|
|
#
|
|
# http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
|
|
#
|
|
|
|
from Filter import addDetails, printError, printWarning
|
|
from Pkg import getstatusoutput, is_utf8
|
|
import AbstractCheck
|
|
try:
|
|
from ConfigParser import RawConfigParser
|
|
except:
|
|
from configparser import RawConfigParser
|
|
import os
|
|
|
|
STANDARD_BIN_DIRS = ['/bin/', '/sbin/', '/usr/bin/', '/usr/sbin/']
|
|
|
|
|
|
class MenuXDGCheck(AbstractCheck.AbstractFilesCheck):
|
|
def __init__(self):
|
|
# desktop file need to be in $XDG_DATA_DIRS
|
|
# $ echo $XDG_DATA_DIRS/applications
|
|
# /var/lib/menu-xdg:/usr/share
|
|
AbstractCheck.AbstractFilesCheck.__init__(
|
|
self, "MenuXDGCheck", "/usr/share/applications/.*\.desktop$")
|
|
|
|
def check_file(self, pkg, filename):
|
|
root = pkg.dirName()
|
|
f = root + filename
|
|
st = getstatusoutput(('desktop-file-validate', f), True)
|
|
if st[0]:
|
|
error_printed = False
|
|
for line in st[1].splitlines():
|
|
if 'error: ' in line:
|
|
printError(pkg, 'invalid-desktopfile', filename,
|
|
line.split('error: ')[1])
|
|
error_printed = True
|
|
if not error_printed:
|
|
printError(pkg, 'invalid-desktopfile', filename)
|
|
if not is_utf8(f):
|
|
printError(pkg, 'non-utf8-desktopfile', filename)
|
|
|
|
cfp = RawConfigParser()
|
|
cfp.read(f)
|
|
binary = None
|
|
if cfp.has_option('Desktop Entry', 'Exec'):
|
|
binary = cfp.get('Desktop Entry', 'Exec').split(' ', 1)[0]
|
|
if binary:
|
|
found = False
|
|
if binary.startswith('/'):
|
|
found = os.path.exists(root + binary)
|
|
else:
|
|
for i in STANDARD_BIN_DIRS:
|
|
if os.path.exists(root + i + binary):
|
|
# no need to check if the binary is +x, rpmlint does it
|
|
# in another place
|
|
found = True
|
|
break
|
|
if not found:
|
|
printWarning(pkg, 'desktopfile-without-binary', filename,
|
|
binary)
|
|
|
|
check = MenuXDGCheck()
|
|
|
|
addDetails(
|
|
'invalid-desktopfile',
|
|
'''.desktop file is not valid, check with desktop-file-validate''',
|
|
|
|
'non-utf8-desktopfile',
|
|
'''.desktop file is not encoded in UTF-8''',
|
|
|
|
'desktopfile-without-binary',
|
|
'''the .desktop file is for a file not present in the package. You
|
|
should check the requires or see if this is not a error''',
|
|
)
|
|
|
|
# Local variables:
|
|
# indent-tabs-mode: nil
|
|
# py-indent-offset: 4
|
|
# End:
|
|
# ex: ts=4 sw=4 et
|