Commit Graph

1864 Commits

Author SHA1 Message Date
Ville Skyttä d5835d4300 Further Python 3 porting
Thanks to Alberto Planas Dominguez <aplanas@suse.com> for sanity
checks and suggestions.
2015-07-09 16:43:43 +03:00
Ville Skyttä 34ca3ba54f s/invalid-appdate/invalid-appdata/ 2015-07-09 16:43:43 +03:00
Ville Skyttä 4d3186c6e2 Remove dead code 2015-07-09 16:43:43 +03:00
Ville Skyttä b2f46b1182 Some Python 3 tweaks 2015-07-09 16:43:43 +03:00
Ville Skyttä 28ca788345 Python 3 compatibility tweaks 2015-07-09 16:43:43 +03:00
Ville Skyttä 7e3861ddec rpmdiff: Make work with Python 3 2015-07-09 16:43:43 +03:00
Ville Skyttä a150f13419 rpmdiff.1: Update list of valid --ignore values 2015-07-09 16:43:43 +03:00
Arturo Borrero González dde8ed0617 Add rpmdiff man page (#29) 2015-07-09 16:43:43 +03:00
Ville Skyttä e938d70a85 rpmdiff: Fix display of multiple dependency qualifiers 2015-07-09 16:43:43 +03:00
Ville Skyttä b06561a4ee Grammar fix. 2015-07-09 16:43:43 +03:00
Ville Skyttä 8dbd2762f3 Handle %autosetup and %autopatch. 2015-07-09 16:43:43 +03:00
Ville Skyttä 95036962fa Test for setup-not-quiet. 2015-07-09 16:43:43 +03:00
Ville Skyttä dfc6518867 Variable naming tweaks. 2015-07-09 16:43:43 +03:00
Michael Scherer ee0cd7badb fix detection of function on 32 bits system (callq being 64 bits ),
found by nirik, https://bugzilla.redhat.com/show_bug.cgi?id=1021719#c13
2015-07-09 16:43:43 +03:00
Ville Skyttä f33bf54ec0 Fix unicode decode error with non-ASCII package name.
https://bugzilla.redhat.com/show_bug.cgi?id=1036310
2015-07-09 16:43:43 +03:00
Ville Skyttä 8f0bd3523d Fix inclusion of AppDataCheck in default checks. 2015-07-09 16:43:43 +03:00
Ville Skyttä a4d3a64e29 Update Python 3.4 bytecode magic value. 2015-07-09 16:43:43 +03:00
Ville Skyttä eddbd337ad Don't modify sys.argv[0].
https://bugzilla.redhat.com/1026333
2015-07-09 16:43:43 +03:00
Michael Scherer 523195716d also document we need appdata-validate as a optional comp 2015-07-09 16:43:43 +03:00
Michael Scherer e94875183b make appdata-validate optional 2015-07-09 16:43:43 +03:00
Michael Scherer 3ad6f68edd Add a check that validate appdata file 2015-07-09 16:43:43 +03:00
Ville Skyttä 717ff0fcf6 Python 3 compatibility tweaks. 2015-07-09 16:43:43 +03:00
Michael Scherer b69b57ee67 fix traceback found by running rpmlint on all package of Fedora
File "./rpmlint", line 168, in main
    runChecks(pkg)
  File "./rpmlint", line 228, in runChecks
    check.check(pkg)
  File "/root/rpmlint-code/AbstractCheck.py", line 83, in check
    self.check_file(pkg, filename)
  File "/root/rpmlint-code/MenuXDGCheck.py", line 57, in check_file
    if not found:
UnboundLocalError: local variable 'found' referenced before assignment
2015-07-09 16:43:43 +03:00
Ville Skyttä c18934f708 Fix data leak from .desktop file to another -- don't reuse configparsers. 2015-07-09 16:43:43 +03:00
Dirk Mueller b91ffe67e3 Fix small Pep8 Whitespace issue 2015-07-09 16:43:43 +03:00
Dirk Mueller 5ac87ee503 Fix handling of desktop files without Exec key
Avoids an "No such option" exception from ConfigParser.
2015-07-09 16:43:43 +03:00
Ville Skyttä c6a129070e Fix handling of Exec= with an absolute path.
https://bugzilla.redhat.com/991278
2015-07-09 16:43:43 +03:00
Ville Skyttä 5b26a3a04b Regenerate ISO codes list with iso-codes 3.44. 2015-07-09 16:43:43 +03:00
Orion Poplawski 74acf18635 Fix setgroups error name 2015-07-09 16:43:43 +03:00
Ville Skyttä e748a9e667 Release 1.5. 2015-07-09 16:43:43 +03:00
Ville Skyttä 778c7f40ff Spelling fixes, wrap long lines. 2015-07-09 16:43:42 +03:00
Ville Skyttä f14706d245 Cleanups. 2015-07-09 16:43:42 +03:00
Ville Skyttä ad6e4b0061 Add Python 3.4 magic number. 2015-07-09 16:43:42 +03:00
Ville Skyttä 4dab1d395f Regenerate ISO codes list with iso-codes 3.41. 2015-07-09 16:43:42 +03:00
Ville Skyttä febaadc9bc Treat Lua bytecode files as binary.
https://bugzilla.redhat.com/919869
2015-07-09 16:43:42 +03:00
Ville Skyttä b12081ac9c Cleanups. 2015-07-09 16:43:42 +03:00
Ville Skyttä 494ae03db0 Revert "small refactoring"
This reverts commit eb981e7f95.

The global config file does imports, sets up stuff etc for user config
files and /etc/rpmlint/*config snippets to use, and execfile()ing the
global one in a code block like this doesn't do that properly,
resulting in for example addFilter() not being available for these
additional configs.
2015-07-09 16:43:42 +03:00
Michael Scherer c0f7a19453 add a help text, as suggested by Dan Horák on freenode 2015-07-09 16:43:42 +03:00
Michael Scherer 993538854d Private keys should also not be shipped in rpm, for the reason
explained in the commit.
2015-07-09 16:43:42 +03:00
Michael Scherer a600f52345 warn when a pem certificate is found in a package.
after the compromise of various CA in the last years, it would
be better to not have X copy of the CA certificate in each package.

Not to mention the issue of having some packages shipping a default
private key with the certificate for a perfect out of box experience, that
could lead to security issue. So the check look for certificate, but
verify that the file is not not marked as %ghost ).

idea from kiilerix on irc
2015-07-09 16:43:42 +03:00
Michael Scherer c489f083c1 small refactoring 2015-07-09 16:43:42 +03:00
Michael Scherer 3ac1e0c10f use a more specific exception ( as this could mask others issues ) 2015-07-09 16:43:42 +03:00
Michael Scherer 7e3fdb127b add desktopfile-without-binary warning, to check if the file
point to a existing binary ( idea originally from Ed Santiago )
2015-07-09 16:43:42 +03:00
Michael Scherer f6a41c1cfb refactor a serie of if/elif into a single loop 2015-07-09 16:43:42 +03:00
Michael Scherer 1c41e77c52 shorten the regexp for /tmp directory 2015-07-09 16:43:42 +03:00
Michael Scherer 394307285e check that the packager didn't get sloppy by using _default_patch_fuzz,
idea originally from Ed Santiago
2015-07-09 16:43:42 +03:00
Michael Scherer 348099d893 refactor the regexp code for define and global ( easier to read, less risk of errrors ) 2015-07-09 16:43:42 +03:00
Michael Scherer 98af0c27b7 start to refactor various copy of tag ( since %verifyscript
was missing in SpecCheck.py )
2015-07-09 16:43:42 +03:00
Michael Scherer 1edb71fb75 refactor regexp used for the tag matching 2015-07-09 16:43:42 +03:00
Michael Scherer 7c97c40b22 removed /usr/spool and /usr/X386, reorder /var subdir, removed
/var/state, added /var/mail, to sync with latest FHS
2015-07-09 16:43:42 +03:00