Ville Skyttä
9abc4d1d6b
Prepare for rpm-python possibly returning script progs as arrays.
...
http://rpm.org/ticket/847#comment:2
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1885 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:41 +03:00
Ville Skyttä
8bc0531727
Code cleanups.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1884 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:41 +03:00
Ville Skyttä
802e97569f
Warn about one line scriptlet commands only if the interpreter is a shell.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1880 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:41 +03:00
Ville Skyttä
4054c21114
Don't emit use-tmp-in-* for commented out /tmp in scriptlets.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1879 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:41 +03:00
Ville Skyttä
bf4db12b26
Add info message for non-empty-*.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1866 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:40 +03:00
Ville Skyttä
f3410598ad
Code cleanups, avoid deeply nested blocks etc.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1754 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:38 +03:00
Ville Skyttä
8a514dd9aa
Wrap bunch of long lines, tune comments and info messages.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1732 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:37 +03:00
Ville Skyttä
c8b21eda64
Replace bunch of trivial regexps with simple string searches.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1675 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:36 +03:00
Ville Skyttä
39840c4adf
Code cleanups.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1645 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:35 +03:00
Ville Skyttä
43ce3c7515
Code cleanups.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1593 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:34 +03:00
Ville Skyttä
7bbfd9bff6
Code cleanups.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1578 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:33 +03:00
Ville Skyttä
b29ba4a9e6
Add %verifyscript support.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1565 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:33 +03:00
Ville Skyttä
aa46ff70f1
Drop support for rpm < 4.4.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1548 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:33 +03:00
Ville Skyttä
efc29193bd
Make sure details are available for -i also for early loaded check modules.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1532 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:32 +03:00
Ville Skyttä
1dfc629db7
Import fixes.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1522 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:32 +03:00
Ville Skyttä
6387cde4a8
Dict access cleanups.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1520 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:32 +03:00
Ville Skyttä
d55c8ebb84
PEP 8, pylint, pychecker cleanups.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1517 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:32 +03:00
Ville Skyttä
5adbaf8465
Import cleanup (PEP 8).
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1516 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:32 +03:00
Ville Skyttä
c7843fa5c4
pychecker fixes.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1507 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:31 +03:00
Ville Skyttä
627f8d9c31
Add utf-8 magic comments.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1506 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:31 +03:00
Ville Skyttä
b0b07a56f9
pylint whitespace cleanups.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1475 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:31 +03:00
Ville Skyttä
e1569d9f2b
Use tempfile.gettempdir() instead of hardcoding /tmp, Python >= 2.3 is now required.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1468 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:30 +03:00
Ville Skyttä
0e04c8a8be
Avoid percent-in-%foo warnings for commented out lines ( #149 ).
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1419 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:29 +03:00
Ville Skyttä
bcc3cb1262
Avoid false positives for percent-in-* checks, macro names are at least 3 chars long ( #132 , anonymous)
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1386 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:28 +03:00
Ville Skyttä
9b4f0b6721
Do not warn about ghost file non-creation for missingok files ( #79 , dmueller at suse.de)
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1366 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:28 +03:00
Michael Scherer
10f5d21813
- lua is a valid shell, fix #74 , patch from dmueller
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1359 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:28 +03:00
Ville Skyttä
522e85ebda
Better I/O error and temporary file handling.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1344 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:27 +03:00
Ville Skyttä
938003a3a8
Check %pretrans and %posttrans if supported by installed rpm.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1339 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:27 +03:00
Ville Skyttä
249cbdefce
Improve percent-in-* check, https://bugzilla.redhat.com/239611
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1338 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:27 +03:00
Ville Skyttä
d5fc57750b
Fine tune forbidden-selinux-command info message.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1294 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä
a6e4adb3cd
Check for forbidden SELinux related commands (Steve Grubb, https://bugzilla.redhat.com/214605 )
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1293 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä
ed5754d463
Drop some duplicate code.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1292 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä
4af39f65b4
Use sequence based command invocation more; avoids shell escaping/whitespace issues eg. like https://bugzilla.redhat.com/206383
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1275 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä
e6d0ac91be
Add some TODO comments.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1253 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Michael Scherer
7aaea86c5f
- add Xdg menu directory to %updates-menus detection
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1252 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä
3246e8e236
Improve home regex.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1223 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä
b628989638
Improve dangerous command regexp.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1222 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Michael Scherer
57744bcce1
- pychecker fix
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1213 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:24 +03:00
Michael Scherer
e3fd820a6f
- remove pychecker errors:
...
- unused variable
- variable that shadow builtins
- unused expression ( usually used to trigger a exception )
- do not raise string as exception
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1204 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:24 +03:00
Ville Skyttä
da11a89ab4
Fix fallout from [1183].
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1193 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:24 +03:00
Ville Skyttä
0c053a5522
Make sure that the correct interpreter is used for scriptlet syntax checks.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1183 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:24 +03:00
Ville Skyttä
c79d60297b
Add indentation settings for vi* and *Emacs, use -tt, untabify.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1110 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:22 +03:00
Ville Skyttä
b17ba933d4
Fix indentation, untabify, trim trailing whitespace.
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1049 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:42:46 +03:00
Frédéric Lepied
a584e88147
adds userdel and groupdel to the list of "dangerous" commands. (Ville Skyttä)
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1005 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:42:30 +03:00
Frédéric Lepied
0cc5c052cd
Mandriva
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@994 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:42:29 +03:00
Frédéric Lepied
93efe21460
add non-empty shell check (Ville Skyttä)
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@991 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:42:29 +03:00
Frédéric Lepied
cc0e96cc86
doc for postin-without-ghost-file-creation (Pascal Terjan)
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@903 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:39:10 +03:00
Frédéric Lepied
7363b8bc6d
Mandrakelinux (Robert Vojta)
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@867 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:39:09 +03:00
Frédéric Lepied
2947b430c7
removed buggy trigger code
...
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@851 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:39:09 +03:00
Frédéric Lepied
ae28c6ce5a
makes postcheck not to whine about ghost files that are created by
...
%triggerin scripts in addition to %pre and %post. (Ville Skyttä)
Additionally, somewhat improved documentation on one-line-commands,
using "should" instead of "must" since AFAICS %post -p <command> cannot
be used if <command> needs parameters. (Ville Skyttä)
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@843 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:39:09 +03:00