Commit Graph

57 Commits

Author SHA1 Message Date
Ville Skyttä 0e04c8a8be Avoid percent-in-%foo warnings for commented out lines (#149).
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1419 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:29 +03:00
Ville Skyttä bcc3cb1262 Avoid false positives for percent-in-* checks, macro names are at least 3 chars long (#132, anonymous)
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1386 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:28 +03:00
Ville Skyttä 9b4f0b6721 Do not warn about ghost file non-creation for missingok files (#79, dmueller at suse.de)
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1366 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:28 +03:00
Michael Scherer 10f5d21813 - lua is a valid shell, fix #74, patch from dmueller
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1359 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:28 +03:00
Ville Skyttä 522e85ebda Better I/O error and temporary file handling.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1344 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:27 +03:00
Ville Skyttä 938003a3a8 Check %pretrans and %posttrans if supported by installed rpm.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1339 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:27 +03:00
Ville Skyttä 249cbdefce Improve percent-in-* check, https://bugzilla.redhat.com/239611
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1338 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:27 +03:00
Ville Skyttä d5fc57750b Fine tune forbidden-selinux-command info message.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1294 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä a6e4adb3cd Check for forbidden SELinux related commands (Steve Grubb, https://bugzilla.redhat.com/214605)
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1293 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä ed5754d463 Drop some duplicate code.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1292 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 4af39f65b4 Use sequence based command invocation more; avoids shell escaping/whitespace issues eg. like https://bugzilla.redhat.com/206383
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1275 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä e6d0ac91be Add some TODO comments.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1253 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Michael Scherer 7aaea86c5f - add Xdg menu directory to %updates-menus detection
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1252 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä 3246e8e236 Improve home regex.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1223 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä b628989638 Improve dangerous command regexp.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1222 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Michael Scherer 57744bcce1 - pychecker fix
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1213 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:24 +03:00
Michael Scherer e3fd820a6f - remove pychecker errors:
- unused variable
  - variable that shadow builtins
  - unused expression ( usually used to trigger a exception )
  - do not raise string as exception 


git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1204 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:24 +03:00
Ville Skyttä da11a89ab4 Fix fallout from [1183].
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1193 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:24 +03:00
Ville Skyttä 0c053a5522 Make sure that the correct interpreter is used for scriptlet syntax checks.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1183 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:24 +03:00
Ville Skyttä c79d60297b Add indentation settings for vi* and *Emacs, use -tt, untabify.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1110 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:22 +03:00
Ville Skyttä b17ba933d4 Fix indentation, untabify, trim trailing whitespace.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1049 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:42:46 +03:00
Frédéric Lepied a584e88147 adds userdel and groupdel to the list of "dangerous" commands. (Ville Skyttä)
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1005 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:42:30 +03:00
Frédéric Lepied 0cc5c052cd Mandriva
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@994 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:42:29 +03:00
Frédéric Lepied 93efe21460 add non-empty shell check (Ville Skyttä)
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@991 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:42:29 +03:00
Frédéric Lepied cc0e96cc86 doc for postin-without-ghost-file-creation (Pascal Terjan)
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@903 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:39:10 +03:00
Frédéric Lepied 7363b8bc6d Mandrakelinux (Robert Vojta)
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@867 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:39:09 +03:00
Frédéric Lepied 2947b430c7 removed buggy trigger code
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@851 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:39:09 +03:00
Frédéric Lepied ae28c6ce5a makes postcheck not to whine about ghost files that are created by
%triggerin scripts in addition to %pre and %post. (Ville Skyttä)

Additionally, somewhat improved documentation on one-line-commands,
using "should" instead of "must" since AFAICS %post -p <command> cannot
be used if <command> needs parameters. (Ville Skyttä)

git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@843 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:39:09 +03:00
Frédéric Lepied cfc3eee317 allow the [[:space:]] construction (bug #6466) (Luca Berra)
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@816 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:39:08 +03:00
Frédéric Lepied dc5e592cef check rpm-helper prereq.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@700 9bc8b190-ac0f-0410-8968-dc7d1f502856
2002-08-08 07:35:54 +00:00
Frédéric Lepied 2480001eaf added perl to dangerous command
check trigger scripts too


git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@691 9bc8b190-ac0f-0410-8968-dc7d1f502856
2002-07-11 06:19:13 +00:00
Frédéric Lepied 010c5456a8 corrected prereq test
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@688 9bc8b190-ac0f-0410-8968-dc7d1f502856
2002-06-14 21:16:23 +00:00
Frédéric Lepied a0ed38b8d1 added no-prereq-on
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@649 9bc8b190-ac0f-0410-8968-dc7d1f502856
2002-05-01 20:04:09 +00:00
Frédéric Lepied 05415d3a51 add descriptions for spurious-bracket-in-.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@626 9bc8b190-ac0f-0410-8968-dc7d1f502856
2002-02-13 19:59:56 +00:00
Frédéric Lepied a73e45d999 Linux-Mandrake => Mandrake Linux
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@580 9bc8b190-ac0f-0410-8968-dc7d1f502856
2001-11-25 21:41:09 +00:00
Chmouel Boudjnah f825b79ae3 Don't print error about percent if post-script has a %%.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@571 9bc8b190-ac0f-0410-8968-dc7d1f502856
2001-11-21 16:03:35 +00:00
Frédéric Lepied a14cd35b5a corrected warnings reported by pychecker
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@568 9bc8b190-ac0f-0410-8968-dc7d1f502856
2001-11-14 16:34:02 +00:00
Frédéric Lepied d5d8cae445 check that RPM_BUILD_ROOT or RPM_BUILD_DIR isn't used
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@561 9bc8b190-ac0f-0410-8968-dc7d1f502856
2001-11-09 23:36:46 +00:00
Frédéric Lepied 6feff953c2 track command with full path too.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@527 9bc8b190-ac0f-0410-8968-dc7d1f502856
2001-10-10 11:43:42 +00:00
Frédéric Lepied 99b95e2ad4 check if /tmp or /var/tmp is used.
check if update-menus is called without a menu file.


git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@515 9bc8b190-ac0f-0410-8968-dc7d1f502856
2001-09-28 18:51:58 +00:00
Frédéric Lepied 47057e35d3 ghost-files-without-postun => ghost-files-without-postin
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@507 9bc8b190-ac0f-0410-8968-dc7d1f502856
2001-09-14 16:01:20 +00:00
Frédéric Lepied a7d67c76ef check ~/ instead of ~ to allow awk scripts not to give false reports.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@493 9bc8b190-ac0f-0410-8968-dc7d1f502856
2001-08-20 13:49:23 +00:00
Frédéric Lepied 248e3e314d described one-line-command-in warnings.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@445 9bc8b190-ac0f-0410-8968-dc7d1f502856
2001-06-20 11:32:12 +00:00
Frédéric Lepied d74f450db5 check that a script isn't a oneliner.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@405 9bc8b190-ac0f-0410-8968-dc7d1f502856
2001-05-18 12:39:40 +00:00
Frédéric Lepied ec211343ca check postin and prein instead of postun and preun for ghost files creation.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@404 9bc8b190-ac0f-0410-8968-dc7d1f502856
2001-05-18 09:21:06 +00:00
Frédéric Lepied b421f3137c check that the postun creates the ghost files
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@383 9bc8b190-ac0f-0410-8968-dc7d1f502856
2001-02-02 06:51:57 +00:00
Frédéric Lepied 2a1a96cd39 added install to dangerous commands
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@382 9bc8b190-ac0f-0410-8968-dc7d1f502856
2001-02-02 06:44:56 +00:00
Chmouel Boudjnah d3d451629c Add /sbin/sash as VALID_SHELLS.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@373 9bc8b190-ac0f-0410-8968-dc7d1f502856
2000-12-07 15:21:20 +00:00
Frédéric Lepied 3f3c3f6df7 force a separator before dangerous command.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@351 9bc8b190-ac0f-0410-8968-dc7d1f502856
2000-11-23 15:29:15 +00:00
Frédéric Lepied 7ed543dc84 check dangerous commands.
check reference to ~ or $HOME.


git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@322 9bc8b190-ac0f-0410-8968-dc7d1f502856
2000-10-12 05:09:02 +00:00