folkslinux
/
rpmlint
mirror of https://github.com/rpm-software-management/rpmlint.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Wrap open in context manager to correct close of file

This commit is contained in:
Ondřej Súkup 2020-02-12 12:36:34 +01:00 committed by Tomáš Chvátal
parent 4754410540
commit 515e1bb20d
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
rpmlint/checks/PkgConfigCheck.py
View File

@ -27,11 +27,11 @@ class PkgConfigCheck(AbstractFilesCheck):
return return
try: try:
pc_file = open(pkg.dirName() + '/' + filename, 'r', encoding='utf-8') with open(pkg.dirName() + '/' + filename, 'r', encoding='utf-8') as pc_file:
for line in pc_file: for line in pc_file:
self._check_invalid_pkgconfig_file(pkg, filename, line) self._check_invalid_pkgconfig_file(pkg, filename, line)
self._check_invalid_libs_dir(pkg, filename, line) self._check_invalid_libs_dir(pkg, filename, line)
self._check_double_slash(pkg, filename, line) self._check_double_slash(pkg, filename, line)
except Exception as e: except Exception as e:
self.output.add_info('E', pkg, 'pkgconfig-exception', filename, str(e)) self.output.add_info('E', pkg, 'pkgconfig-exception', filename, str(e))