Add xpmcore target

Package.swift

@@ -17,12 +17,21 @@ let package = Package(
         .package(url: "https://github.com/apple/swift-package-manager", from: "0.2.0"),
     ],
     targets: [
+        .target(
+            name: "xpmcore",
+            dependencies: ["Utility"]),
+        .target(
+            name: "xpmcoreTesting",
+            dependencies: ["xpmcore"]),
+        .testTarget(
+            name: "xpmcoreTests",
+            dependencies: ["xpmcore"]),
         .target(
             name: "xpmkit",
-            dependencies: ["xcodeproj", "Utility"]),
+            dependencies: ["xcodeproj", "Utility", "xpmcore"]),
         .testTarget(
             name: "xpmkitTests",
-            dependencies: ["xpmkit"]),
+            dependencies: ["xpmkit", "xpmcoreTesting"]),
         .target(
             name: "xpm",
             dependencies: ["xpmkit"]),
@@ -31,10 +40,10 @@ let package = Package(
             dependencies: ["xpmkit"]),
         .target(
             name: "xpmenvkit",
-            dependencies: ["Utility"]),
+            dependencies: ["Utility", "xpmcore"]),
         .testTarget(
             name: "xpmenvkitTests",
-            dependencies: ["xpm"]),
+            dependencies: ["xpm", "xpmcoreTesting"]),
         .target(
             name: "xpmenv",
             dependencies: ["xpmenvkit"]),

Sources/xpmcore/Utils/Printer.swift

@@ -2,7 +2,7 @@ import Basic
 import Foundation
 
 /// Protocol that represents an object that can print messages.
-protocol Printing: AnyObject {
+public protocol Printing: AnyObject {
     /// Prints a message on the console.
     ///
     /// - Parameter text: message to be printed.
@@ -25,15 +25,17 @@ protocol Printing: AnyObject {
 }
 
 /// Default printer that conforms the printing protocol.
-class Printer: Printing {
+public class Printer: Printing {
     // swiftlint:disable force_cast
     let terminalController: TerminalController = TerminalController(stream: stdoutStream as! LocalFileOutputByteStream)!
     // swiftlint:enable force_cast
 
+    public init() {}
+
     /// Prints a message on the console.
     ///
     /// - Parameter text: message to be printed.
-    func print(_ text: String) {
+    public func print(_ text: String) {
         let writer = InteractiveWriter.stdout
         writer.write(text)
         writer.write("\n")
@@ -42,7 +44,7 @@ class Printer: Printing {
     /// Prints an error.
     ///
     /// - Parameter error: error to be printed.
-    func print(error: Error) {
+    public func print(error: Error) {
         let writer = InteractiveWriter.stderr
         writer.write("Error: ", inColor: .red, bold: true)
         writer.write(error.localizedDescription)
@@ -52,7 +54,7 @@ class Printer: Printing {
     /// Prints an error message.
     ///
     /// - Parameter errorMessage: error message.
-    func print(errorMessage: String) {
+    public func print(errorMessage: String) {
         let writer = InteractiveWriter.stderr
         writer.write("Error: ", inColor: .red, bold: true)
         writer.write(errorMessage)
@@ -62,7 +64,7 @@ class Printer: Printing {
     /// Prints an error.
     ///
     /// - Parameter error: error to be printed.
-    func print(section: String) {
+    public func print(section: String) {
         let writer = InteractiveWriter.stdout
         writer.write("\(section)", inColor: .green, bold: true)
         writer.write("\n")

Sources/xpmcoreTesting/Utils/MockPrinter.swift

@@ -0,0 +1,25 @@
+import Foundation
+@testable import xpmcore
+
+public final class MockPrinter: Printing {
+    public var printArgs: [String] = []
+    public var printErrorArgs: [Error] = []
+    public var printSectionArgs: [String] = []
+    public var printErrorMessageArgs: [String] = []
+
+    public func print(_ text: String) {
+        printArgs.append(text)
+    }
+
+    public func print(section: String) {
+        printSectionArgs.append(section)
+    }
+
+    public func print(errorMessage: String) {
+        printErrorMessageArgs.append(errorMessage)
+    }
+
+    public func print(error: Error) {
+        printErrorArgs.append(error)
+    }
+}

Sources/xpmenv/main.swift

@@ -1,4 +1,5 @@
 import Foundation
 import xpmenvkit
 
-XPMEnvCommand().execute()
+var registry = CommandRegistry()
+try registry.run()

Sources/xpmenvkit/Commands/Command.swift

@@ -0,0 +1,9 @@
+import Foundation
+import Utility
+
+protocol Command {
+    static var command: String { get }
+    static var overview: String { get }
+    init(parser: ArgumentParser)
+    func run(with arguments: ArgumentParser.Result) throws
+}

Sources/xpmenvkit/Commands/CommandRegistry.swift

@@ -0,0 +1,13 @@
+import Basic
+import Foundation
+import Utility
+
+public final class CommandRegistry {
+    public init() {
+    }
+
+    public func run() throws {
+//        let parsedArguments = try parse()
+//        try process(arguments: parsedArguments)
+    }
+}

Sources/xpmenvkit/Commands/GlobalCommand.swift

@@ -0,0 +1,8 @@
+//
+//  GlobalCommand.swift
+//  xpmenvkit
+//
+//  Created by Pedro Piñera Buendía on 14.07.18.
+//
+
+import Foundation

Sources/xpmenvkit/Commands/ToolCommand.swift

@@ -58,9 +58,17 @@ public class XPMEnvCommand {
 
             let cliPath = path.appending(component: "xpm")
 
+            var arguments: [String] = [cliPath.asString]
             /// We drop the first element, which is the path to this executable.
-            let exitStatus = Process.run(path: cliPath.asString, arguments: Array(CommandLine.arguments.dropFirst()))
+            arguments.append(contentsOf: Array(CommandLine.arguments.dropFirst()))
-            exit(exitStatus)
+            let status: ProcessResult.ExitStatus = try Process.popen(arguments: arguments).exitStatus
+            if case let ProcessResult.ExitStatus.signalled(code) = status {
+                exit(code)
+            } else if case let ProcessResult.ExitStatus.terminated(code) = status {
+                exit(code)
+            } else {
+                exit(0)
+            }
         } catch let error as FatalError {
             let message = """
             \("Error:".bold().red()) \(error.errorDescription)

Sources/xpmenvkit/Commands/UpdateCommand.swift

@@ -0,0 +1 @@
+import Foundation

Sources/xpmenvkit/Process.swift

@@ -1,39 +0,0 @@
-import Foundation
-
-extension Process {
-    /// Runs the file at the given path with the given arguments.
-    /// It forwards the intputs/outputs from and to the standard input and output.
-    /// This method blocks the thread until the execution of the process finishes, and then returns the termination status.
-    ///
-    /// - Parameters:
-    ///   - path: path to the file to be executed.
-    ///   - arguments: arguments to be passed.
-    /// - Returns: the termination status.
-    static func run(path: String, arguments: [String] = []) -> Int32 {
-        let process = Process()
-        process.launchPath = path
-        process.arguments = arguments
-
-        let outputPipe = Pipe()
-        let errorPipe = Pipe()
-        let inputPipe = Pipe()
-        process.standardOutput = outputPipe
-        process.standardError = errorPipe
-        process.standardInput = inputPipe
-
-        outputPipe.fileHandleForReading.readabilityHandler = { handler in
-            FileHandle.standardOutput.write(handler.availableData)
-        }
-        errorPipe.fileHandleForReading.readabilityHandler = { handler in
-            FileHandle.standardError.write(handler.availableData)
-        }
-        FileHandle.standardInput.readabilityHandler = { handler in
-            inputPipe.fileHandleForWriting.write(handler.availableData)
-        }
-
-        process.launch()
-        process.waitUntilExit()
-
-        return process.terminationStatus
-    }
-}

Sources/xpmkit/Commands/CommandsContext.swift

@@ -1,4 +1,5 @@
 import Foundation
+import xpmcore
 
 /// Utils class that contains dependencies used by commands.
 protocol CommandsContexting: Contexting {

Sources/xpmkit/Errors/ErrorHandler.swift

@@ -1,4 +1,5 @@
 import Foundation
+import xpmcore
 
 /// Error handling protocol.
 protocol ErrorHandling: AnyObject {

Sources/xpmkit/Generator/GeneratorContext.swift

@@ -1,4 +1,5 @@
 import Foundation
+import xpmcore
 
 /// Generator context protocol.
 protocol GeneratorContexting: Contexting {

Sources/xpmkit/Loader/GraphLoaderContext.swift

@@ -1,5 +1,6 @@
 import Basic
 import Foundation
+import xpmcore
 
 /// Protocol that defines the interface of the context that is used during the graph loading.
 protocol GraphLoaderContexting: Contexting {

Sources/xpmkit/Utils/Context.swift

@@ -1,4 +1,5 @@
 import Foundation
+import xpmcore
 
 /// Context protocol.
 protocol Contexting: AnyObject {

Sources/xpmtools/main.swift

@@ -1,4 +1,5 @@
 import Foundation
+import xpmkit
 
 var registry = CommandRegistry()
 try registry.run()

Tests/xpmkitTests/Commands/DumpCommandTests.swift

@@ -2,6 +2,7 @@ import Basic
 import Foundation
 import Utility
 import XCTest
+@testable import xpmcoreTesting
 @testable import xpmkit
 
 final class DumpCommandTests: XCTestCase {

Tests/xpmkitTests/Commands/GenerateCommandTests.swift

@@ -3,6 +3,7 @@ import Foundation
 import Utility
 @testable import xcodeproj
 import XCTest
+@testable import xpmcoreTesting
 @testable import xpmkit
 
 final class GenerateCommandTests: XCTestCase {

Tests/xpmkitTests/Errors/ErrorHandlerTests.swift

@@ -1,5 +1,6 @@
 import Foundation
 import XCTest
+@testable import xpmcoreTesting
 @testable import xpmkit
 
 fileprivate struct TestError: FatalError {

Tests/xpmkitTests/Utils/Mocks/MockPrinter.swift

@@ -1,25 +0,0 @@
-import Foundation
-@testable import xpmkit
-
-final class MockPrinter: Printing {
-    var printArgs: [String] = []
-    var printErrorArgs: [Error] = []
-    var printSectionArgs: [String] = []
-    var printErrorMessageArgs: [String] = []
-
-    func print(_ text: String) {
-        printArgs.append(text)
-    }
-
-    func print(section: String) {
-        printSectionArgs.append(section)
-    }
-
-    func print(errorMessage: String) {
-        printErrorMessageArgs.append(errorMessage)
-    }
-
-    func print(error: Error) {
-        printErrorArgs.append(error)
-    }
-}