dnrops
/
transformers
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix issue introduced in PR #23163 (#23363) 

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This commit is contained in:
Yih-Dar 2023-05-15 11:38:44 +02:00 committed by GitHub
parent 2958b55fe5
commit 81a73fa638
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/transformers/onnx/config.py
View File

@ -234,7 +234,7 @@ class OnnxConfig(ABC):
if is_torch_available():
from transformers.utils import get_torch_version
return get_torch_version() >= self.torch_onnx_minimum_version
return version.parse(get_torch_version()) >= self.torch_onnx_minimum_version
else:
return False

5
tests/onnx/test_onnx_v2.py
View File

@ -6,6 +6,7 @@ from unittest import TestCase
from unittest.mock import patch
import pytest
from packaging import version
from parameterized import parameterized
from transformers import AutoConfig, PreTrainedTokenizerBase, is_tf_available, is_torch_available
@ -321,7 +322,7 @@ class OnnxExportTestCaseV2(TestCase):
if is_torch_available():
from transformers.utils import get_torch_version
if get_torch_version() < onnx_config.torch_onnx_minimum_version:
if version.parse(get_torch_version()) < onnx_config.torch_onnx_minimum_version:
pytest.skip(
"Skipping due to incompatible PyTorch version. Minimum required is"
f" {onnx_config.torch_onnx_minimum_version}, got: {get_torch_version()}"
@ -364,7 +365,7 @@ class OnnxExportTestCaseV2(TestCase):
if is_torch_available():
from transformers.utils import get_torch_version
if get_torch_version() < onnx_config.torch_onnx_minimum_version:
if version.parse(get_torch_version()) < onnx_config.torch_onnx_minimum_version:
pytest.skip(
"Skipping due to incompatible PyTorch version. Minimum required is"
f" {onnx_config.torch_onnx_minimum_version}, got: {get_torch_version()}"