Commit Graph

9 Commits

Author SHA1 Message Date
David Nadoba c7b4989b02
Remove `#if compiler(>=5.5)` (#2292)
### Motivation
We only support Swift 5.5.2+.

### Modification
Remove all `#if swift(>=5.5)` conditional compilation blocks.

### Result
less branching
2022-10-13 07:17:46 -07:00
George Barnett fcca969463
Raise minimum supported Swift version from 5.4 to 5.5 (#2267)
Motivation:

SwiftNIO periodically drops support for older Swift versions. Now that
5.7 has been released, 5.4 will be dropped.

Modifications:

- Remove 5.4 specific Package.swift and docker-compose
- Update the 5.7 docker-compose to use the released 5.7 and move from
  focal (2004) to jammy (2204)
- Remove unused swiftformat from Dockerfile
- Update tools version in syscall wrapper tests to 5.5
- Update docs

Results:

Minimum Swift version is 5.5
2022-09-29 11:47:44 +01:00
Fabian Fett dc8a317a24
Drop support for Swift 5.2 and 5.3 (#2080)
* Drop support for 5.2 and 5.3

As outlined in a [Swift forums post in November ’21](https://forums.swift.org/t/swiftnio-swift-version-support/53232), SwiftNIO will only support the latest non-patch Swift release and the 2 immediately prior non-patch versions.

In this commit we drop support for Swift 5.2 and 5.3. We update CI for Swift 5.4 to run on bionic instead of focal to ensure that we still test bionic.

* Added Versions paragraph to Security document

* Apply suggestions from code review

Co-authored-by: Cory Benfield <lukasa@apple.com>

Co-authored-by: Cory Benfield <lukasa@apple.com>
2022-04-20 11:48:41 +01:00
David Evans b0effbcfd9
Make Swift 5.2 the minimum requirement (#1860)
Make Swift 5.2 the minimum requirement, dropping support for Swift 5.0 and 5.1.

Motivation:

Whenever we have problems, Swift 5.0 and 5.1 seem to be the culprits. Dropping support for these very old versions will require less maintenance and free up our time to work on new features.

Modifications:

Set the tools version in Package.swift to 5.2
Remove CI configurations for 5.0 and 5.1
Update the various readmes to reflect that this change will be rolled out in NIO 2.30.0
Result:

Swift 5.2 is the minimum version of Swift required to use NIO.
2021-06-18 21:02:41 +01:00
Cory Benfield e7880565aa
We use main as our development branch now. (#1651) 2020-09-24 18:02:44 +01:00
Peter Adams a3a8b3f799
Detail the best way to request a re-review (#1522)
Motivation:

It is unclear how to engage with the core team after changes have been requested.

Modifications:

Add a short note to the CONTRIBUTING guide.

Result:

Increased clarity on how to interact.
2020-05-18 08:04:01 +01:00
Peter Adams 5779ddd54b
Extra information to contributors (#1491)
Motivation:

The more contributors know what's expected of them upfront the less likely they are to consume reviewer time and experience a harsh review.

Modifications:

Add some extra commentary to CONTRIBUTORS.md
Add a docker compose example with specific ubuntu/swift versions to README.md

Result:

Contributors will be more informed.

Co-authored-by: Cory Benfield <lukasa@apple.com>
2020-05-16 11:02:27 +01:00
Helge Heß 6b182f4f5a Make clear generate_linux_tests must be run (#113)
Motivation:

The path of the script to invoke was wrong,
also highlight that this is absolutely required
for a PR.

Modifications:

Some bold, some text, some proper path.

Result:

CI will be super happy as less people will
fail to generate proper Linux tests.
2018-03-08 18:36:31 +09:00
Johannes Weiß 64cf63d72f initial commit 2017-04-20 12:13:14 +01:00