dnrops
/
swift-nio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Lower the max segment count in tests (#2382) 

Motivation:

On older kernel versions testWriteBufferAtGSOSegmentCountLimit fails
because the write fails with EINVAL. This appears to be a kernel bug as
it passes on more recent versions.

Modifications:

- Try again with a lower segment limit if the write fails with EINVAL.

Result:

Less flaky test.
This commit is contained in:
George Barnett 2023-03-01 14:00:24 +00:00 committed by GitHub
parent 652e01c003
commit ec6b8ed8c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
Tests/NIOPosixTests/DatagramChannelTests.swift
View File

@ -1267,15 +1267,28 @@ class DatagramChannelTests: XCTestCase {
func testWriteBufferAtGSOSegmentCountLimit() throws {
try XCTSkipUnless(System.supportsUDPSegmentationOffload, "UDP_SEGMENT (GSO) is not supported on this platform")
var segments = 64
let segmentSize = 10
let didSet = self.firstChannel.setOption(ChannelOptions.datagramSegmentSize, value: CInt(segmentSize))
XCTAssertNoThrow(try didSet.wait())
let buffer = self.firstChannel.allocator.buffer(repeating: 1, count: segmentSize * 64)
let writeData = AddressedEnvelope(remoteAddress: self.secondChannel.localAddress!, data: buffer)
XCTAssertNoThrow(try self.firstChannel.writeAndFlush(NIOAny(writeData)).wait())
let read = try self.secondChannel.waitForDatagrams(count: 64)
XCTAssertEqual(read.map { $0.data.readableBytes }.reduce(0, +), 64 * segmentSize)
func send(byteCount: Int) throws {
let buffer = self.firstChannel.allocator.buffer(repeating: 1, count: byteCount)
let writeData = AddressedEnvelope(remoteAddress: self.secondChannel.localAddress!, data: buffer)
try self.firstChannel.writeAndFlush(NIOAny(writeData)).wait()
}
do {
try send(byteCount: segments * segmentSize)
} catch let e as IOError where e.errnoCode == EINVAL {
// Some older kernel versions report EINVAL with 64 segments. Tolerate that
// failure and try again with a lower limit.
segments = 61
try send(byteCount: segments * segmentSize)
}
let read = try self.secondChannel.waitForDatagrams(count: segments)
XCTAssertEqual(read.map { $0.data.readableBytes }.reduce(0, +), segments * segmentSize)
}
func testWriteBufferAboveGSOSegmentCountLimitShouldError() throws {