dnrops
/
swift-nio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Correct the behavior comment for the Windows implementation of `Lock.deinit`. Add a Windows-specific note to `Lock`'s documentation comment. Trim spurious semicolons appearing in `Lock.init()`. (#1582)

This commit is contained in:
Gwynne Raskind 2020-06-30 02:36:05 -05:00 committed by GitHub
parent a035a1b154
commit 25db3ea68b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Sources/NIOConcurrencyHelpers/lock.swift
View File

@ -25,7 +25,8 @@ import Glibc
///
/// This object provides a lock on top of a single `pthread_mutex_t`. This kind
/// of lock is safe to use with `libpthread`-based threading models, such as the
/// one used by NIO.
/// one used by NIO. On Windows, the lock is based on the substantially similar
/// `SRWLOCK` type.
public final class Lock {
#if os(Windows)
fileprivate let mutex: UnsafeMutablePointer<SRWLOCK> =
@ -41,8 +42,8 @@ public final class Lock {
InitializeSRWLock(self.mutex)
#else
var attr = pthread_mutexattr_t()
pthread_mutexattr_init(&attr);
pthread_mutexattr_settype(&attr, .init(PTHREAD_MUTEX_ERRORCHECK));
pthread_mutexattr_init(&attr)
pthread_mutexattr_settype(&attr, .init(PTHREAD_MUTEX_ERRORCHECK))
let err = pthread_mutex_init(self.mutex, &attr)
precondition(err == 0, "\(#function) failed in pthread_mutex with error \(err)")
@ -51,7 +52,7 @@ public final class Lock {
deinit {
#if os(Windows)
// mutexes do not need to be explicitly destroyed
// SRWLOCK does not need to be free'd
#else
let err = pthread_mutex_destroy(self.mutex)
precondition(err == 0, "\(#function) failed in pthread_mutex with error \(err)")