Commit Graph

1748 Commits

Author SHA1 Message Date
Ben Guo 2185fe95cc improve error parsing and add tests 2017-04-14 18:53:25 -04:00
Brian Dorfman 16eb2f816c Merge pull request #633 from stripe/bdorfmab-fix-bin-range-matching
Fix bin range testing.
2017-04-10 10:30:51 -07:00
Brian Dorfman d3b5e45e07 Fix bin range testing.
Previously partial numbers did not match to any ranges (eg 6 did not match to 622). This meant that the validator sometimes incorrectly said things were invalid when they were in fact incomplete and would also not correctly return `brandForNumber:` for these partial matches. Changed this logic so partial numbers match bin ranges correctly and updated tests.

Also added a bunch of tests for hypthetical bin ranges which start with 0, which I expect is the most likely sort of future bug in this type of numeric comparison.
2017-04-06 17:44:38 -07:00
bg-stripe edf9818514 Merge pull request #625 from stripe/bg-xcode83
Xcode 8.3 updates
2017-04-04 16:40:29 -04:00
Ben Guo 7a4f2dce29 don't use PRODUCT_BUNDLE_IDENTIFIER 2017-04-04 10:54:51 -04:00
Ben Guo 75f8b22894 xcode 8.3 updates 2017-04-03 16:25:16 -04:00
bg-stripe c158f96753 Merge pull request #621 from stripe/bg-token-type
Add token_type to analytics
2017-03-31 15:11:48 -07:00
Ben Guo e41e2bb665 add token_type to analytics 2017-03-31 11:52:43 -07:00
bg-stripe f6f9dc715d Merge pull request #616 from stripe/bg-sepa-line1-optional
Make SEPA line1 optional
2017-03-30 16:06:02 -07:00
Ben Guo 3057359ef8 make sepa line1 optional 2017-03-30 14:59:19 -07:00
bg-stripe 7f0a6412b7 Merge pull request #615 from stripe/bg-paymentmethods-cancel2
Fix bug when canceling in PaymentMethodsVC
2017-03-30 11:02:30 -07:00
Ben Guo 6d99e4bc3a Fix bug when canceling in PaymentMethodsVC 2017-03-29 18:04:34 -07:00
bg-stripe 0ca7f4c442 Merge pull request #607 from stripe/bg-ocmock
add OCMock
2017-03-28 16:41:29 -07:00
bg-stripe 4362599ad5 Merge pull request #608 from stripe/bg-polling-error
Use generic error if polling completes with no error and no source
2017-03-28 15:56:31 -07:00
Ben Guo 883cb921a0 use generic error if polling completes with no error and no source 2017-03-28 15:46:00 -07:00
Ben Guo 74916ad5b8 add OCMock 2017-03-28 15:17:42 -07:00
Brian Dorfman 8ca3664528 Merge pull request #600 from stripe/bdorfman-fix-requestpayment-logic
Fix requestPayment logic
2017-03-28 10:35:46 -07:00
Brian Dorfman 873ecaf88d Fix test compilation 2017-03-28 10:04:07 -07:00
Brian Dorfman fc982776c2 Fix bad else statement 2017-03-28 09:33:21 -07:00
Brian Dorfman 6979ac8c5a Add state machine logic to context
Correct previous logic about triggering paymentMethodsVC via requestPayment.

Context now tracks whether its: doing nothing, showing a user requested VC, showing a requestPayment triggered VC.
This handles knowing whether to continue doing a paymentRequest after a view controller returns (or firing a didFinish with a user cancelled state) and makes trying to show a VC or request a payment while we are already doing one of those things a no-op.

Also adds necessary callback to payment methods VC to differentiate cancels from successful finishes.
2017-03-27 18:32:13 -07:00
Brian Dorfman 0bdb915d7e Fix requestPayment logic
If there is no selectedPaymentMethod, we should just call requestPaymentMethodsVC instead. Besides de-duping code, current logic is wrong as it doesn't offer an option to use Apple Pay if its available.

Also seems like there was a missing else statement in this if/else flow. Not sure how this was working correctly tbh, seems like if you had no method and also no shipping info, it would try to push both? And/or set your `isMidShippingInRequestPayment` bit incorrectly.
2017-03-23 16:45:51 -07:00
Brian Dorfman 3833f72f12 Merge pull request #595 from stripe/bdorfman-fix-sourceparams-test
Fix source params test
2017-03-23 09:55:29 -07:00
Brian Dorfman 32f864d788 Fix source params test
Do object comparison and not pointer comparison
2017-03-22 15:14:03 -07:00
Brian Dorfman ad8c58715c Merge pull request #589 from stripe/bg-release-10.0.1
Release v10.0.1
2017-03-16 11:08:21 -07:00
Ben Guo 8cbf1a9aac update documentation 2017-03-15 15:02:22 -04:00
Ben Guo 0a21ba5c9c update podspec 2017-03-15 15:00:41 -04:00
Ben Guo 53b31f4330 update version 2017-03-15 14:57:49 -04:00
Ben Guo ebb76a3415 update CHANGELOG 2017-03-15 14:55:12 -04:00
bg-stripe 87e2709be7 Merge pull request #585 from stripe/bg-reload-list
Reload payment methods vc when a new method is added
2017-03-15 13:45:41 -04:00
Ben Guo 12fa0cf37c reload payment methods vc when a new method is added 2017-03-14 14:37:29 -04:00
bg-stripe 336ce7dff3 Merge pull request #581 from stripe/bg-cardparams-name-fix
Add name to card source params
2017-03-13 14:36:41 -04:00
Ben Guo 80eb40237c add name to card source params 2017-03-10 16:59:13 -05:00
Brian Dorfman 51fe7647fd Merge pull request #575 from stripe/bg-release-10.0.0
Release v10.0.0
2017-03-08 13:49:29 -08:00
Ben Guo 7a5c914441 add note to CHANGELOG about enabling sources in dashboard 2017-03-08 14:14:17 -05:00
Ben Guo a3919c4958 remove git version check from check_version.rb 2017-03-07 13:20:02 -05:00
Ben Guo 15b83b9f48 update MIGRATING 2017-03-07 13:19:46 -05:00
Ben Guo c0d9ad9aff update CHANGELOG 2017-03-07 13:19:39 -05:00
Ben Guo 132c0d0c32 update documentation 2017-03-07 12:43:38 -05:00
Ben Guo 732f959124 update Stripe.podspec 2017-03-07 12:43:38 -05:00
Ben Guo 931fb47076 update VERSION 2017-03-07 12:43:38 -05:00
Ben Guo f7fcd07c15 update Info.plist version 2017-03-07 12:43:38 -05:00
Ben Guo f531c54794 update STPSDKVersion 2017-03-07 12:43:38 -05:00
Ben Guo fdb9c19d48 update MIGRATIONG 2017-03-07 12:43:38 -05:00
Ben Guo 2dfdad842b update CHANGELOG 2017-03-07 12:43:38 -05:00
Ben Guo baf7bfe3f9 update README.md 2017-03-07 12:43:38 -05:00
Ben Guo 8aafc205fe update build_documentation.sh 2017-03-07 12:43:38 -05:00
Brian Dorfman b8ba89330a Merge pull request #579 from stripe/bdorfman-property-attributes
Fix several property declarations.
2017-03-07 09:42:03 -08:00
bg-stripe 58f85fc22b Merge pull request #572 from stripe/bg-muid
Add muid to card token creation
2017-03-06 18:02:46 -05:00
Brian Dorfman cbad85625e Also remove preprocessor check from .m file 2017-03-06 12:51:42 -08:00
Brian Dorfman 168d417d8d Fix several property declarations.
Add some missing strong/nullable identifiers.
2017-03-06 12:01:33 -08:00