mirror of https://github.com/rust-lang/rust.git
121e87bf14
`CheckAttrVisitor::check_doc_keyword` checks `#[doc(keyword = "..")]` attributes to ensure they are on an empty module, and that the value is a non-empty identifier. The `rustc::existing_doc_keyword` lint checks these attributes to ensure that the value is the name of a keyword. It's silly to have two different checking mechanisms for these attributes. This commit does the following. - Changes `check_doc_keyword` to check that the value is the name of a keyword (avoiding the need for the identifier check, which removes a dependency on `rustc_lexer`). - Removes the lint. - Updates tests accordingly. There is one hack: the `SelfTy` FIXME case used to used to be handled by disabling the lint, but now is handled with a special case in `is_doc_keyword`. That hack will go away if/when the FIXME is fixed. Co-Authored-By: Guillaume Gomez <guillaume1.gomez@gmail.com> |
||
|---|---|---|
| .. | ||
| README.md | ||
| cfg-rustdoc.rs | ||
| cfg-rustdoc.stderr | ||
| check-doc-alias-attr-location.rs | ||
| check-doc-alias-attr-location.stderr | ||
| check-doc-alias-attr.rs | ||
| check-doc-alias-attr.stderr | ||
| deny-invalid-doc-attrs.rs | ||
| deny-invalid-doc-attrs.stderr | ||
| doc-alias-crate-level.rs | ||
| doc-alias-crate-level.stderr | ||
| doc-alias-same-name.rs | ||
| doc-alias-same-name.stderr | ||
| doc-inline-extern-crate.rs | ||
| doc-inline-extern-crate.stderr | ||
| doc-primitive.rs | ||
| doc-primitive.stderr | ||
| doc-test-attr-pass.rs | ||
| doc-test-attr.rs | ||
| doc-test-attr.stderr | ||
| doc_keyword.rs | ||
| doc_keyword.stderr | ||
| duplicate_doc_alias.rs | ||
| duplicate_doc_alias.stderr | ||
| feature-gate-doc_primitive.rs | ||
| feature-gate-doc_primitive.stderr | ||
| hidden-doc-associated-item.rs | ||
| renamed-features-rustdoc_internals.rs | ||
| renamed-features-rustdoc_internals.stderr | ||
| unterminated-doc-comment.rs | ||
| unterminated-doc-comment.stderr | ||
README.md
This directory is for tests that have to do with rustdoc, but test the behavior of rustc. For example, rustc should not warn that an attribute rustdoc uses is unknown.