mirror of https://github.com/rust-lang/rust.git
af081a4247
only resolve top-level guard patterns' guards once We resolve guard patterns' guards in `resolve_pattern_inner`, so to avoid resolving them multiple times, we must avoid doing so earlier. To accomplish this, `LateResolutionVisitor::visit_pat` contains a case for guard patterns that avoids visiting their guards while walking patterns. This PR fixes #141265, which was due to `visit::walk_pat` being used instead; this meant guards at the top level of a pattern would be visited twice. e.g. it would ICE on `for x if x in [] {}`, but not `for (x if x) in [] {}`. `visit_pat` was already used for the guard pattern in the second example, on account of the top-level pattern being parens. |
||
|---|---|---|
| .. | ||
| macro-rules.rs | ||
| name-resolution.rs | ||
| name-resolution.stderr | ||
| only-gather-locals-once.rs | ||
| only-resolve-top-level-guard-expr-once-ice-141265.rs | ||
| only-resolve-top-level-guard-expr-once-ice-141265.stderr | ||