dnrops
/
rust
mirror of https://github.com/rust-lang/rust.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,500 Commits 7 Branches 138 Tags 1.7 GiB
Commit Graph

3500 Commits

Author SHA1 Message Date
Oliver Schneider fc7b3955f8
Merge pull request #2446 from goodmanjonathan/fix-copies-test 
Make several tests actually test the correct lints
 2018-02-09 12:41:08 +01:00
Oliver Schneider ffb3a56c41
Merge pull request #2445 from guido4000/patch-1 
Simplify recommended command
 2018-02-09 08:06:51 +01:00
Jonathan Goodman 44780aca5d make the copies.rs test actually test the correct lints 2018-02-08 13:26:50 -06:00
Guido b52f46d1d1
Change command to run clippy without installation 2018-02-08 12:37:56 +01:00
Guido 45e4f3aac7
Simplify recommended command 2018-02-07 19:24:38 +01:00
Oliver Schneider 6f48e37d22
Merge pull request #2444 from phansch/fix_incorrect_useless_attribute_suggestion 
Partly fix incorrect useless_attribute suggestion
 2018-02-07 09:07:46 +01:00
Philipp Hansch 81f5969704
Partly fix incorrect useless_attribute suggestion 
This fixes an incorrect suggestion from the `useless_attribute` lint
when using `cfg_attr`.

Additionally, it will not show a suggestion anymore, if the attribute
begins on a previous line, because it is much harder to construct the
span of multi-line `cfg_attr` attributes as they don't appear in the AST.

To fix it completely, one would have to parse upwards into the file,
and find the beginning of the `cfg_attr` attribute.
 2018-02-06 22:35:11 +01:00
Oliver Schneider 81b2565246
Merge pull request #2443 from goodmanjonathan/fix-2438 
Don't suggest eliding 'static on associated consts
 2018-02-06 19:35:26 +01:00
Jonathan Goodman 73f2ba5ded don't suggest eliding 'static on associated consts 2018-02-06 12:22:34 -06:00
Oliver Schneider b835877d2e
Merge pull request #2441 from flip1995/literal_rep 
Make decimal_literal_representation a restriction lint
 2018-02-06 13:47:28 +01:00
flip1995 63a7daf78c Make decimal_literal_representation a restriction lint 2018-02-06 13:05:20 +01:00
Oliver Schneider c322a74980
Merge pull request #2439 from gnieto/fix/cterror 
Fix ICE comparing `ExprRange` equality
 2018-02-06 09:19:51 +01:00
Guillem Nieto bcf2e41421 Fix ICE comparing `ExprRange` 
`eq_expr` on hir::utils was throwing an ICE due to an invalid
LateContext being used. Due to this missusage, it was generating an ICE
with the code on the following issue:
https://github.com/rust-lang-nursery/rust-clippy/issues/2423
 2018-02-06 01:06:32 +01:00
Oliver Schneider 503a63390d
Cleanup calls to `layout_of` 2018-02-05 11:28:09 +01:00
Oliver Schneider ce47e529d2
Version Bump 2018-02-05 08:48:40 +01:00
Oliver Schneider 30a37efaac
Merge pull request #2433 from kimsnj/matches_sugg 
Fix suggestions for ref matches
 2018-02-05 08:21:21 +01:00
Oliver Schneider 7fddc6116e
Merge pull request #2415 from HMPerson1/fix-2356 
Fix `ImplItem`s being ignored
 2018-02-05 08:19:11 +01:00
Oliver Schneider 02ee62533d
Merge pull request #2428 from phansch/fix_lint_list_issues 
Allow empty lines in lint doc examples
 2018-02-05 08:18:20 +01:00
Oliver Schneider bef22006b4
Merge pull request #2419 from phansch/fix_doc_comment_false_positive 
Fix false positive in empty_line_after_outer_attr
 2018-02-05 08:17:29 +01:00
Oliver Schneider 02830187cc
Merge pull request #2436 from messense/rustup 
Rustup to rustc 1.25.0-nightly (0c6091fbd 2018-02-04)
 2018-02-05 08:08:15 +01:00
messense 5226b664a1
Rustup to rustc 1.25.0-nightly (0c6091fbd 2018-02-04) 2018-02-05 12:16:17 +08:00
Karim Snj 21f606bd68 Removing extra newline 2018-02-04 13:55:37 +01:00
Karim Snj 9575dac491 Fix suggestions for ref matches 2018-02-04 13:41:54 +01:00
Manish Goregaokar 8e8cf2feb1 Bump to 0.0.185 2018-02-02 13:23:32 +05:30
HMPerson1 10d2feddba
Fix `const_static_lifetime` 2018-02-02 02:03:21 -05:00
Manish Goregaokar c26be4c05c
Merge pull request #2430 from Frederick888/fix-2429 
set CodeSuggestion approximate to false. fixes #2429
 2018-02-02 12:30:46 +05:30
HMPerson1 ff83b3ecb9
Fix `non_expressive_names` 2018-02-02 01:54:07 -05:00
HMPerson1 3a4ea45821
Fix `get_enclosing_block` 2018-02-02 01:53:48 -05:00
Frederick Zhang c5ee8b5dfb set CodeSuggestion approximate to false. fixes #2429 2018-02-02 16:24:32 +11:00
Philipp Hansch 5c28cd259a
Allow empty lines in lint doc examples 
This makes sure that empty lines in lint examples are preserved.

It also fixes the documentation for the invalid_ref lint, which was not
shown because of an extra newline before the lint declaration.
 2018-02-01 23:21:36 +01:00
Oliver Schneider d5bac82837
Give travis a guaranteed existing directory for ui test output 2018-02-01 14:35:56 +01:00
Oliver Schneider 6f99052580
Merge pull request #2417 from mathstuf/gitignore-support-symlinks 
gitignore: support ignoring target as symlinks
 2018-02-01 08:09:25 +01:00
Philipp Hansch a64724fac4
Fix false positive in empty_line_after_outer_attr 
Doc comments are syntactic sugar for #[doc] attributes, so this lint was
catching them, too.

This commit makes it so that doc comments are ignored in this lint.

I think, for normal attributes it makes sense to warn about following empty
lines, for doc comments, less. This way the user has some freedom over
the formatting.
 2018-02-01 07:43:03 +01:00
Ben Boeckel 3358dd72ed gitignore: support ignoring target as symlinks 2018-01-31 14:51:40 -05:00
Oliver Schneider 6f90f583b4
Merge pull request #2410 from gnieto/task/questionMarkIso 
Question mark lint
 2018-01-31 08:27:53 +01:00
Guillem Nieto 05ed421930 Update UI tests 2018-01-31 00:10:35 +01:00
Guillem Nieto 74ae9b15b5 Add question mark operator 2018-01-31 00:10:35 +01:00
Oliver Schneider ee8d32850d
Merge pull request #2413 from flip1995/assign_ops 
Improved suggestion on misrefactored_assign_op lint
 2018-01-30 19:17:38 +01:00
flip1995 bd421cb5a5 Additionally suggest the semantic equal variant 2018-01-30 17:45:35 +01:00
Oliver Schneider 8123495e0f
Version bump 2018-01-30 15:02:47 +01:00
flip1995 b7cb0752ff Improved suggestion on misrefactored_assign_op lint. Fixes #1239 2018-01-30 14:58:38 +01:00
Oliver Schneider 39d1d6081f
Merge pull request #2340 from phansch/newline_after_attributes 
Warn on empty lines after outer attributes
 2018-01-30 13:09:23 +01:00
Oliver Schneider dbbae5740b
Merge pull request #2412 from topecongiro/double-comparison 
Add double comparison lint
 2018-01-30 09:31:56 +01:00
Seiichi Uchida a3c2323767 Add double comparions lint 2018-01-30 10:35:35 +09:00
Seiichi Uchida c3e9ec65a1 Rustup to rustc 1.25.0-nightly (90eb44a58 2018-01-29) 2018-01-30 10:35:22 +09:00
Oliver Schneider 4e467661c0
Merge pull request #2409 from montrivo/while_let_on_iterator 
#1121: already fixed, adding a test
 2018-01-29 19:21:00 +01:00
Tim Nielens 0778ac81c8 #1121: already fixed, adding a test 2018-01-29 16:52:22 +01:00
Philipp Hansch 3d54e56ed4
Add workaround for hidden outer attribute 
If the snippet is empty, it's an attribute that was inserted during macro
expansion and we want to ignore those, because they could come from external
sources that the user has no control over.
For some reason these attributes don't have any expansion info on them, so
we have to check it this way until there is a better way.
 2018-01-29 10:03:53 +01:00
Philipp Hansch aade0d563e
Make lint work on all members of ast::Item_ 2018-01-29 10:03:52 +01:00
Philipp Hansch 83909398d2
Add test case for comments between item and attr 2018-01-29 10:03:52 +01:00