Commit Graph

5748 Commits

Author SHA1 Message Date
bors dc825a36f2 Auto merge of #3894 - markcatley:adding_lint_documentation_fixes, r=phansch
Add implementation for the EarlyLintPass trait into the Adding Lints …

…documentation.

To follow along with the adding lint documentation you need to implement this trait in order to register the lint pass.
2019-03-19 06:05:41 +00:00
Mark Catley 5c8c487851 Add implementation for the EarlyLintPass trait into the Adding Lints documentation.
To follow along with the adding lint documentation you need to implement this trait in order to register the lint pass.
2019-03-19 13:39:19 +13:00
bors 92612c9de1 Auto merge of #3893 - mati865:rustup, r=oli-obk
Rustup

Supersedes https://github.com/rust-lang/rust-clippy/pull/3889

Addresses some review comments from previous PR and rustups to https://github.com/rust-lang/rust/pull/58899
2019-03-18 16:21:56 +00:00
Mateusz Mikuła 6cb0605600 Cargo fmt 2019-03-18 13:39:11 +01:00
Mateusz Mikuła 664391c5f8 Drop range_contains feature 2019-03-18 12:54:10 +01:00
Mateusz Mikuła 8feb2c6b2f Fix rustfmt::skip detection 2019-03-18 12:54:10 +01:00
Mateusz Mikuła fb7699d9e5 Rework clippy detection in attribute lint 2019-03-18 12:54:10 +01:00
Mateusz Mikuła 0ea5e38a9e name -> check_name 2019-03-18 12:54:10 +01:00
Mateusz Mikuła 4bb6c87b08 span -> span() 2019-03-18 12:54:10 +01:00
Mateusz Mikuła b25564fc8a name -> ident_str 2019-03-18 12:54:10 +01:00
Mateusz Mikuła e63a685412 NestedMetaItemKind -> NestedMetaItem 2019-03-18 12:54:10 +01:00
Mateusz Mikuła cf71caa71d Drop redundant & 2019-03-18 12:54:10 +01:00
Mateusz Mikuła cb3aa7480c Fix path_qualified
As suggested by eddyb
2019-03-18 12:54:10 +01:00
Mateusz Mikuła 9b7ff501a6 Replace most of ty:Ty with Ty 2019-03-18 12:54:10 +01:00
flip1995 4832a853c7
Feed dog 2019-03-16 15:39:02 +01:00
flip1995 180e07e99e
Adapt paths to new formatting 2019-03-16 15:22:31 +01:00
flip1995 3c4616d303
cargo fmt 2019-03-16 11:51:57 +01:00
flip1995 254fad95de
Use LocalInternedString inside of AbsolutePathPrinter 2019-03-16 11:45:29 +01:00
flip1995 dae5c9c685
AbsolutePathBuffer -> AbsolutePathPrinter 2019-03-16 11:17:36 +01:00
flip1995 2d8618e95c
Remove ty::TyKind from eta_reduction and replace it with ty::Ty 2019-03-16 11:10:33 +01:00
flip1995 8eadbfd35b
parent_def_id -> parent 2019-03-15 23:44:04 +01:00
flip1995 dcbd3aefa2
item_path_str -> def_path_str 2019-03-15 23:43:42 +01:00
flip1995 31435cd7f5
Reimplement AbsolutePathBuffer 2019-03-15 23:42:46 +01:00
bors 54e20519d2 Auto merge of #3886 - phansch:rustfix_useless_asref, r=flip1995
Enable rustfix for `useless_asref` lint tests

cc #3630
2019-03-15 09:43:29 +00:00
Philipp Hansch 0019ca5e4f
Enable rustfix for `useless_asref` lint tests 2019-03-15 07:29:12 +01:00
bors e7806413c6 Auto merge of #3883 - daxpedda:missing_docs_in_private_items, r=phansch
Add `doc(include = ...)` detection to `missing_docs_in_private_items`

The whole `missing documentation in crate` part doesn't have any tests. If I should add test cases tell me.
2019-03-15 06:18:28 +00:00
daxpedda 9061fd3199
Another test for missing crate documentation. 2019-03-14 19:38:41 +01:00
daxpedda e1096e3310
Add a test for `doc(include)`
Tiny code improvement.
2019-03-14 19:33:06 +01:00
daxpedda 177b3b27c4
Add `doc(include = ...)` detection to `missing_docs_in_private_items` 2019-03-14 18:32:39 +01:00
bors bb41b16423 Auto merge of #3879 - phansch:rustfix_string_lit_as_bytes, r=flip1995
Run rustfix for string_lit_as_bytes tests

This moves the `string_lit_as_bytes` tests into a new file and enables
rustfix tests for them.

cc #3603, #2038
2019-03-14 17:29:19 +00:00
bors 9df38117d9 Auto merge of #3877 - rink1969:3842, r=flip1995
casting integer literal to float is unnecessary

fix issue https://github.com/rust-lang/rust-clippy/issues/3842
2019-03-14 16:32:15 +00:00
rink1969 d9dd008e44 casting integer literal to float is unnecessary 2019-03-14 15:53:08 +08:00
bors 729892961c Auto merge of #3880 - phansch:uicleanup9001, r=oli-obk
UI test cleanup: Extract manual_memcpy tests

cc #2038
2019-03-14 07:52:00 +00:00
Philipp Hansch 5e4a7eb1fc
UI test cleanup: Extract manual_memcpy tests 2019-03-14 07:26:47 +01:00
Philipp Hansch 67aad6c180
Run rustfix for string_lit_as_bytes tests
This moves the `string_lit_as_bytes` tests into a new file and enables
rustfix tests for them.
2019-03-14 06:59:30 +01:00
bors 99fdf2607e Auto merge of #3873 - phansch:hiridification, r=flip1995
Some more HirId-ification

* 8a59f81: Rename span_lint_node* functions to span_lint_hir*
* a457258: Use `HirId` instead of `NodeId` for lookup
2019-03-13 08:45:23 +00:00
Philipp Hansch bf86c1b989
cargo fmt 2019-03-13 06:51:57 +01:00
bors 8fc0a738e3 Auto merge of #3869 - taiki-e:use_self, r=flip1995
Fix `use_self` false positive on nested functions

Related to https://github.com/rust-lang/rust-clippy/pull/3640

The current `use_self` warns the following code.

```rust
#![warn(clippy::use_self)]
struct Foo {}
impl Foo {
    fn bar() {
        fn baz() -> Foo { //^ warning: unnecessary structure name repetition
            Foo {} //^ warning: unnecessary structure name repetition
         }
    }
}
```
2019-03-12 12:09:56 +00:00
bors 6e2b8fa8ca Auto merge of #3872 - phansch:some_feature_cleanup, r=oli-obk
Remove some unused features and `error-pattern`s

None
2019-03-12 09:34:04 +00:00
bors 3d31c2157a Auto merge of #3794 - mikerite:fix-3739, r=phansch
Fix `boxed_local` suggestion

Don't warn about an argument that is moved into a closure.

ExprUseVisitor doesn't walk into nested bodies so use a new
visitor that collects the variables that are moved into closures.

Fixes #3739
2019-03-12 07:43:14 +00:00
Philipp Hansch a457258132
Use `HirId` instead of `NodeId` for lookup 2019-03-12 08:21:22 +01:00
Philipp Hansch c730de955e
Remove some unused features and `error-pattern`s 2019-03-12 08:15:50 +01:00
bors 75bfa29533 Auto merge of #3871 - taiki-e:needless_continue, r=phansch
Fix `needless_continue` false positive

If the `continue` has a label, check it matches the label of the loop.

Fixes https://github.com/rust-lang/rust-clippy/issues/2329
2019-03-12 07:04:44 +00:00
Philipp Hansch 8a59f81180
Rename span_lint_node* functions to span_lint_hir*
Because they now take a `hir_id` instead of a `node_id` argument.
2019-03-12 08:01:21 +01:00
bors b586d76b43 Auto merge of #3865 - phansch:run_more_doc_tests, r=flip1995
Run more doc tests

This executes some more doc tests that were ignored before.
2019-03-12 06:22:00 +00:00
Michael Wright 6937d5581a Merge branch 'master' into fix-3739 2019-03-12 08:13:44 +02:00
bors 94a8d9cbcd Auto merge of #3868 - taiki-e:needless_pass_by_value, r=phansch
Filter out proc_macro and proc_macro_attribute

Related to https://github.com/rust-lang/rust-clippy/pull/1617

Fixes https://github.com/rust-lang/rust-clippy/issues/3067 (this issue has already been closed, but in fact the false positive in `#[proc_macro]` and `#[proc_macro_attribute]` has not been fixed yet)
2019-03-12 06:01:00 +00:00
Philipp Hansch 9ca34e37fa
Run more doc tests
This executes some more doc tests that were ignored before.
2019-03-12 06:53:25 +01:00
Taiki Endo 1bc7da2fec Fix `needless_continue` false positive 2019-03-12 03:40:30 +09:00
Taiki Endo 187ce4c5ab Fix `use_self` false positive on nested functions 2019-03-11 23:24:49 +09:00