Commit Graph

1198 Commits

Author SHA1 Message Date
Oliver Schneider 299f1270a6
Rustup 2017-11-10 08:58:54 +01:00
Shotaro Yamada b17899878f Build path from current_dir 2017-11-09 14:47:14 +09:00
Shotaro Yamada 5c0b99820b Use compiletest 0.3 2017-11-09 11:05:49 +09:00
laurent 82793768b7 Handle methods with an immediate negation in the non-minimal boolean lint, fixes #1930. 2017-11-07 21:43:24 +00:00
Oliver Schneider 1b323b9f35
Don't lint mixed slice indexing and usize indexing in `needless_range_loop` 2017-11-07 15:32:52 +01:00
Oliver Schneider 652df0fb79
Differentiate between mutable iteration and immutable iteration in `needless_range_loop` 2017-11-07 14:41:54 +01:00
Oliver Schneider 088555c4ea
Merge pull request #2209 from sinkuu/trait_methods
Fix false positive in needless_pass_by_value trait methods
2017-11-07 08:26:32 +01:00
laurent c9681905ba Fix broken tests. 2017-11-06 23:26:44 +00:00
laurent e2b9cf836a Fix merge issues. 2017-11-06 23:22:19 +00:00
sinkuu 6fb736bd42 Fix false positive in needless_pass_by_value trait methods 2017-11-07 06:33:49 +09:00
sinkuu 00081be73d Rustup 2017-11-07 06:32:12 +09:00
clippered 66bc12564a put back negative tests but allow float_cmp 2017-11-06 21:34:30 +11:00
clippered ddaf8580d5 remove duplicate tests with float_cmp 2017-11-06 20:23:18 +11:00
clippered cd3106d99f add more negative tests 2017-11-06 20:02:42 +11:00
Oliver Schneider ed589761e6
Merge pull request #2202 from topecongiro/format
Run `cargo fmt`
2017-11-06 08:35:52 +01:00
Oliver Schneider 4018b0a495
Merge pull request #2197 from AlexEne/dissalow-underscores-and-numbrers
Warns if variable name is composed only of underscores and digits.
2017-11-06 08:11:45 +01:00
laurent bcdf57e220 Refactor the never-loop detection, fixes #1991. 2017-11-05 14:43:28 +00:00
clippered 2787a60fc2 Fix #1142 float constant comparison lint 2017-11-05 09:37:17 +11:00
topecongiro 7a06d312fd Cargo fmt 2017-11-05 04:55:56 +09:00
Alexandru Ene f92c91601e Addressed PR comments 2017-11-03 20:54:33 +00:00
sinkuu d88cc5376e Add test to take `Self` as an argument 2017-11-03 17:56:26 +09:00
sinkuu be7c4b4862 Fix test 2017-11-03 17:36:38 +09:00
sinkuu cad33c0306 Extend needless_pass_by_value to methods 2017-11-03 17:36:38 +09:00
cgm616 3902b836e7 Update tests 2017-11-02 23:54:35 -05:00
cgm616 ee289c9f88 Merge branch 'master' of github.com:rust-lang-nursery/rust-clippy 2017-11-02 22:57:07 -05:00
Alexandru Ene 9d01468bc7 Warns if variable name is composed only of underscores and digits. 2017-11-03 01:01:41 +00:00
Oliver Schneider cabbc781ca
Merge pull request #2189 from gendx/pr-1590
Start working on #1590
2017-11-02 10:29:30 +01:00
sinkuu 7fa27d9387 Lint `transmute::<&[u8], &str>` 2017-11-01 18:05:46 +09:00
kennytm 44d3ea5308 Fix lint_without_lint_pass 2017-10-31 10:04:02 -07:00
Manish Goregaokar c526c51923 Update clippy for rustc 1.23.0-nightly (f0fe716db 2017-10-30) 2017-10-31 00:07:10 -07:00
G. Endignoux 87fd68731d Update UI tests. 2017-10-30 14:10:38 +01:00
G. Endignoux f0a1eff1c4 Start working on #1590 2017-10-30 13:08:09 +01:00
Manish Goregaokar 09143cdaf0 Update tests; make it work with generics on context 2017-10-29 05:19:24 -04:00
cgm616 fed5a89076 Add tests for pub_restricted 2017-10-28 13:24:39 -05:00
cgm616 d094f98f0b Merge branch 'master' of github.com:rust-lang-nursery/rust-clippy 2017-10-28 12:55:16 -05:00
Alex Burka 2153d1e560 manual fixups if_let_chain -> if_chain 2017-10-23 17:53:30 -04:00
Oliver Schneider 2771378620 Merge pull request #2136 from ykrivopalov/identity_op_fixing
Identity/erasing operation lints
2017-10-23 09:25:08 +02:00
Oliver Schneider b96639f23a Merge pull request #2143 from HMPerson1/master
Add lint for fallible impls of `From`
2017-10-23 09:21:31 +02:00
Oliver Schneider 6d89798119 Merge pull request #2163 from HMPerson1/useless_asref
Add lint for useless `as_ref` calls
2017-10-23 09:16:44 +02:00
cgm616 29626b883e Merge branch 'master' of github.com:rust-lang-nursery/rust-clippy 2017-10-22 10:14:44 -04:00
HMPerson1 bfa7a9b138 Add tests for generic code 2017-10-21 13:55:12 -04:00
cgm616 60c7bd47a5 Prevent should_implement_trait on private method
This should close #2159.
2017-10-21 07:53:57 -04:00
sinkuu 00d35eea26 Fix typo 2017-10-21 19:16:13 +09:00
HMPerson1 7206023b1b Change to `TryFrom` 2017-10-20 20:47:51 -04:00
HMPerson1 e5076d06db Add lint for `From<String>` 2017-10-20 20:47:30 -04:00
HMPerson1 ff4a850353 Add lint for useless `as_ref` calls 2017-10-20 20:33:19 -04:00
Oliver Schneider 0e489f3221 Merge pull request #2146 from MaloJaffre/println_empty_string
Add PRINTLN_EMPTY_STRING lint.
2017-10-20 17:39:34 +02:00
Malo Jaffré 22f3ca0e2c Add PRINTLN_EMPTY_STRING lint. 2017-10-20 16:45:32 +02:00
Paul Florence acdd93a5cc Final .stderr for `const_static_lifetime`. 2017-10-20 10:17:55 -04:00
Paul Florence 0928168a79 Remove "#![feature(plugin)]" in the test". 2017-10-20 10:17:41 -04:00
Paul Florence 4bbda68d56 Better linting : use of span_lint_and_then. 2017-10-20 10:17:41 -04:00
Paul Florence fbce504664 Added the test results. 2017-10-20 10:17:41 -04:00
Paul Florence 322effe415 Implementation of the `const_static_lifetime` lint. 2017-10-20 10:17:41 -04:00
Oliver Schneider 9293188b65 Merge pull request #2156 from cgm616/master
Deprecate should_assert_eq lint
2017-10-20 15:24:52 +02:00
Oliver Schneider 281bd790de Merge pull request #2148 from sinkuu/proc_macro
needless_pass_by_value false-positive in annotation
2017-10-20 11:12:21 +02:00
cgm616 4960d9de86 Deprecate should_assert_eq lint
This should close #2090.
2017-10-19 23:42:04 -05:00
sinkuu 9221bd9c97 Add test 2017-10-18 14:06:38 +09:00
clippered dfa4cb7ade Fix #2123 : check that the source and destination are different for manual memcpy 2017-10-18 07:06:01 +11:00
Oliver Schneider f01e45faa4 Merge pull request #2131 from devonhollowood/suggest-print
Suggest print
2017-10-17 15:26:41 +02:00
Oliver Schneider 343e438f9d Merge pull request #2120 from sinkuu/implicit_hasher
Implicit hasher lint
2017-10-17 15:24:20 +02:00
sinkuu eea30777dd Type parameter change and type change are now in a multispan suggestion 2017-10-17 21:40:46 +09:00
sinkuu a4f45e85b1 Use cx.access_levels.exported() instead of visibility 2017-10-17 21:13:17 +09:00
Yury Krivopalov 7b16f4d7ff Clarify message for erasing_op lint 2017-10-15 10:32:47 +03:00
Devon Hollowood eda013d3af Change lint filename
suggest_print.rs -> explicit_write.rs
2017-10-14 21:42:14 -03:00
Devon Hollowood aeeb38dab1 Change lint name
From `suggest_print` to `explicit_write`
2017-10-14 21:26:50 -03:00
Yury Krivopalov 033c99b1ba Add erasing_op lint
For expressions that can be replaced by a zero.
2017-10-14 12:34:37 +03:00
Yury Krivopalov f68e408cb6 identity_op lint fix for '&' with unsigned types 2017-10-14 12:21:23 +03:00
sinkuu c3332ca92e Fix panic with fake `Range` type 2017-10-13 21:51:57 +09:00
Devon Hollowood e31a0941e2 Fix output for write macros 2017-10-12 05:53:20 -03:00
Devon Hollowood 1089380518 Add expected output 2017-10-12 05:33:00 -03:00
Devon Hollowood 888076b698 Add suggest_print lint 2017-10-12 05:30:35 -03:00
sinkuu 31f16b87b7 Use `rustc_typeck::hir_ty_to_ty` 2017-10-11 23:08:36 +09:00
sinkuu 5a61d88fa1 Apply suggestions 2017-10-11 22:17:00 +09:00
Oliver Schneider f0aa2c1587 Merge pull request #2127 from rust-lang-nursery/enum_variant_names_fp
Don't lint accidental "prefixes" on enum variants
2017-10-11 13:16:59 +02:00
Oliver Schneider 58002b0e37 Merge pull request #2119 from camsteffen/never_loop
Another never_loop fix
2017-10-11 08:21:28 +02:00
sinkuu 159cc8413c Add implicit_hasher lint (#2101) 2017-10-11 12:10:26 +09:00
Lukas Stevens 4438c41d14 Make suggested changes
- Fix copy-paste error
- Check for opt.map_or argument after ensuring that opt is an Option
- Use span_lint_and_then and span_suggestion
- Update reference
2017-10-10 15:35:24 +02:00
Lukas Stevens eb53cca768 Add lint for opt.map_or(None, f)
Change to Warn and add multiline support

Fix typo

Update reference
2017-10-10 13:37:45 +02:00
Oliver Schneider af6e2a1e4e
Don't lint accidental "prefixes" on enum variants 2017-10-10 12:37:59 +02:00
Oliver Schneider b62b1b68ed Merge pull request #2126 from camsteffen/split-tests
Split some UI tests
2017-10-10 10:06:14 +02:00
Oliver Schneider 408b5220a8 Merge pull request #2122 from sinkuu/local_span
Test failure fix with rustc 1.22.0-nightly (150b625a0 2017-10-08)
2017-10-10 09:39:10 +02:00
Oliver Schneider 28c401f9db Merge pull request #2118 from chyvonomys/relax-needless-loop
relax `needless_range_loop` so that it reports only direct indexing
2017-10-10 09:37:51 +02:00
Cameron Steffen 35882b09da move get_unwrap tests 2017-10-10 00:14:47 -05:00
Cameron Steffen 90b428e88d move ok_expect tests 2017-10-10 00:03:39 -05:00
Cameron Steffen 3356d121df move string_extend tests 2017-10-09 23:57:17 -05:00
Cameron Steffen 6d94167014 move cstring tests 2017-10-09 23:39:45 -05:00
Cameron Steffen 5eeadcfc43 move unnecessary clone tests 2017-10-09 23:38:56 -05:00
Cameron Steffen 18717ae088 move single_char_pattern tests 2017-10-09 23:37:46 -05:00
Cameron Steffen c1a147f48e move starts_ends_with tests 2017-10-09 23:36:29 -05:00
sinkuu 9ebc30cb0c rustc 1.22.0-nightly (150b625a0 2017-10-08) 2017-10-09 22:49:54 +09:00
Cameron Steffen 9ccb7108b5 fix never_loop 2017-10-08 17:26:39 -05:00
Cameron Steffen a013568f70 add never_loop tests 2017-10-08 17:03:34 -05:00
Andriy S. from cobalt 1dc0b5c9ec tests for `needless_range_loop` 2017-10-08 22:37:04 +03:00
Oliver Schneider 73a1dd8e7f Merge pull request #2117 from sinkuu/improve_take_by_value
Improve needless_pass_by_value
2017-10-08 20:14:55 +02:00
Niklas Fiekas 16781a1d89 Add tests for range_plus_one and range_minus_one 2017-10-08 14:15:37 +02:00
Oliver Schneider a54baad4fa Merge pull request #2112 from topecongiro/issue-2109
Add a suggestion to replace `map(f).unwrap_or(None)` with `and_then(f)`.
2017-10-08 11:51:15 +02:00
sinkuu 2be6245179 Duplicate ptr_arg's suggestion logic 2017-10-08 17:51:44 +09:00
sinkuu bf97cd0338 Reduce false-positives for needless_pass_by_value lint
Excluding a type whose reference also fulfills the trait bound.
2017-10-08 17:25:56 +09:00
Chris Emerson dcaaab3801 Add a test with a struct containing a String. 2017-10-07 23:32:09 +01:00
Chris Emerson fcdce8fc1d Merge branch 'master' into no_effect_with_drop 2017-10-07 23:24:36 +01:00