Commit Graph

236 Commits

Author SHA1 Message Date
Aleksey Kladov 169d5d371a Drop `repr(u32)` from SyntaxKind
Nomicon says it disables some optimizations:
https://doc.rust-lang.org/beta/nomicon/other-reprs.html#repru-repri
2018-01-28 12:24:03 +03:00
bors[bot] bec9f09134 Merge #18
18: Comments r=matklad a=matklad
2018-01-28 09:07:26 +00:00
Aleksey Kladov d3dedcace8 Document events a bit 2018-01-28 12:06:43 +03:00
Aleksey Kladov cd4e13f10a Document events a bit 2018-01-28 12:06:26 +03:00
Aleksey Kladov 52104f7d25 Explain TOMBSTONE and EOF 2018-01-28 11:43:59 +03:00
bors[bot] 092f9a6b98 Merge #17
17: Document the design of `FileBuilder` r=matklad a=matklad
2018-01-28 08:18:47 +00:00
Aleksey Kladov 1417f26f82 Document the design of `FileBuilder` 2018-01-28 11:18:17 +03:00
bors[bot] aff82e5ee1 Merge #16
16: Proof-of-concept SyntaxKind as enum r=matklad a=CAD97

This was the one bit about the original RFC I was most confused about. Why isn't `SyntaxKind` a normal `enum`?

If it's to signify that it's non-exhaustive [`#[non_exhaustive]`](https://github.com/rust-lang/rust/issues/44109) should be used. (Or `#[doc(hidden)] __Nonexhaustive` on stable.)

If it's so that more variants can be added externally, why? There's no need for that, that I can foresee.

If it's to expose the `SyntaxKind` type but not any of its instances, why? This is the only actual benefit I can see of this pseudo-enum style.

This diff is meant to be as non-invasive as possible, and as such reexports all symbols as they existed prior to this. It's diffed on top of the assumed-good-to-merge #15 to avoid the conflict between them.

Diff without #15: <4244948c6b>
Just `src/syntax_kinds.rs`: <4244948c6b (diff-8f0d69eb4fe0148851505f787b6fd3bb)>
2018-01-28 08:07:56 +00:00
bors[bot] efadcf7158 Merge #15
15: Add minimal docs to most public symbols r=matklad a=CAD97

Also sticks a safety on some warnings that rustc provides.

If you're just stubbing out a module and don't want rustc refusing to compile it because you haven't documented it yet, stick `#![allow(missing_docs)]` at the top.
2018-01-28 07:51:49 +00:00
Christopher Durham 4244948c6b Convert SyntaxKind to an enum 2018-01-27 21:52:22 -05:00
Christopher Durham 50b9012e10 Add minimal docs to most public symbols 2018-01-27 20:29:14 -05:00
bors[bot] 6d3caf58ca Merge #14
14: Normalize test newlines r=matklad a=CAD97

Tests pass with CRLF newlines now
2018-01-28 00:24:27 +00:00
Aleksey Kladov 5e0752ceda The last of the Masters 2018-01-28 03:23:05 +03:00
Christopher Durham 58ff03086f Normalize test newlines
Tests pass with CRLF newlines now
2018-01-27 19:19:53 -05:00
Aleksey Kladov fcc4987de5 Add appveyor badge 2018-01-28 03:15:30 +03:00
Aleksey Kladov ee6ebec70d Fix typo 2018-01-28 03:14:30 +03:00
Aleksey Kladov 6a57d2ae4a CI: add windows testing 2018-01-28 03:13:44 +03:00
Christopher Durham e6e61251ab
Merge pull request #12 from CAD97/enforce-fmt
Enforce rustfmt format
2018-01-27 18:51:12 -05:00
Christopher Durham 9140b3e728 Be explicit for Travis' sake 2018-01-27 18:47:42 -05:00
Christopher Durham 55e8755fbb Enforce rustfmt format 2018-01-27 18:36:02 -05:00
Christopher Durham 4de3c97b2a Enforce rustfmt format 2018-01-27 18:31:23 -05:00
Aleksey Kladov 357cd33581 Add tests for parser recovery in fields 2018-01-28 02:20:40 +03:00
Aleksey Kladov 3630aeb1ea Drop high-order stuff for good 2018-01-28 01:13:27 +03:00
Aleksey Kladov b7ae5bbba2 Simplify 2018-01-28 01:12:49 +03:00
Aleksey Kladov da9bfacd98 Brush up readme 2018-01-28 00:58:47 +03:00
Aleksey Kladov d32345e518 Fix link 2018-01-28 00:35:17 +03:00
Aleksey Kladov ffe545cc37 Brush up CONTRIBUTING.md 2018-01-28 00:34:16 +03:00
Aleksey Kladov a4880ca03e ⬆️ deps 2018-01-28 00:24:40 +03:00
Aleksey Kladov 9620175094 CI badge 2018-01-28 00:10:38 +03:00
Aleksey Kladov 60ab3cfb88 CI 2018-01-28 00:06:39 +03:00
Aleksey Kladov caba13a2dd Simplify 2018-01-28 00:05:31 +03:00
Aleksey Kladov d280c72338 Simplify 2018-01-22 11:31:55 +03:00
Aleksey Kladov 13c6a34354 Extract nested trees 2018-01-22 11:29:32 +03:00
Aleksey Kladov 645a1b5d73 Remove high-order bits from tuple struct 2018-01-22 02:21:53 +03:00
Aleksey Kladov 05ad469ac3 Command-line utilty to print the parse tree 2018-01-22 02:12:26 +03:00
Aleksey Kladov c8cf1d8cda Test attribute recovery 2018-01-21 00:36:17 +03:00
Aleksey Kladov efd538d793 Remove high-order bits from attributes 2018-01-21 00:31:29 +03:00
Aleksey Kladov 0b5d39f2a2 Markers API 2018-01-20 23:25:34 +03:00
Aleksey Kladov be60d5aa66 Drop more high-order stuff 2018-01-20 21:49:58 +03:00
Aleksey Kladov 111743d82c Drop more high-order stuff 2018-01-20 21:07:34 +03:00
Aleksey Kladov 410f948c5f Drop high-order combinators 2018-01-20 17:21:13 +03:00
Aleksey Kladov 3c612bfa3a Simplify 2018-01-15 22:41:57 +03:00
Aleksey Kladov 91fb7e2088 Rename `many` -> `repeat` 2018-01-15 21:44:30 +03:00
Aleksey Kladov 08f7c69f90 G: struct flavors 2018-01-13 22:00:26 +03:00
Aleksey Kladov 55891be06a G: use trees 2018-01-13 13:42:19 +03:00
Aleksey Kladov 29b2e0adcc G: allow self & super in paths 2018-01-13 11:55:03 +03:00
Aleksey Kladov f31d858607 G: visibility 2018-01-12 22:05:46 +03:00
Aleksey Kladov c111a1f7b8 Nest paths 2018-01-12 20:59:19 +03:00
Aleksey Kladov ca0c5ea38b Support tree rebalancing 2018-01-12 20:32:37 +03:00
Aleksey Kladov 15ae9026cf Encapsulate position 2018-01-11 23:25:14 +03:00