Commit Graph

353 Commits

Author SHA1 Message Date
Trevor Gross f18d4a86a7
Add myself to the review rotation 2024-07-14 17:53:39 -04:00
bors 09682988f2 Auto merge of #125935 - madsmtm:merge-os-apple, r=workingjubilee
Merge Apple `std::os` extensions modules into `std::os::darwin`

The functionality available on Apple platforms are very similar, and were (basically) duplicated for each platform.

This PR rectifies that by merging the code into one module.

Ultimately, I've done this to fix `./x build library --target=aarch64-apple-tvos,aarch64-apple-watchos,aarch64-apple-visionos`, as that currently fails because of dead code warnings.

Publically exposing these to tvOS/watchOS/visionOS targets is considered in https://github.com/rust-lang/rust/pull/123723, but that seems to be dragging out, and in any case I think it makes sense to do the refactor separately from stabilization.

r? libs

Fixes https://github.com/rust-lang/rust/issues/121640 and https://github.com/rust-lang/rust/issues/124825.
2024-07-14 16:28:07 +00:00
Mads Marquart 306d5788a6 Merge Apple `std::os` extensions modules into `std::os::darwin`
The functionality available on Apple platforms are very similar, and
were duplicated for each platform.

Additionally, this fixes a warning when compiling the standard library
for tvOS, watchOS and visionOS by marking the corresponding code as
dead code.
2024-07-14 15:31:54 +02:00
Mara Bos c8e44471b8 Temporarily remove me from review rotation. 2024-07-10 11:56:56 +02:00
Jacob Pratt 103a77202a
Rollup merge of #127521 - spastorino:remove-myself-from-smir-pings, r=lqd
Remove spastorino from SMIR

r? ```@oli-obk```
2024-07-10 00:37:13 -04:00
Santiago Pastorino 4700b5b01f
Remove spastorino from SMIR 2024-07-09 12:50:47 -03:00
clubby789 9f66af4319 Remove clubby789 from review rotation 2024-07-05 22:08:13 +01:00
Jakub Beránek 6a2638e6c4 Autolabel `rustc-perf-wrapper` changes with t-bootstrap label 2024-06-29 16:07:39 +02:00
Michael Goulet 59c258f51f
Rollup merge of #126909 - onur-ozkan:add-kobzol, r=matthiaskrgr
add @kobzol to bootstrap team for triagebot

Welcome ``@Kobzol`` !
2024-06-24 15:51:05 -04:00
onur-ozkan 45261ff2ec add @kobzol to bootstrap team for triagebot
Signed-off-by: onur-ozkan <work@onurozkan.dev>
2024-06-24 18:38:55 +03:00
Matthias Krüger 8ffb5f936a compiletest: make the crash test error message abit more informative 2024-06-24 15:18:50 +02:00
许杰友 Jieyou Xu (Joe) d3b1367c43 Autolabel run-make tests, remind to update tracking issue
- Autolabel PRs modifying `tests/run-make/` and
  `src/tools/run-make-support/` with `X-run-make` label.
- Add reminder to update the tracking issue
  <https://github.com/rust-lang/rust/issues/121876>
  if applicable when `tests/run-make/` is modified by a PR.
2024-06-09 15:52:41 +00:00
onur-ozkan 1a07e58c09 register libcxx-version in triagebot
Signed-off-by: onur-ozkan <work@onurozkan.dev>
2024-06-06 07:01:34 +03:00
Jubilee 45507e4304
Rollup merge of #125566 - camelid:notify-accepted, r=GuillaumeGomez
Notify T-rustdoc for beta-accepted and stable-accepted too

Otherwise, it's unclear when the nomination label is removed whether the backport was accepted, thus nomination removed, or if the backport was rejected, thus nomination removed.

r? ````@GuillaumeGomez````
2024-05-26 15:28:29 -07:00
Jubilee c51fc1d02b
Rollup merge of #125544 - Urgau:check-cfg-mention-cargo-specific, r=jieyouxu
Also mention my-self for other check-cfg docs changes

This PR adds a mention for my-self for the recently added `src/doc/rustc/src/check-cfg` directory.

*I had to add a second mention just for the directory since [`Path::starts_with`](https://doc.rust-lang.org/std/path/struct.Path.html#method.starts_with) as used by [triagebot](48f29f351c/src/handlers/mentions.rs (L69)), matches on path components and so can never return true for a file and directory at the same time.*
2024-05-26 15:28:28 -07:00
Matthias Krüger 89c3739358
Rollup merge of #125375 - Kobzol:triagebot-rfl-ping-group, r=Mark-Simulacrum
Create a triagebot ping group for Rust for Linux

Corresponding rustc-dev-guide PR [here](https://github.com/rust-lang/rustc-dev-guide/pull/1984). Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Testing.20Rust.20for.20Linux.20in.20our.20CI).
2024-05-26 13:43:06 +02:00
Noah Lev 91b3ef5b4a Notify T-rustdoc for beta-accepted and stable-accepted too
Otherwise, it's unclear when the nomination label is removed whether the
backport was accepted, thus nomination removed, or if the backport was
rejected, thus nomination removed.
2024-05-25 23:00:15 -07:00
Urgau bebcb4e4b8 Also mention my-self for check-cfg docs changes 2024-05-25 13:56:19 +02:00
Matthias Krüger ee54e29333
Rollup merge of #125519 - lcnr:tag-next-solver, r=compiler-errors
tag more stuff with `WG-trait-system-refactor`

r? `@compiler-errors`
2024-05-24 23:01:12 +02:00
lcnr c97ed58c38 tag more stuff with `WG-trait-system-refactor` 2024-05-24 20:27:47 +00:00
Jakub Beránek e2ef4e1b0d
Notify kobzol after changes to `opt-dist` 2024-05-24 10:36:44 +02:00
Jakub Beránek ab73bb25cf
Add a comment 2024-05-22 13:04:14 +02:00
Jakub Beránek c773debc87
Create a triagebot ping group for Rust for Linux 2024-05-21 19:38:35 +02:00
Boxy cf3414a5c1 add boxy to compiler reviews 2024-05-17 17:06:03 +01:00
León Orell Valerian Liehr 734a109998
Rollup merge of #125159 - fmease:allow-unauth-labels-l-pg-z, r=jieyouxu
Meta: Allow unauthenticated users to modify `L-*`, `PG-*` and `-Z*` labels

Complements: rust-lang/rust-forge#744.

1. `L-*`: Issues and PRs concerning specific lints
2. `PG-*`: Issues and PRs concerning specific project groups
3. `-Z*`: Issues and PRs concerning specific unstable `-Z` compiler options

These are safe to expose. Allows unauthenticated users greater leeway in triaging issues.
We have a lot of such people <3 and I want to support them as much as possible.

r? jieyouxu (you get assigned a lot these days :P) or compiler
2024-05-15 22:01:20 +02:00
León Orell Valerian Liehr 72a48fc68c
Allow unauthenticated users to modify `L-*`, `PG-*` and `-Z*` labels 2024-05-15 20:24:09 +02:00
Matthias Krüger cf8a084d26
Rollup merge of #119959 - fmease:triagebot-prioritization-alert-label, r=apiraino
[meta] Clarify prioritization alert

Apparently, there used to exist the label <kbd>I-nominated</kbd> judging from this entry:

8847bda592/triagebot.toml (L393)

Since it was replaced with individual team labels, I think it makes sense to update the prioritization alert. Of course, it's not super important since the members of WG-prioritization already know that. This is just cleanup.

r? apiraino or wg-prioritization
2024-05-13 20:29:17 +02:00
bors 645bc609d9 Auto merge of #124883 - onur-ozkan:change-stage0-file, r=Mark-Simulacrum
use key-value format in stage0 file

Currently, we are working on the python removal task on bootstrap. Which means we have to extract some data from the stage0 file using shell scripts. However, parsing values from the stage0.json file is painful because shell scripts don't have a built-in way to parse json files.

This change simplifies the stage0 file format to key-value pairs, which makes it easily readable from any environment.

See the zulip thread for more details: https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/Using.20different.20format.20in.20the.20stage0.20file
2024-05-12 06:26:20 +00:00
onur-ozkan aa2faefe12 remove outdated stage0.json parts
Signed-off-by: onur-ozkan <work@onurozkan.dev>
2024-05-11 20:48:58 +03:00
Ben Kimock e6f961c762 Add @saethlin to some triagebot groups 2024-05-10 20:28:50 -04:00
Matthias Krüger 78ee4ce9b8
Rollup merge of #124768 - fmease:enable-triagebot-transfer-2, r=jackh726
[resubmission] Meta: Enable the brand new triagebot transfer command

#124725, https://github.com/rust-lang/rust/pull/124725#issuecomment-2094783916

r? ghost
2024-05-06 06:21:04 +02:00
bors 3170bd9d1b Auto merge of #124146 - madsmtm:apple-triage, r=dtolnay
Triagebot: Rename `macos` ping group to `apple`

Expand the scope of the macOS ping group to all Apple targets.

Blocked on https://github.com/rust-lang/team/pull/1436 (rename in `team` repo)
Blocked on https://github.com/rust-lang/rustc-dev-guide/pull/1964 (referenced documentation link)

`@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
2024-05-05 22:22:58 +00:00
Mads Marquart dc153f8c50 Change the label for the Apple ping group to the new O-apple 2024-05-05 21:20:25 +02:00
León Orell Valerian Liehr 6c1b8d2846
Meta: Enable the triagebot transfer command 2024-05-05 21:08:44 +02:00
lcnr 146f637826 add triage bot mentions 2024-04-25 20:21:38 +00:00
Boxy e1d12ffb6c removal 2024-04-21 18:41:32 +01:00
Mads Marquart e64cbc4edb Rename `macos` ping group to `apple` 2024-04-19 05:51:44 +02:00
Mads Marquart b90bcd6e7d Make autolabelling for macOS slightly better 2024-04-19 05:51:02 +02:00
Matthias Krüger d7d10707e0
Rollup merge of #116957 - fmease:meta-notify-rustdoc-zulip-on-backport-nominations, r=GuillaumeGomez
meta: notify #t-rustdoc Zulip stream on backport nominations

In July '23, it was decided to handle rustdoc-specific backport nominations in t-rustdoc meetings going forward ([Zulip announcement](https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/T-rustdoc.20backports/near/374828518)). However, t-rustdoc meetings are far too infrequent for them to address nominations on time (contrary to the weekly t-compiler meetings).

Hence GuillaumeGomez and I came to the conclusion that {beta,stable}-nominated rustdoc PRs should be dealt with on a case by case basis, e.g. on Zulip.

This PR attempts to partially automate this process. ~~Sadly, `triagebot` is not quite as flexible has I've hoped. Blocked on `triagebot` improvements (see the `FIXME`s in this PR).~~ (Fixed in rust-lang/triagebot#1791).

r? GuillaumeGomez
2024-04-17 18:01:37 +02:00
Nicholas Nethercote 9a67a6cb04 Reinstate nnethercote to the review rotation. 2024-04-17 08:37:04 +10:00
Matthias Krüger f54219c473
Rollup merge of #123501 - Urgau:stabilize-check-cfg, r=petrochenkov
Stabilize checking of cfgs at compile-time: `--check-cfg` option

This PR stabilize the `--check-cfg` CLI option of `rustc` (and `rustdoc`) 🎉.

In particular this PR does two things:
  1. it makes the `--check-cfg` option stable
  2. and it moves the documentation to the stable books

FCP: https://github.com/rust-lang/rust/issues/82450#issuecomment-1965328542

Resolves #82450

``@rustbot`` labels +S-blocked +F-check-cfg
r? ``@petrochenkov``
2024-04-16 17:54:41 +02:00
León Orell Valerian Liehr 8f3d7fe038
meta: notify #t-rustdoc Zulip stream on backport nominations 2024-04-16 17:41:33 +02:00
Urgau a20de73ccf Move --check-cfg documentation to stable books 2024-04-15 21:49:56 +02:00
Ramon de C Valle 99e88e59c8 sanitizers: Add rustc_sanitizers to triagebot.toml 2024-04-15 12:41:32 -07:00
Matthias Krüger 5b8b2365eb
Rollup merge of #123519 - Urgau:session-cfg-check-cfg-improvements, r=wesleywiser
Improve cfg and check-cfg configuration

This PR improves cfg and check-cfg configuration by:
 1. Extracting both logic under a common module (to improve the connection between the two)
 2. Adding more documentation, in particular some steps when adding a new cfg

I also added my-self as mention in our triagebot conf for the new module.

Inspired by https://github.com/rust-lang/rust/pull/123411#discussion_r1554056681
2024-04-06 08:56:35 +02:00
Urgau c39c0e1e2b Add mention for Urgau about cfg and check-cfg configuration changes 2024-04-05 23:41:00 +02:00
Guillaume Gomez 7a38225e20
Rollup merge of #123509 - jieyouxu:add-jieyouxu-review-rotation, r=Mark-Simulacrum
Add jieyouxu to compiler review rotation and as a reviewer for `tests/run-make`, `src/tools/run-make-support` and `src/tools/compiletest`
2024-04-05 22:33:28 +02:00
Guillaume Gomez 74a5bc6c9e
Rollup merge of #121419 - agg23:xrOS-pr, r=davidtwco
Add aarch64-apple-visionos and aarch64-apple-visionos-sim tier 3 targets

Introduces `aarch64-apple-visionos` and `aarch64-apple-visionos-sim` as tier 3 targets. This allows native development for the Apple Vision Pro's visionOS platform.

This work has been tracked in https://github.com/rust-lang/compiler-team/issues/642. There is a corresponding `libc` change https://github.com/rust-lang/libc/pull/3568 that is not required for merge.

Ideally we would be able to incorporate [this change](https://github.com/gimli-rs/object/pull/626) to the `object` crate, but the author has stated that a release will not be cut for quite a while. Therefore, the two locations that would reference the xrOS constant from `object` are hardcoded to their MachO values of 11 and 12, accompanied by TODOs to mark the code as needing change. I am open to suggestions on what to do here to get this checked in.

# Tier 3 Target Policy

At this tier, the Rust project provides no official support for a target, so we place minimal requirements on the introduction of targets.

> A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

See [src/doc/rustc/src/platform-support/apple-visionos.md](e88379034a/src/doc/rustc/src/platform-support/apple-visionos.md)

> Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.
> * Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it.
> * If possible, use only letters, numbers, dashes and underscores for the name. Periods (.) are known to cause issues in Cargo.

This naming scheme matches `$ARCH-$VENDOR-$OS-$ABI` which is matches the iOS Apple Silicon simulator (`aarch64-apple-ios-sim`) and other Apple targets.

> Tier 3 targets may have unusual requirements to build or use, but must not
  create legal issues or impose onerous legal terms for the Rust project or for
  Rust developers or users.
>  - The target must not introduce license incompatibilities.
>  - Anything added to the Rust repository must be under the standard Rust license (`MIT OR Apache-2.0`).
>  - The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the `tidy` tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to besubject to any new license requirements.
>  - Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries. Host tools built for the target itself may depend on the ordinary runtime libraries supplied by the platform and commonly used by other applications built for the target, but those libraries must not be required for code generation for the target; cross-compilation to the target must not require such libraries at all. For instance, `rustc` built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust's license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3.
> - "onerous" here is an intentionally subjective term. At a minimum, "onerous" legal/licensing terms include but are *not* limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users.

This contribution is fully available under the standard Rust license with no additional legal restrictions whatsoever. This PR does not introduce any new dependency less permissive than the Rust license policy.

The new targets do not depend on proprietary libraries.

> Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.

This new target mirrors the standard library for watchOS and iOS, with minor divergences.

> The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.

Documentation is provided in [src/doc/rustc/src/platform-support/apple-visionos.md](e88379034a/src/doc/rustc/src/platform-support/apple-visionos.md)

> Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.
> * This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements.

> Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via `@)` to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.
> * Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications.

> Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.
> * In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target.

I acknowledge these requirements and intend to ensure that they are met.

This target does not touch any existing tier 2 or tier 1 targets and should not break any other targets.
2024-04-05 22:33:25 +02:00
许杰友 Jieyou Xu (Joe) 8d17b2d79a
Add jieyouxu to compiler review rotation and as a reviewer for `tests/run-make`, `src/tools/run-make-support` and `src/tools/compiletest` 2024-04-05 19:08:23 +01:00
lcnr 6db7ac6233 ping on wf changes, remove fixme 2024-04-05 15:09:48 +02:00