Commit Graph

81 Commits

Author SHA1 Message Date
Michael Wright 98585a0324 Fix .map(..).unwrap_or_else(..) bad suggestion
Closes #4144
2019-06-02 08:50:20 +02:00
airt 2d4d275519 change |&x| to |x| in stderr file 2019-05-01 01:06:15 +08:00
Philipp Hansch 0f69aac3d9
Add run-rustfix for option_map_or_none lint 2019-04-18 08:12:59 +02:00
Philipp Hansch 25e2affd31
UI test cleanup: Extract iter_nth tests 2019-04-11 08:23:43 +02:00
Philipp Hansch fdc2255e81
UI test cleanup: Extract or_fun_call tests 2019-04-11 07:47:04 +02:00
flip1995 3282955238
Update tests 2019-03-10 22:07:10 +01:00
Wilco Kusee eb70a72459
Fix false negative 2019-02-26 17:29:36 +01:00
Wilco Kusee 54ab22f6db
Only suggest map_or for copy types 2019-02-26 17:27:40 +01:00
Michael Wright 7a43509cc4 rustfmt tests/ui/methods.rs 2019-02-22 08:05:21 +02:00
Michael Wright b96c4329db Add `#[rustfmt::skip]` to methods tests
Many people run rustfmt automatically on save. Format-dependent tests
should be marked with `#[rustfmt::skip]` to prevent accidental
reformatting from this. As a bonus the rest of the code can the formatted.
2019-02-22 07:49:17 +02:00
Philipp Hansch 38d4ac7cea
Remove all copyright license headers
Discussion previously happened in https://github.com/rust-lang/rust/pull/43498
2019-01-08 21:46:39 +01:00
Philipp Hansch a5d3f37c5a
Use compiletest's aux-build header instead of include macro 2019-01-02 22:48:44 +01:00
Philipp Hansch 0c54913afe
Extract IteratorFalsePositives into option_helpers.rs
This was previously duplicated in #3605
2019-01-02 07:49:28 +01:00
Philipp Hansch eaaee23847
UI test cleanup: Extract lint from methods.rs test 2019-01-02 07:23:00 +01:00
Philipp Hansch 8c4c458ee9
UI test cleanup: Extract iter_skip_next from methods.rs
cc #2038
2018-12-30 13:46:21 +01:00
Russell Greene d127aed737 Merge new_without_default_derive into new_without_default 2018-12-28 10:57:58 -07:00
flip1995 d2dbd0b8a5
Update *.stderr files 2018-12-28 12:41:12 +01:00
Matthias Krüger 9b839cd4b5 update line numbers of tests 2018-12-09 17:24:08 +01:00
Philipp Hansch 26569f3dde
UI test cleanup: Extract expect_fun_call tests
Note that the new stderr file does not include a `shadow-unrelated`
error, because the new UI test file does not use `#![warn(clippy::all)]`
2018-11-02 07:18:56 +01:00
Philipp Hansch 840e50e97f
Don't expand macro in or_fun_call suggestion 2018-10-27 15:47:56 +02:00
Josh Mcguigan 348d18ebd8 Removed new_ret_no_self tests from method.rs 2018-10-13 06:25:10 -07:00
Michael Wright 7499cb543d Fix #2937 2018-10-10 07:52:58 +02:00
Manish Goregaokar e9c025ea70 Add license header to Rust files 2018-10-06 09:43:08 -07:00
flip1995 e9af09c274 Adapt the *.stderr files of the ui-tests to the tool_lints 2018-08-29 11:08:29 -07:00
Dale Wijnand 7933d445d1
Move shadow_unrelated to pedantic 2018-08-14 09:52:27 +01:00
Michael Wright 534d546c81 Fix #2979 2018-08-02 08:56:53 +02:00
Michael Wright b90fc5edfa Fix #2894 2018-07-15 10:38:40 +02:00
Daniel Wagner-Hall d3124731b7 Fix some existing test expectations 2018-06-14 23:13:12 +01:00
Donald Robertson 451fd5feb9 Extracting arguments to format to pass directly to panic when appropriate 2018-06-05 21:15:08 +01:00
Donald Robertson 1ead12c500 Adding handling and tests for custom type with implemented expect method 2018-06-04 19:43:03 +01:00
Donald Robertson fe8c9d5965 Ensuring correct lint message is output for Option and Result type 2018-06-04 19:43:03 +01:00
Donald Robertson 05c1ccebaf Warn if non-trivial work is done inside .expect
- added tests for common usages of format and as_str arguments to expect
- added tests for usages of Option and Result types
- given performance impact of passing non literal expressions to expect, added to perf group
2018-06-04 19:43:03 +01:00
Philipp Hansch dfde407f0d
Move unnecessary_fold UI tests to separate file 2018-04-12 22:16:43 +02:00
bootandy a7c97256dc Stop unwanted newlines being applied on unwrap_or 2018-02-21 11:29:08 -05:00
bootandy 941e062fd4 Fix: point to correct problem part of code
Fix span so it no longer contains the whole train-wreck of code and only
points to the problem function (for the unwrap_or lint).

https://github.com/rust-lang-nursery/rust-clippy/issues/2422

Update ui test methods - it had several cases where the error message
span is now shorter
2018-02-19 12:14:53 -05:00
Phil Ellison 2132e5c58c Fix unnecessary_fold bug 2018-01-22 05:34:42 +00:00
Oliver Schneider 71abd81d22 Update error count 2018-01-19 13:18:44 +01:00
Oliver Schneider 70302595a4
Merge branch 'master' of github.com:Manishearth/rust-clippy into fold_any 2018-01-19 12:10:24 +01:00
Phil Ellison b73efad600 Add some reviewer comments 2018-01-17 21:06:16 +00:00
Phil Ellison 29a2dd4cb8 Fix bug. Don't expect lint when acc is on rhs 2018-01-17 20:11:40 +00:00
Phil Ellison 1cac693bc7 Lint on folds implementing .all, .sum and .product 2018-01-17 19:12:44 +00:00
Oliver Schneider 4f21b5b112
Update changed ui tests 2018-01-17 14:44:40 +01:00
Phil Ellison a64d19cc0e Fix error span to play nicely with rustfix 2018-01-16 21:20:55 +00:00
Phil Ellison 70a5535ffa Address some review comments 2018-01-14 18:18:09 +00:00
Phil Ellison 1feb9fd550 Tidy using if_chain and snippet function. Actually check that the initial fold value is false. Remove some unwraps 2018-01-14 09:30:08 +00:00
Phil Ellison f6e56d2559 First pass at linting for .any expressed as a .fold 2018-01-14 08:27:53 +00:00
Laurent Mazare e7f4a9bb46 Fix for the new nightly version. 2017-11-20 07:47:28 +00:00
cgm616 3902b836e7 Update tests 2017-11-02 23:54:35 -05:00
cgm616 ee289c9f88 Merge branch 'master' of github.com:rust-lang-nursery/rust-clippy 2017-11-02 22:57:07 -05:00
G. Endignoux 87fd68731d Update UI tests. 2017-10-30 14:10:38 +01:00