Commit Graph

7494 Commits

Author SHA1 Message Date
bors 059568faeb Auto merge of #4856 - lzutao:rtim-non-installed, r=flip1995
build: check if RTIM is not installed

changelog: none
2019-11-29 18:50:51 +00:00
bors 04036877ef Auto merge of #4863 - phansch:use_self, r=flip1995
Move use_self to nursery

Closes #4859

We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.

changelog: Move `use_self` lint to nursery, due to many false positives
2019-11-29 18:17:41 +00:00
bors 350f3d6f5b Auto merge of #4845 - flip1995:clippy_toml_deps, r=phansch
Don't error on clippy.toml of dependencies

Fixes #3874

Checking for `metadata` wasn't enough anymore. `--cap-lints allow` only appears when compiling deps though.

changelog: none
2019-11-29 14:07:57 +00:00
flip1995 fd7eca2baf
Run update_lints 2019-11-29 14:50:19 +01:00
bors 4780ac0f02 Auto merge of #4857 - rust-lang:rustup, r=matthewjasper,oli-obk
Rustup

From https://github.com/rust-lang/rust/pull/66246/

changelog: none
2019-11-29 12:56:14 +00:00
flip1995 604e6ba0e2
Add projections check to EUV for escape analysis 2019-11-29 12:57:10 +01:00
flip1995 b2523afae4
Use infer_ctxt 2019-11-29 11:12:19 +01:00
Philipp Hansch 70a2a29453
Move use_self to nursery
Closes #4859

We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.

changelog: Move `use_self` lint to nursery, due to many false positives
2019-11-29 07:51:49 +01:00
Philipp Krones 82066d2f0e
Use `println!` on success instead of `eprintln!`
Co-Authored-By: Phil Hansch <dev@phansch.net>
2019-11-28 17:48:29 +01:00
flip1995 a6289ccd4c
Revert "Disable chalk integration test. Output too large"
This reverts commit 553db874d7.
2019-11-28 16:55:21 +01:00
flip1995 6271631ae9
Remove the old integration-tests.sh script 2019-11-28 16:55:21 +01:00
flip1995 21e81f1712
Use rust implementation for integration tests in CI 2019-11-28 16:55:21 +01:00
flip1995 3e1139a7dc
Rust implementation of integration test 2019-11-28 16:55:21 +01:00
flip1995 a61fd43a79
Don't error on clippy.toml of dependencies 2019-11-28 16:42:29 +01:00
Manish Goregaokar 45842e5131 Fix categorizations 2019-11-28 07:33:12 -08:00
Manish Goregaokar c1c5c3522d Fix arguments on ExprUseVisitor::new 2019-11-28 07:20:37 -08:00
Manish Goregaokar dc9d839410 euv moved from middle to typeck 2019-11-28 07:17:56 -08:00
Manish Goregaokar 85bb66480c cmt_ -> Place 2019-11-28 07:09:02 -08:00
Lzu Tao d9af448255 build: check if RTIM is not installed 2019-11-28 18:12:01 +07:00
bors b5a6714155 Auto merge of #4849 - flip1995:deny_warnings, r=phansch
Deny warnings in CI

Removes the `debugging` feature, that wasn't used anymore and adds/enables the `deny-warnings` feature for every sub-crate of Clippy.

changelog: none
2019-11-28 10:27:46 +00:00
bors dbdd75ab52 Auto merge of #4855 - phansch:rollup-x7yail7, r=phansch
Rollup of 3 pull requests

Successful merges:

 - #4832 (Add some positive examples to lint docs)
 - #4842 ([comparison_chain] #4827 Check `core::cmp::Ord` is implemented)
 - #4847 (fixing a typo)

Failed merges:

changelog: none

r? @ghost
2019-11-28 09:30:16 +00:00
Phil Hansch a05f3cb9a1
Rollup merge of #4847 - rust-lang:offest, r=phansch
fixing a typo

changelog: none
2019-11-28 10:19:06 +01:00
Phil Hansch 1165176840
Rollup merge of #4842 - timbodeit:comparison-chain-false-positive-4827, r=flip1995
[comparison_chain] #4827 Check `core::cmp::Ord` is implemented

Only emit `comparison_chain` lint, if `cmp` is actually available on the type being compared. Don't emit lint in cases where only `PartialOrd` is implemented.

I haven't yet fully understood [Adjustments](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/ty/adjustment/struct.Adjustment.html). I would appreciate, if someone could double check whether my usage of [expr_ty](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/ty/struct.TypeckTables.html#method.expr_ty) in `clippy_lints/src/comparison_chain.rs:91` is correct or if there are cases where using [expr_ty_adjusted](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/ty/struct.TypeckTables.html#method.expr_ty_adjusted) would lead to a different result when used with `utils::implements_trait`.

---

fixes #4827
changelog: [comparison_chain] Check `core::cmp::Ord` is implemented
2019-11-28 10:19:05 +01:00
Phil Hansch 6686892cbf
Rollup merge of #4832 - dario23:i4829, r=phansch
Add some positive examples to lint docs

fixes #4829
changelog: Add some positive examples to lint docs
2019-11-28 10:19:04 +01:00
bors f3288eb48d Auto merge of #4851 - daxpedda:float-arithmetic, r=flip1995
Remove negative float literal checks.

Fixes #4850.

changelog: Remove negative float literal checks.
2019-11-28 09:11:45 +00:00
bors d377486561 Auto merge of #4821 - Areredify:as_conversions, r=flip1995
Add `as_conversions` lint

changelog: closes #4771, adding a new pedantic allow-by-default lint that lints against any usage of `as`.
2019-11-28 08:53:36 +00:00
bors d6accfcc82 Auto merge of #4808 - euclio:string-lit-as-bytes, r=phansch
trigger string_lit_as_bytes when literal has escapes

---

changelog: fix string_lit_as_bytes false negative

Depends on rust-lang/rust#66349.

Fixes #4796.
2019-11-28 07:26:04 +00:00
bors 7f745dabd9 Auto merge of #4848 - lzutao:result-map_or, r=flip1995
make use of Result::map_or

Fixes #1590

changelog: none
2019-11-28 07:07:16 +00:00
Lzu Tao d0e0ffa99f make use of Result::map_or 2019-11-28 10:52:20 +07:00
bors 7b8e8293d0 Auto merge of #4846 - flip1995:rustup, r=Manishearth
Rustup to rustc 1.41.0-nightly (e87a205c2 2019-11-27)

Rustups:

- rust-lang/rust#66671 (Ast address-of)
- rust-lang/rust#64856 (Scope format! temporaries)
 - http://github.com/rust-lang/rust/pull/66719

changelog: none
2019-11-27 23:10:00 +00:00
Manish Goregaokar 40c91ec758 config.usize_ty -> config.ptr_width
From http://github.com/rust-lang/rust/pull/66719
2019-11-27 15:09:48 -08:00
Manish Goregaokar 73646487af Add blank stderr file for cant_be_const test 2019-11-27 15:09:48 -08:00
Manish Goregaokar e381143a6b More borrowkind fixes 2019-11-27 15:09:48 -08:00
Manish Goregaokar 3430bc1bc5 Re-add wildcards for BorrowKind in some places 2019-11-27 15:09:48 -08:00
Manish Goregaokar 29777b5cc5
Merge pull request #4852 from lzutao/cargo_install
rustup cargo install-upgrade
2019-11-27 14:51:13 -08:00
Manish Goregaokar 341e266508 Add BorrowKind::Ref 2019-11-27 14:39:28 -08:00
Lzu Tao 6173478cf8 rustup cargo install-upgrade 2019-11-27 16:32:51 +07:00
Andy Russell d33ad45d7d
trigger string_lit_as_bytes when literal has escapes 2019-11-26 17:07:17 -05:00
daxpedda e46bedca3c
Remove negative float literal checks. 2019-11-25 19:23:28 +01:00
flip1995 d51a80c57e
Enable deny-warnings feature everywhere in CI 2019-11-25 17:23:48 +01:00
flip1995 1d3ec29880
Remove unused debugging feature 2019-11-25 17:23:07 +01:00
Mikhail Babenko 9ec8888b91 implemented `as_conversions` lint
actuall add files

add better example and change pedantic to restriction
2019-11-25 18:12:52 +03:00
flip1995 6eeac46b91
Run rustfmt 2019-11-25 15:20:10 +01:00
Andre Bogus 47ef5394de fixing a typo 2019-11-25 14:06:34 +01:00
flip1995 d2d62de841
Rustup to rust-lang/rust#64856 2019-11-25 13:56:24 +01:00
flip1995 d43c424145
Rustup to rust-lang/rust#66671 2019-11-25 13:18:38 +01:00
Tim Bodeit fff9a8ea9c [comparison_chain] #4827 Check `core::cmp::Ord` is implemented
Only emit lint, if `cmp` is actually available on the type being
compared. Don't emit lint in cases where only `PartialOrd` is
implemented.
2019-11-24 10:00:06 +01:00
bors cc35165f52 Auto merge of #4840 - flip1995:rollup-jqk3a3i, r=flip1995
Rollup of 5 pull requests

Successful merges:

 - #4730 (Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body)
 - #4766 (Fix false positive in derive_hash_xor_eq)
 - #4811 (Literal Representation Restructure)
 - #4820 (doc: fix the comment above the lint function)
 - #4830 (use more efficient code to generate repeated string)

Failed merges:

r? @ghost

changelog: none
2019-11-23 17:40:57 +00:00
Philipp Krones b4524004e0
Rollup merge of #4830 - lzutao:str-repeat, r=flip1995
use more efficient code to generate repeated string

see https://rust.godbolt.org/z/z9vrFP for comparison

changelog: none
2019-11-23 18:16:03 +01:00
Philipp Krones ae69bc4980
Rollup merge of #4820 - guanqun:comment-fix, r=flip1995
doc: fix the comment above the lint function

it's a simple comment fix.

---

changelog: none
2019-11-23 18:16:01 +01:00