From da8b56d99ab50f628d94210225507d87a4cb0251 Mon Sep 17 00:00:00 2001 From: Manish Goregaokar Date: Fri, 10 May 2019 19:23:26 -0700 Subject: [PATCH] Fix needless_bool.rs --- clippy_lints/src/needless_bool.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/clippy_lints/src/needless_bool.rs b/clippy_lints/src/needless_bool.rs index 94febdbd8a7..0404bc41570 100644 --- a/clippy_lints/src/needless_bool.rs +++ b/clippy_lints/src/needless_bool.rs @@ -3,7 +3,7 @@ //! This lint is **warn** by default use crate::utils::sugg::Sugg; -use crate::utils::{in_macro, span_lint, span_lint_and_sugg}; +use crate::utils::{higher, in_macro, span_lint, span_lint_and_sugg}; use rustc::hir::*; use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; use rustc::{declare_lint_pass, declare_tool_lint}; @@ -59,7 +59,7 @@ declare_lint_pass!(NeedlessBool => [NEEDLESS_BOOL]); impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessBool { fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) { use self::Expression::*; - if let ExprKind::If(ref pred, ref then_block, Some(ref else_expr)) = e.node { + if let Some((ref pred, ref then_block, Some(ref else_expr))) = higher::if_block(&e) { let reduce = |ret, not| { let mut applicability = Applicability::MachineApplicable; let snip = Sugg::hir_with_applicability(cx, pred, "", &mut applicability); @@ -119,7 +119,7 @@ fn parent_node_is_if_expr<'a, 'b>(expr: &Expr, cx: &LateContext<'a, 'b>) -> bool let parent_node = cx.tcx.hir().get_by_hir_id(parent_id); if let rustc::hir::Node::Expr(e) = parent_node { - if let ExprKind::If(_, _, _) = e.node { + if higher::if_block(&e).is_some() { return true; } }