dnrops
/
rust
mirror of https://github.com/rust-lang/rust.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rollup merge of #123568 - Oneirical:delete-tests, r=wesleywiser 

Clean up tests/ui by removing `does-nothing.rs`

In [a previous PR](https://github.com/rust-lang/rust/pull/123297#issuecomment-2039887806), it was suggested that this test be removed:

> it's testing a basic diagnostic for an unknown variable (added over a decade ago for https://github.com/rust-lang/rust/issues/154) that is already covered by probably dozens or hundreds of other tests.

It was then suggested that [opening a new PR](https://github.com/rust-lang/rust/pull/123563#discussion_r1554654102) for this would be more organized.

I'm setting this as a draft, as:

1. The tests/ui directory is rather disorganized, a large quantity of tests are not even contained inside their own directories. This PR could turn into "clean up the UI tests directory", if I were to place everything into categories (for example, everything related to CLI flags could get placed in a cli directory).
2. This will have a merge conflict with #123563 should that get merged. I trust that _this time_, I won't run into [The Incident](https://github.com/rust-lang/rust/pull/123297#issuecomment-2041137569) while rebasing. Edit: Yay, I did it properly!
This commit is contained in:
Matthias Krüger 2024-04-10 04:27:39 +02:00 committed by GitHub
parent 7dd24d88ab cbf150177f
commit c14b468cca
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/tools/tidy/src/ui_tests.rs
View File

@ -18,7 +18,7 @@ const ENTRY_LIMIT: usize = 900;
// FIXME: The following limits should be reduced eventually.
const ISSUES_ENTRY_LIMIT: usize = 1722;
const ROOT_ENTRY_LIMIT: usize = 861;
const ROOT_ENTRY_LIMIT: usize = 859;
const EXPECTED_TEST_FILE_EXTENSIONS: &[&str] = &[
"rs", // test source files

2
tests/ui/does-nothing.rs
View File

@ -1,2 +0,0 @@
fn main() { println!("doing"); this_does_nothing_what_the; println!("boing"); }
//~^ ERROR cannot find value `this_does_nothing_what_the` in this scope

9
tests/ui/does-nothing.stderr
View File

@ -1,9 +0,0 @@
error[E0425]: cannot find value `this_does_nothing_what_the` in this scope
--> $DIR/does-nothing.rs:1:32
|
LL | fn main() { println!("doing"); this_does_nothing_what_the; println!("boing"); }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0425`.